You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/06/28 15:34:40 UTC
[GitHub] [commons-codec] spinscale opened a new pull request #88: Remove hardcoded constants to improve readability
spinscale opened a new pull request #88:
URL: https://github.com/apache/commons-codec/pull/88
These constants are much harder to read than just the regular numbers, and are often only used once as well, so removing them makes the code more readable - to me at least.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-codec] coveralls commented on pull request #88: Remove hardcoded constants to improve readability
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #88:
URL: https://github.com/apache/commons-codec/pull/88#issuecomment-869901446
[](https://coveralls.io/builds/40941170)
Coverage remained the same at 94.647% when pulling **fdf0356ac7a98e669b2b39400a4112884b0b1bcc on spinscale:remove-useless-constants** into **4de60e8b68fb749e5380ecef018511bed946bee8 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-codec] britter merged pull request #88: Remove hardcoded constants to improve readability
Posted by GitBox <gi...@apache.org>.
britter merged pull request #88:
URL: https://github.com/apache/commons-codec/pull/88
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-codec] coveralls commented on pull request #88: Remove hardcoded constants to improve readability
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #88:
URL: https://github.com/apache/commons-codec/pull/88#issuecomment-869901446
[](https://coveralls.io/builds/40941170)
Coverage remained the same at 94.647% when pulling **fdf0356ac7a98e669b2b39400a4112884b0b1bcc on spinscale:remove-useless-constants** into **4de60e8b68fb749e5380ecef018511bed946bee8 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org