You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/08/31 19:59:36 UTC

[GitHub] [beam] emilymye commented on a change in pull request #15330: [BEAM-12683] Fix failing integration tests for Python Recommendation AI

emilymye commented on a change in pull request #15330:
URL: https://github.com/apache/beam/pull/15330#discussion_r699632517



##########
File path: sdks/python/apache_beam/ml/gcp/recommendations_ai_test_it.py
##########
@@ -102,7 +104,13 @@ def test_predict(self):
 
       assert_that(output, is_not_empty())
 
+  @classmethod
+  def tearDownClass(cls):
+    client = recommendationengine.CatalogServiceClient()
+    client.delete_catalog_item(

Review comment:
       Ideally we list and delete, with exception catching here (see precommit failure) in case another instance has decided to delete the same object.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org