You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/08/31 15:41:30 UTC
[GitHub] [geode-native] mmartell commented on a change in pull request #646: GEODE-8470: Properly stop running containers in SNI
mmartell commented on a change in pull request #646:
URL: https://github.com/apache/geode-native/pull/646#discussion_r480215816
##########
File path: clicache/integration-test2/SNITests.cs
##########
@@ -58,10 +58,10 @@ public SNITests(ITestOutputHelper testOutputHelper) : base(testOutputHelper)
public void Dispose()
{
- var dockerComposeProc = Process.Start(@"docker-compose.exe", "stop");
+ var dockerComposeProc = Process.Start(@"docker-compose.exe", "-f " + Config.SniConfigPath + "/docker-compose.yml" + " stop");
dockerComposeProc.WaitForExit();
- var dockerProc = Process.Start(@"docker.exe", "container prune -f");
+ var dockerProc = Process.Start(@"docker.exe", "system prune -f");
dockerProc.WaitForExit();
}
Review comment:
Good change. Didn't know about system.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org