You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Anoop Sam John (JIRA)" <ji...@apache.org> on 2012/05/08 17:27:48 UTC
[jira] [Created] (HBASE-5957) Mismatch with config param name in
xml and code
Anoop Sam John created HBASE-5957:
-------------------------------------
Summary: Mismatch with config param name in xml and code
Key: HBASE-5957
URL: https://issues.apache.org/jira/browse/HBASE-5957
Project: HBase
Issue Type: Bug
Reporter: Anoop Sam John
In hbase-default.xml there listed one param "io.storefile.bloom.cacheonwrite"
{code}
<property>
<name>io.storefile.bloom.cacheonwrite</name>
<value>false</value>
<description>
Enables cache-on-write for inline blocks of a compound Bloom filter.
</description>
</property>
{code}
No place in the code this config is getting used.
Instead in CacheConfig there is a config param name
{code}
/**
* Configuration key to cache compound bloom filter blocks on write.
*/
public static final String CACHE_BLOOM_BLOCKS_ON_WRITE_KEY =
"hfile.block.bloom.cacheonwrite";
{code}
Seems issue with entry in the xml file.
We can correct the xml with the config name as hfile.block.bloom.cacheonwrite ?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5957) Mismatch with config param name in
xml and code
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13274785#comment-13274785 ]
ramkrishna.s.vasudevan commented on HBASE-5957:
-----------------------------------------------
Committed to trunk.
Thanks for the patch Anoop and for the review Stack.
> Mismatch with config param name in xml and code
> -----------------------------------------------
>
> Key: HBASE-5957
> URL: https://issues.apache.org/jira/browse/HBASE-5957
> Project: HBase
> Issue Type: Bug
> Reporter: Anoop Sam John
> Attachments: HBASE-5957.patch
>
>
> In hbase-default.xml there listed one param "io.storefile.bloom.cacheonwrite"
> {code}
> <property>
> <name>io.storefile.bloom.cacheonwrite</name>
> <value>false</value>
> <description>
> Enables cache-on-write for inline blocks of a compound Bloom filter.
> </description>
> </property>
> {code}
> No place in the code this config is getting used.
> Instead in CacheConfig there is a config param name
> {code}
> /**
> * Configuration key to cache compound bloom filter blocks on write.
> */
> public static final String CACHE_BLOOM_BLOCKS_ON_WRITE_KEY =
> "hfile.block.bloom.cacheonwrite";
> {code}
> Seems issue with entry in the xml file.
> We can correct the xml with the config name as hfile.block.bloom.cacheonwrite ?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5957) Mismatch with config param name in
xml and code
Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated HBASE-5957:
------------------------------
Hadoop Flags: Reviewed
Status: Patch Available (was: Open)
> Mismatch with config param name in xml and code
> -----------------------------------------------
>
> Key: HBASE-5957
> URL: https://issues.apache.org/jira/browse/HBASE-5957
> Project: HBase
> Issue Type: Bug
> Reporter: Anoop Sam John
> Attachments: HBASE-5957.patch
>
>
> In hbase-default.xml there listed one param "io.storefile.bloom.cacheonwrite"
> {code}
> <property>
> <name>io.storefile.bloom.cacheonwrite</name>
> <value>false</value>
> <description>
> Enables cache-on-write for inline blocks of a compound Bloom filter.
> </description>
> </property>
> {code}
> No place in the code this config is getting used.
> Instead in CacheConfig there is a config param name
> {code}
> /**
> * Configuration key to cache compound bloom filter blocks on write.
> */
> public static final String CACHE_BLOOM_BLOCKS_ON_WRITE_KEY =
> "hfile.block.bloom.cacheonwrite";
> {code}
> Seems issue with entry in the xml file.
> We can correct the xml with the config name as hfile.block.bloom.cacheonwrite ?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-5957) Mismatch with config param name in
xml and code
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ramkrishna.s.vasudevan reassigned HBASE-5957:
---------------------------------------------
Assignee: Anoop Sam John
> Mismatch with config param name in xml and code
> -----------------------------------------------
>
> Key: HBASE-5957
> URL: https://issues.apache.org/jira/browse/HBASE-5957
> Project: HBase
> Issue Type: Bug
> Reporter: Anoop Sam John
> Assignee: Anoop Sam John
> Attachments: HBASE-5957.patch
>
>
> In hbase-default.xml there listed one param "io.storefile.bloom.cacheonwrite"
> {code}
> <property>
> <name>io.storefile.bloom.cacheonwrite</name>
> <value>false</value>
> <description>
> Enables cache-on-write for inline blocks of a compound Bloom filter.
> </description>
> </property>
> {code}
> No place in the code this config is getting used.
> Instead in CacheConfig there is a config param name
> {code}
> /**
> * Configuration key to cache compound bloom filter blocks on write.
> */
> public static final String CACHE_BLOOM_BLOCKS_ON_WRITE_KEY =
> "hfile.block.bloom.cacheonwrite";
> {code}
> Seems issue with entry in the xml file.
> We can correct the xml with the config name as hfile.block.bloom.cacheonwrite ?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5957) Mismatch with config param name in
xml and code
Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270538#comment-13270538 ]
Zhihong Yu commented on HBASE-5957:
-----------------------------------
+1 on correcting entry in xml.
> Mismatch with config param name in xml and code
> -----------------------------------------------
>
> Key: HBASE-5957
> URL: https://issues.apache.org/jira/browse/HBASE-5957
> Project: HBase
> Issue Type: Bug
> Reporter: Anoop Sam John
>
> In hbase-default.xml there listed one param "io.storefile.bloom.cacheonwrite"
> {code}
> <property>
> <name>io.storefile.bloom.cacheonwrite</name>
> <value>false</value>
> <description>
> Enables cache-on-write for inline blocks of a compound Bloom filter.
> </description>
> </property>
> {code}
> No place in the code this config is getting used.
> Instead in CacheConfig there is a config param name
> {code}
> /**
> * Configuration key to cache compound bloom filter blocks on write.
> */
> public static final String CACHE_BLOOM_BLOCKS_ON_WRITE_KEY =
> "hfile.block.bloom.cacheonwrite";
> {code}
> Seems issue with entry in the xml file.
> We can correct the xml with the config name as hfile.block.bloom.cacheonwrite ?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5957) Mismatch with config param name in
xml and code
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270717#comment-13270717 ]
Hadoop QA commented on HBASE-5957:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12526009/HBASE-5957.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 hadoop23. The patch compiles against the hadoop 0.23.x profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.wal.TestHLog
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1798//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1798//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1798//console
This message is automatically generated.
> Mismatch with config param name in xml and code
> -----------------------------------------------
>
> Key: HBASE-5957
> URL: https://issues.apache.org/jira/browse/HBASE-5957
> Project: HBase
> Issue Type: Bug
> Reporter: Anoop Sam John
> Attachments: HBASE-5957.patch
>
>
> In hbase-default.xml there listed one param "io.storefile.bloom.cacheonwrite"
> {code}
> <property>
> <name>io.storefile.bloom.cacheonwrite</name>
> <value>false</value>
> <description>
> Enables cache-on-write for inline blocks of a compound Bloom filter.
> </description>
> </property>
> {code}
> No place in the code this config is getting used.
> Instead in CacheConfig there is a config param name
> {code}
> /**
> * Configuration key to cache compound bloom filter blocks on write.
> */
> public static final String CACHE_BLOOM_BLOCKS_ON_WRITE_KEY =
> "hfile.block.bloom.cacheonwrite";
> {code}
> Seems issue with entry in the xml file.
> We can correct the xml with the config name as hfile.block.bloom.cacheonwrite ?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5957) Mismatch with config param name in
xml and code
Posted by "Anoop Sam John (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anoop Sam John updated HBASE-5957:
----------------------------------
Attachment: HBASE-5957.patch
Patch for trunk.
> Mismatch with config param name in xml and code
> -----------------------------------------------
>
> Key: HBASE-5957
> URL: https://issues.apache.org/jira/browse/HBASE-5957
> Project: HBase
> Issue Type: Bug
> Reporter: Anoop Sam John
> Attachments: HBASE-5957.patch
>
>
> In hbase-default.xml there listed one param "io.storefile.bloom.cacheonwrite"
> {code}
> <property>
> <name>io.storefile.bloom.cacheonwrite</name>
> <value>false</value>
> <description>
> Enables cache-on-write for inline blocks of a compound Bloom filter.
> </description>
> </property>
> {code}
> No place in the code this config is getting used.
> Instead in CacheConfig there is a config param name
> {code}
> /**
> * Configuration key to cache compound bloom filter blocks on write.
> */
> public static final String CACHE_BLOOM_BLOCKS_ON_WRITE_KEY =
> "hfile.block.bloom.cacheonwrite";
> {code}
> Seems issue with entry in the xml file.
> We can correct the xml with the config name as hfile.block.bloom.cacheonwrite ?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5957) Mismatch with config param name in
xml and code
Posted by "Anoop Sam John (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271038#comment-13271038 ]
Anoop Sam John commented on HBASE-5957:
---------------------------------------
{quote}-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
{quote}
Change is wrt correcting the xml entry in the hbase-default.xml
{quote}
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.wal.TestHLog
{quote}
Patch has nothing to do with HLog. Failure is not related to this patch I think. Run tests in TestHLog locally and all passed
> Mismatch with config param name in xml and code
> -----------------------------------------------
>
> Key: HBASE-5957
> URL: https://issues.apache.org/jira/browse/HBASE-5957
> Project: HBase
> Issue Type: Bug
> Reporter: Anoop Sam John
> Attachments: HBASE-5957.patch
>
>
> In hbase-default.xml there listed one param "io.storefile.bloom.cacheonwrite"
> {code}
> <property>
> <name>io.storefile.bloom.cacheonwrite</name>
> <value>false</value>
> <description>
> Enables cache-on-write for inline blocks of a compound Bloom filter.
> </description>
> </property>
> {code}
> No place in the code this config is getting used.
> Instead in CacheConfig there is a config param name
> {code}
> /**
> * Configuration key to cache compound bloom filter blocks on write.
> */
> public static final String CACHE_BLOOM_BLOCKS_ON_WRITE_KEY =
> "hfile.block.bloom.cacheonwrite";
> {code}
> Seems issue with entry in the xml file.
> We can correct the xml with the config name as hfile.block.bloom.cacheonwrite ?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5957) Mismatch with config param name in
xml and code
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ramkrishna.s.vasudevan updated HBASE-5957:
------------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Mismatch with config param name in xml and code
> -----------------------------------------------
>
> Key: HBASE-5957
> URL: https://issues.apache.org/jira/browse/HBASE-5957
> Project: HBase
> Issue Type: Bug
> Reporter: Anoop Sam John
> Attachments: HBASE-5957.patch
>
>
> In hbase-default.xml there listed one param "io.storefile.bloom.cacheonwrite"
> {code}
> <property>
> <name>io.storefile.bloom.cacheonwrite</name>
> <value>false</value>
> <description>
> Enables cache-on-write for inline blocks of a compound Bloom filter.
> </description>
> </property>
> {code}
> No place in the code this config is getting used.
> Instead in CacheConfig there is a config param name
> {code}
> /**
> * Configuration key to cache compound bloom filter blocks on write.
> */
> public static final String CACHE_BLOOM_BLOCKS_ON_WRITE_KEY =
> "hfile.block.bloom.cacheonwrite";
> {code}
> Seems issue with entry in the xml file.
> We can correct the xml with the config name as hfile.block.bloom.cacheonwrite ?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5957) Mismatch with config param name in
xml and code
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13274438#comment-13274438 ]
ramkrishna.s.vasudevan commented on HBASE-5957:
-----------------------------------------------
+1 on patch. Will commit it today.
> Mismatch with config param name in xml and code
> -----------------------------------------------
>
> Key: HBASE-5957
> URL: https://issues.apache.org/jira/browse/HBASE-5957
> Project: HBase
> Issue Type: Bug
> Reporter: Anoop Sam John
> Attachments: HBASE-5957.patch
>
>
> In hbase-default.xml there listed one param "io.storefile.bloom.cacheonwrite"
> {code}
> <property>
> <name>io.storefile.bloom.cacheonwrite</name>
> <value>false</value>
> <description>
> Enables cache-on-write for inline blocks of a compound Bloom filter.
> </description>
> </property>
> {code}
> No place in the code this config is getting used.
> Instead in CacheConfig there is a config param name
> {code}
> /**
> * Configuration key to cache compound bloom filter blocks on write.
> */
> public static final String CACHE_BLOOM_BLOCKS_ON_WRITE_KEY =
> "hfile.block.bloom.cacheonwrite";
> {code}
> Seems issue with entry in the xml file.
> We can correct the xml with the config name as hfile.block.bloom.cacheonwrite ?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5957) Mismatch with config param name in
xml and code
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270676#comment-13270676 ]
stack commented on HBASE-5957:
------------------------------
+1
> Mismatch with config param name in xml and code
> -----------------------------------------------
>
> Key: HBASE-5957
> URL: https://issues.apache.org/jira/browse/HBASE-5957
> Project: HBase
> Issue Type: Bug
> Reporter: Anoop Sam John
> Attachments: HBASE-5957.patch
>
>
> In hbase-default.xml there listed one param "io.storefile.bloom.cacheonwrite"
> {code}
> <property>
> <name>io.storefile.bloom.cacheonwrite</name>
> <value>false</value>
> <description>
> Enables cache-on-write for inline blocks of a compound Bloom filter.
> </description>
> </property>
> {code}
> No place in the code this config is getting used.
> Instead in CacheConfig there is a config param name
> {code}
> /**
> * Configuration key to cache compound bloom filter blocks on write.
> */
> public static final String CACHE_BLOOM_BLOCKS_ON_WRITE_KEY =
> "hfile.block.bloom.cacheonwrite";
> {code}
> Seems issue with entry in the xml file.
> We can correct the xml with the config name as hfile.block.bloom.cacheonwrite ?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira