You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2021/01/22 13:27:30 UTC

[GitHub] [sling-org-apache-sling-graphql-core] bdelacretaz commented on a change in pull request #17: SLING-10085 - Cache the GraphQL schemas in the DefaultQueryExecutor

bdelacretaz commented on a change in pull request #17:
URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/17#discussion_r562629296



##########
File path: src/main/java/org/apache/sling/graphql/core/engine/DefaultQueryExecutor.java
##########
@@ -96,13 +114,40 @@
     @Reference
     private SlingScalarsProvider scalarsProvider;
 
+    @ObjectClassDefinition(
+            name = "Apache Sling Default GraphQL Query Executor"
+    )
+    @interface Config {
+        @AttributeDefinition(
+                name = "Schema Cache Size",
+                description = "The number of schemas to cache. Since a schema normally doesn't change often, they can be cached and " +

Review comment:
       I would say "the compiled schemas can be cached"




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org