You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/04 18:03:17 UTC

[GitHub] [airflow] nuclearpinguin opened a new pull request #7624: [AIRFLOW-6973] Make GCSCreateBucketOperator idempotent (fix)

nuclearpinguin opened a new pull request #7624: [AIRFLOW-6973] Make GCSCreateBucketOperator idempotent (fix)
URL: https://github.com/apache/airflow/pull/7624
 
 
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on a change in pull request #7624: [AIRFLOW-6973] Make GCSCreateBucketOperator idempotent (fix)

Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7624: [AIRFLOW-6973] Make GCSCreateBucketOperator idempotent (fix)
URL: https://github.com/apache/airflow/pull/7624#discussion_r387906481
 
 

 ##########
 File path: airflow/providers/google/cloud/hooks/gcs.py
 ##########
 @@ -450,7 +450,6 @@ def get_md5hash(self, bucket_name, object_name):
         self.log.info('The md5Hash of %s is %s', object_name, blob_md5hash)
         return blob_md5hash
 
-    @CloudBaseHook.catch_http_exception
 
 Review comment:
   Why this? I believe catch_http_exception was catching the exception and throwing AirflowException instead

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] nuclearpinguin commented on a change in pull request #7624: [AIRFLOW-6973] Make GCSCreateBucketOperator idempotent (fix)

Posted by GitBox <gi...@apache.org>.
nuclearpinguin commented on a change in pull request #7624: [AIRFLOW-6973] Make GCSCreateBucketOperator idempotent (fix)
URL: https://github.com/apache/airflow/pull/7624#discussion_r388935245
 
 

 ##########
 File path: airflow/providers/google/cloud/hooks/gcs.py
 ##########
 @@ -450,7 +450,6 @@ def get_md5hash(self, bucket_name, object_name):
         self.log.info('The md5Hash of %s is %s', object_name, blob_md5hash)
         return blob_md5hash
 
-    @CloudBaseHook.catch_http_exception
 
 Review comment:
   That's true, but original exception was hard to catch like:
   ```
   try:
      create_smth()
   except AlreadyExists:
      get_smth()
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk merged pull request #7624: [AIRFLOW-6973] Make GCSCreateBucketOperator idempotent (fix)

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #7624: [AIRFLOW-6973] Make GCSCreateBucketOperator idempotent (fix)
URL: https://github.com/apache/airflow/pull/7624
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #7624: [AIRFLOW-6973] Make GCSCreateBucketOperator idempotent (fix)

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7624: [AIRFLOW-6973] Make GCSCreateBucketOperator idempotent (fix)
URL: https://github.com/apache/airflow/pull/7624#issuecomment-596102538
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7624?src=pr&el=h1) Report
   > Merging [#7624](https://codecov.io/gh/apache/airflow/pull/7624?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/f3abd340826289dec23e96b79a6ed9b6a1955027?src=pr&el=desc) will **decrease** coverage by `0.28%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7624/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7624?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7624      +/-   ##
   ==========================================
   - Coverage   86.83%   86.55%   -0.29%     
   ==========================================
     Files         897      897              
     Lines       42805    42838      +33     
   ==========================================
   - Hits        37170    37078      -92     
   - Misses       5635     5760     +125
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7624?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/providers/google/cloud/hooks/gcs.py](https://codecov.io/gh/apache/airflow/pull/7624/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2hvb2tzL2djcy5weQ==) | `85.46% <ø> (-0.06%)` | :arrow_down: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7624/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7624/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7624/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0%> (-45.08%)` | :arrow_down: |
   | [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7624/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `69.69% <0%> (-25.26%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7624/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/7624/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `84.11% <0%> (-0.82%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7624?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7624?src=pr&el=footer). Last update [f3abd34...710cd2c](https://codecov.io/gh/apache/airflow/pull/7624?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services