You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/03/23 07:48:21 UTC
[GitHub] [skywalking-rocketbot-ui] Fine0830 opened a new pull request #452: feat: implement Events in dashboard
Fine0830 opened a new pull request #452:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/452
Implement Events in dashboard with lists in a popup. Add markAreas in charts with events data.
Screenshots
Signed-off-by: Qiuxia Fan <qi...@apache.org>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng merged pull request #452: feat: implement Events in dashboard
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #452:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/452
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on pull request #452: feat: implement Events in dashboard
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on pull request #452:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/452#issuecomment-810790931
Done. Please recheck.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #452: feat: implement Events in dashboard
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #452:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/452#issuecomment-810908557
Please fix the conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] kezhenxu94 edited a comment on pull request #452: feat: implement Events in dashboard
Posted by GitBox <gi...@apache.org>.
kezhenxu94 edited a comment on pull request #452:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/452#issuecomment-812317523
Some observations:
- [ ] Hitting the "Reload" button doesn't reload the events.
- [x] Refresh the browser doesn't re-select all the events. (by design, only select the top 3 events by default)
<img width="965" alt="Screen Shot 2021-04-02 at 12 43 08" src="https://user-images.githubusercontent.com/15965696/113381352-50dbab00-93b1-11eb-95e3-55d389369272.png">
- [ ] When there is > 8 events in the time range, the layout becomes messy.
<img width="1786" alt="Screen Shot 2021-04-02 at 12 50 01" src="https://user-images.githubusercontent.com/15965696/113381590-f2fb9300-93b1-11eb-8de2-7c41a762c78c.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #452: feat: implement Events in dashboard
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #452:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/452#issuecomment-804719314
1. Make the event option at the top level, right top.
2. User only needs to choose Event levels(Service/Instance/Endpoint), rather than specific events.
3. Event should be available on the dashboard of the topology page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on pull request #452: feat: implement Events in dashboard
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on pull request #452:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/452#issuecomment-811174190
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on pull request #452: feat: implement Events in dashboard
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on pull request #452:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/452#issuecomment-813788255
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #452: feat: implement Events in dashboard
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #452:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/452#issuecomment-810924570
@kezhenxu94 This is closing to test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] kezhenxu94 edited a comment on pull request #452: feat: implement Events in dashboard
Posted by GitBox <gi...@apache.org>.
kezhenxu94 edited a comment on pull request #452:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/452#issuecomment-812317523
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #452: feat: implement Events in dashboard
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #452:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/452#issuecomment-810923877
Let's set event series multi selectable, and select service and instance levels in default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] kezhenxu94 commented on pull request #452: feat: implement Events in dashboard
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #452:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/452#issuecomment-812317523
Some observations:
- [ ] Hitting the "Reload" button doesn't reload the events.
- [ ] Refresh the browser doesn't re-select all the events.
<img width="965" alt="Screen Shot 2021-04-02 at 12 43 08" src="https://user-images.githubusercontent.com/15965696/113381352-50dbab00-93b1-11eb-95e3-55d389369272.png">
- [ ] When there is > 8 events in the time range, the layout becomes messy.
<img width="1786" alt="Screen Shot 2021-04-02 at 12 50 01" src="https://user-images.githubusercontent.com/15965696/113381590-f2fb9300-93b1-11eb-8de2-7c41a762c78c.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org