[GitHub] [incubator-yunikorn-core] wilfred-s commented on a change in pull request #349: [YUNIKORN-981] cleanup queue comments and logging

[GitBox <gi...@apache.org>]

wilfred-s commented on a change in pull request #349:
URL: https://github.com/apache/incubator-yunikorn-core/pull/349#discussion_r772013276



##########
File path: pkg/scheduler/objects/queue.go
##########
@@ -129,8 +130,7 @@ func NewDynamicQueue(name string, leaf bool, parent *Queue) (*Queue, error) {
 	}
 	// name might not be checked do it here
 	if !configs.QueueNameRegExp.MatchString(name) {
-		return nil, fmt.Errorf("invalid queue name %s, a name must only have alphanumeric characters,"+
-			" - or _, and be no longer than 64 characters", name)
+		return nil, fmt.Errorf("invalid queue name '%s', a name must only have alphanumeric characters, - or _, and be no longer than 64 characters", name)

Review comment:
       It is not a label value or name it is a queue name. K8s labels are different in a number of ways.  The major difference is that label values and names can contain dots, queue names cannot contain dots. It looks similar but it is not and we do not want to be either.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org