You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2023/01/02 14:33:40 UTC
[GitHub] [arrow-rs] alamb opened a new pull request, #3428: Minor: run clippy on `arrow-integration-testing`
alamb opened a new pull request, #3428:
URL: https://github.com/apache/arrow-rs/pull/3428
# Which issue does this PR close?
N/a
# Rationale for this change
I see this warning a bunch locally:
```
error: use of deprecated function `arrow_flight::utils::flight_data_from_arrow_batch`: Use IpcDataGenerator directly with DictionaryTracker to avoid re-sending dictionaries
--> arrow-integration-testing/src/flight_client_scenarios/integration_test.rs:134:30
|
134 | arrow_flight::utils::flight_data_from_arrow_batch(batch, options);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `-D deprecated` implied by `-D warnings`
error: use of deprecated function `arrow_flight::utils::flight_data_from_arrow_batch`: Use IpcDataGenerator directly with DictionaryTracker to avoid re-sending dictionaries
--> arrow-integration-testing/src/flight_server_scenarios/integration_test.rs:125:42
|
125 | arrow_flight::utils::flight_data_from_arrow_batch(batch, &options);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
```
# What changes are included in this PR?
1. Run clippy on integration testing crates
2. Fix clippy errors found by 1.
# Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a diff in pull request #3428: Minor: run clippy on `arrow-integration-testing`
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #3428:
URL: https://github.com/apache/arrow-rs/pull/3428#discussion_r1060925457
##########
.github/workflows/arrow.yml:
##########
@@ -208,5 +208,9 @@ jobs:
run: cargo clippy -p arrow-arith --all-targets --features dyn_arith_dict -- -D warnings
- name: Clippy arrow-row with all features
run: cargo clippy -p arrow-row --all-targets --all-features -- -D warnings
+ - name: Clippy arrow-integration-test with all features
+ run: cargo clippy -p arrow-integration-test --all-targets --all-features -- -D warnings
+ - name: Clippy arrow-integration-testing with all features
+ run: cargo clippy -p arrow-integration-testing --all-targets --all-features -- -D warnings
Review Comment:
Will do as a follow on PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3428: Minor: run clippy on `arrow-integration-testing`
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #3428:
URL: https://github.com/apache/arrow-rs/pull/3428#discussion_r1060109878
##########
.github/workflows/arrow.yml:
##########
@@ -208,5 +208,9 @@ jobs:
run: cargo clippy -p arrow-arith --all-targets --features dyn_arith_dict -- -D warnings
- name: Clippy arrow-row with all features
run: cargo clippy -p arrow-row --all-targets --all-features -- -D warnings
+ - name: Clippy arrow-integration-test with all features
+ run: cargo clippy -p arrow-integration-test --all-targets --all-features -- -D warnings
+ - name: Clippy arrow-integration-testing with all features
+ run: cargo clippy -p arrow-integration-testing --all-targets --all-features -- -D warnings
Review Comment:
Given this depends on the `arrow` crate, I wonder if it should be after it in the build order
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb merged pull request #3428: Minor: run clippy on `arrow-integration-testing`
Posted by GitBox <gi...@apache.org>.
alamb merged PR #3428:
URL: https://github.com/apache/arrow-rs/pull/3428
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a diff in pull request #3428: Minor: run clippy on `arrow-integration-testing`
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #3428:
URL: https://github.com/apache/arrow-rs/pull/3428#discussion_r1060926987
##########
.github/workflows/arrow.yml:
##########
@@ -208,5 +208,9 @@ jobs:
run: cargo clippy -p arrow-arith --all-targets --features dyn_arith_dict -- -D warnings
- name: Clippy arrow-row with all features
run: cargo clippy -p arrow-row --all-targets --all-features -- -D warnings
+ - name: Clippy arrow-integration-test with all features
+ run: cargo clippy -p arrow-integration-test --all-targets --all-features -- -D warnings
+ - name: Clippy arrow-integration-testing with all features
+ run: cargo clippy -p arrow-integration-testing --all-targets --all-features -- -D warnings
Review Comment:
https://github.com/apache/arrow-rs/pull/3445
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a diff in pull request #3428: Minor: run clippy on `arrow-integration-testing`
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #3428:
URL: https://github.com/apache/arrow-rs/pull/3428#discussion_r1060067472
##########
arrow-integration-testing/src/flight_server_scenarios/integration_test.rs:
##########
@@ -121,15 +121,24 @@ impl FlightService for FlightServiceImpl {
.iter()
.enumerate()
.flat_map(|(counter, batch)| {
- let (dictionary_flight_data, mut batch_flight_data) =
- arrow_flight::utils::flight_data_from_arrow_batch(batch, &options);
Review Comment:
using deprecated API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #3428: Minor: run clippy on `arrow-integration-testing`
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3428:
URL: https://github.com/apache/arrow-rs/pull/3428#issuecomment-1370190230
Benchmark runs are scheduled for baseline = 26ea71cefab55990ffb8197707f2a8518e41412d and contender = dc91a244e34a7ffe88f5d0676cef59843926c41d. dc91a244e34a7ffe88f5d0676cef59843926c41d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/c7b45b09f63c42ebae44e40e00e7d373...d3ed64cd809c4c94a3516e161676a6eb/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/cbd4308a785e4c5286b22979eb67c97c...6d8e9bc5f9d8472680ce68683265c80f/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/b013c14f45b74776b07422c8536fd793...d85413d5941d43dd97da76d9650df61f/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/5cfe6afd09ab4dc3b0754a641cf362a3...bb3c671e3c8b4200ab62bcfc1151ad9b/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org