You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/04/10 18:17:20 UTC
[GitHub] [activemq-artemis] gamedev8 opened a new pull request #3076:
Updating text casing on connectionTtl
gamedev8 opened a new pull request #3076: Updating text casing on connectionTtl
URL: https://github.com/apache/activemq-artemis/pull/3076
Updating the text from `connectionTtl` to `connectionTTL`
I actually copied and pasted `connectionTtl` in my configuration and spent time trying to figure out what was wrong. I finally realized it was the casing, so I'm proposing this change just in case someone faces the same issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] gamedev8 commented on a change in pull request
#3076: Updating text casing on connectionTtl
Posted by GitBox <gi...@apache.org>.
gamedev8 commented on a change in pull request #3076: Updating text casing on connectionTtl
URL: https://github.com/apache/activemq-artemis/pull/3076#discussion_r407711413
##########
File path: docs/user-manual/en/connection-ttl.md
##########
@@ -186,4 +186,4 @@ thread adds a little more latency. These packets are:
To disable asynchronous connection execution, set the parameter
`async-connection-execution-enabled` in `broker.xml` to
-`false` (default value is `true`).
Review comment:
That is weird. I'll remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull
request #3076: Updating text casing on connectionTtl
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on a change in pull request #3076: Updating text casing on connectionTtl
URL: https://github.com/apache/activemq-artemis/pull/3076#discussion_r407710915
##########
File path: docs/user-manual/en/connection-ttl.md
##########
@@ -186,4 +186,4 @@ thread adds a little more latency. These packets are:
To disable asynchronous connection execution, set the parameter
`async-connection-execution-enabled` in `broker.xml` to
-`false` (default value is `true`).
Review comment:
NM: I see .. an enter was removed.. thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull
request #3076: Updating text casing on connectionTtl
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on a change in pull request #3076: Updating text casing on connectionTtl
URL: https://github.com/apache/activemq-artemis/pull/3076#discussion_r407710134
##########
File path: docs/user-manual/en/connection-ttl.md
##########
@@ -186,4 +186,4 @@ thread adds a little more latency. These packets are:
To disable asynchronous connection execution, set the parameter
`async-connection-execution-enabled` in `broker.xml` to
-`false` (default value is `true`).
Review comment:
what was changed on this line? I can't see it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] asfgit closed pull request #3076: Updating text
casing on connectionTtl
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3076: Updating text casing on connectionTtl
URL: https://github.com/apache/activemq-artemis/pull/3076
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services