You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/10/08 06:02:43 UTC
[GitHub] [pinot] codecov-commenter commented on pull request #9561: [Refactor] Return InstanceResponseBlock in QueryExecutor
codecov-commenter commented on PR #9561:
URL: https://github.com/apache/pinot/pull/9561#issuecomment-1272237842
# [Codecov](https://codecov.io/gh/apache/pinot/pull/9561?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9561](https://codecov.io/gh/apache/pinot/pull/9561?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa2bb43) into [master](https://codecov.io/gh/apache/pinot/commit/8cdae925020dc8ae32777d3e6205340d22bac7fd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8cdae92) will **increase** coverage by `38.93%`.
> The diff coverage is `65.73%`.
```diff
@@ Coverage Diff @@
## master #9561 +/- ##
=============================================
+ Coverage 28.28% 67.22% +38.93%
- Complexity 53 5017 +4964
=============================================
Files 1917 1428 -489
Lines 102594 74628 -27966
Branches 15586 11921 -3665
=============================================
+ Hits 29022 50169 +21147
+ Misses 70735 20821 -49914
- Partials 2837 3638 +801
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `?` | |
| integration2 | `?` | |
| unittests1 | `67.22% <65.73%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/9561?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../operator/blocks/results/MetadataResultsBlock.java](https://codecov.io/gh/apache/pinot/pull/9561/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9ibG9ja3MvcmVzdWx0cy9NZXRhZGF0YVJlc3VsdHNCbG9jay5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...r/streaming/StreamingInstanceResponseOperator.java](https://codecov.io/gh/apache/pinot/pull/9561/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9zdHJlYW1pbmcvU3RyZWFtaW5nSW5zdGFuY2VSZXNwb25zZU9wZXJhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...t/core/plan/StreamingInstanceResponsePlanNode.java](https://codecov.io/gh/apache/pinot/pull/9561/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9wbGFuL1N0cmVhbWluZ0luc3RhbmNlUmVzcG9uc2VQbGFuTm9kZS5qYXZh) | `0.00% <ø> (-100.00%)` | :arrow_down: |
| [...t/core/query/selection/SelectionOperatorUtils.java](https://codecov.io/gh/apache/pinot/pull/9561/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9zZWxlY3Rpb24vU2VsZWN0aW9uT3BlcmF0b3JVdGlscy5qYXZh) | `92.22% <ø> (+25.00%)` | :arrow_up: |
| [...che/pinot/core/transport/grpc/GrpcQueryServer.java](https://codecov.io/gh/apache/pinot/pull/9561/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS90cmFuc3BvcnQvZ3JwYy9HcnBjUXVlcnlTZXJ2ZXIuamF2YQ==) | `0.00% <0.00%> (-52.57%)` | :arrow_down: |
| [.../operator/blocks/results/DistinctResultsBlock.java](https://codecov.io/gh/apache/pinot/pull/9561/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9ibG9ja3MvcmVzdWx0cy9EaXN0aW5jdFJlc3VsdHNCbG9jay5qYXZh) | `71.42% <14.28%> (-28.58%)` | :arrow_down: |
| [...pache/pinot/core/query/executor/QueryExecutor.java](https://codecov.io/gh/apache/pinot/pull/9561/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9leGVjdXRvci9RdWVyeUV4ZWN1dG9yLmphdmE=) | `12.50% <14.28%> (-87.50%)` | :arrow_down: |
| [...core/common/datatable/DataTableBuilderFactory.java](https://codecov.io/gh/apache/pinot/pull/9561/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9jb21tb24vZGF0YXRhYmxlL0RhdGFUYWJsZUJ1aWxkZXJGYWN0b3J5LmphdmE=) | `52.94% <20.00%> (-13.73%)` | :arrow_down: |
| [...operator/blocks/results/ExceptionResultsBlock.java](https://codecov.io/gh/apache/pinot/pull/9561/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9ibG9ja3MvcmVzdWx0cy9FeGNlcHRpb25SZXN1bHRzQmxvY2suamF2YQ==) | `75.00% <33.33%> (-25.00%)` | :arrow_down: |
| [...operator/blocks/results/SelectionResultsBlock.java](https://codecov.io/gh/apache/pinot/pull/9561/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9ibG9ja3MvcmVzdWx0cy9TZWxlY3Rpb25SZXN1bHRzQmxvY2suamF2YQ==) | `77.77% <33.33%> (-22.23%)` | :arrow_down: |
| ... and [1699 more](https://codecov.io/gh/apache/pinot/pull/9561/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org