You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/03/26 18:21:20 UTC
[GitHub] [kylin] codecov-io commented on issue #1157: KYLIN-4423 use spring
session to support clustered sessions
codecov-io commented on issue #1157: KYLIN-4423 use spring session to support clustered sessions
URL: https://github.com/apache/kylin/pull/1157#issuecomment-604596756
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1157?src=pr&el=h1) Report
> Merging [#1157](https://codecov.io/gh/apache/kylin/pull/1157?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/b61d4989a842c06f993e9a3df75262c764972589&el=desc) will **decrease** coverage by `0.04%`.
> The diff coverage is `28.57%`.
[](https://codecov.io/gh/apache/kylin/pull/1157?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1157 +/- ##
============================================
- Coverage 25.06% 25.02% -0.05%
- Complexity 6248 6258 +10
============================================
Files 1446 1451 +5
Lines 88305 88540 +235
Branches 12357 12379 +22
============================================
+ Hits 22131 22154 +23
- Misses 64004 64211 +207
- Partials 2170 2175 +5
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1157?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apache/kylin/rest/session/KylinSessionConfig.java](https://codecov.io/gh/apache/kylin/pull/1157/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2Vzc2lvbi9LeWxpblNlc3Npb25Db25maWcuamF2YQ==) | `26.66% <26.66%> (ø)` | `2.00 <2.00> (?)` | |
| [.../apache/kylin/rest/session/KylinSessionFilter.java](https://codecov.io/gh/apache/kylin/pull/1157/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2Vzc2lvbi9LeWxpblNlc3Npb25GaWx0ZXIuamF2YQ==) | `33.33% <33.33%> (ø)` | `4.00 <4.00> (?)` | |
| [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/1157/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0.00%> (-5.41%)` | `6.00% <0.00%> (-1.00%)` | |
| [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1157/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `70.21% <0.00%> (-0.92%)` | `7.00% <0.00%> (ø%)` | |
| [...he/kylin/engine/mr/common/MapReduceExecutable.java](https://codecov.io/gh/apache/kylin/pull/1157/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvY29tbW9uL01hcFJlZHVjZUV4ZWN1dGFibGUuamF2YQ==) | `12.91% <0.00%> (-0.42%)` | `6.00% <0.00%> (ø%)` | |
| [...c/main/java/org/apache/kylin/cube/CubeManager.java](https://codecov.io/gh/apache/kylin/pull/1157/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVNYW5hZ2VyLmphdmE=) | `36.50% <0.00%> (-0.12%)` | `44.00% <0.00%> (ø%)` | |
| [...n/java/org/apache/kylin/tool/DiagnosisInfoCLI.java](https://codecov.io/gh/apache/kylin/pull/1157/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9EaWFnbm9zaXNJbmZvQ0xJLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...ava/org/apache/kylin/tool/JobDiagnosisInfoCLI.java](https://codecov.io/gh/apache/kylin/pull/1157/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9Kb2JEaWFnbm9zaXNJbmZvQ0xJLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [.../java/org/apache/kylin/common/util/HadoopUtil.java](https://codecov.io/gh/apache/kylin/pull/1157/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL0hhZG9vcFV0aWwuamF2YQ==) | `14.56% <0.00%> (ø)` | `10.00% <0.00%> (ø%)` | |
| [...rg/apache/kylin/rest/service/DiagnosisService.java](https://codecov.io/gh/apache/kylin/pull/1157/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9EaWFnbm9zaXNTZXJ2aWNlLmphdmE=) | `26.78% <0.00%> (ø)` | `6.00% <0.00%> (ø%)` | |
| ... and [27 more](https://codecov.io/gh/apache/kylin/pull/1157/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1157?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1157?src=pr&el=footer). Last update [b61d498...cba5515](https://codecov.io/gh/apache/kylin/pull/1157?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services