You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "zuston (via GitHub)" <gi...@apache.org> on 2024/03/08 03:20:57 UTC
[PR] [#1569] fix(rust): flaky test for `test_ticket_manager` [incubator-uniffle]
zuston opened a new pull request, #1570:
URL: https://github.com/apache/incubator-uniffle/pull/1570
### What changes were proposed in this pull request?
Use `i64` to fix overflow rather than `u64`
### Why are the changes needed?
Fix: #1569. to fix `test_ticket_manager`
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing uts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1569] fix(rust): flaky test for `test_ticket_manager` [incubator-uniffle]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1570:
URL: https://github.com/apache/incubator-uniffle/pull/1570#issuecomment-1984996492
## Test Results
2 326 files ±0 2 326 suites ±0 4h 29m 43s :stopwatch: +17s
851 tests ±0 849 :white_check_mark: ±0 2 :zzz: ±0 0 :x: ±0
10 018 runs ±0 9 995 :white_check_mark: ±0 23 :zzz: ±0 0 :x: ±0
Results for commit df08df42. ± Comparison against base commit d994b272.
[test-results]:data:application/gzip;base64,H4sIAB2M6mUC/03MTQ7CIBCG4as0rF0wlFLGyxjCT0Jsi6GwMt5dMAVZfs9M3jdxfrMnuU9sZuI2kTP7NG6To0o+HEVAgJwLlXuqH3KBth5n1roSxz89/at2OjjltwK0g40xxEtiPmoTKAV5zRZFxKXTFZ0bDNHfHps67LtPZRDjqDSOM1ACQQtlEIBb6bRZhbJ8RSU4dXwlny+29H+PEQEAAA==
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1569] fix(rust): flaky test for `test_ticket_manager` [incubator-uniffle]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1570:
URL: https://github.com/apache/incubator-uniffle/pull/1570#issuecomment-1984979648
## [Codecov](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1570?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 53.88%. Comparing base [(`d994b27`)](https://app.codecov.io/gh/apache/incubator-uniffle/commit/d994b272b5a8ee30155aac6d529857f044846c57?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`df08df4`)](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1570?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #1570 +/- ##
============================================
+ Coverage 53.72% 53.88% +0.15%
+ Complexity 2838 2288 -550
============================================
Files 437 359 -78
Lines 24663 16022 -8641
Branches 2094 1461 -633
============================================
- Hits 13250 8633 -4617
+ Misses 10581 6891 -3690
+ Partials 832 498 -334
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1570?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1569] fix(rust): flaky test for `test_ticket_manager` [incubator-uniffle]
Posted by "smallzhongfeng (via GitHub)" <gi...@apache.org>.
smallzhongfeng merged PR #1570:
URL: https://github.com/apache/incubator-uniffle/pull/1570
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1569] fix(rust): flaky test for `test_ticket_manager` [incubator-uniffle]
Posted by "smallzhongfeng (via GitHub)" <gi...@apache.org>.
smallzhongfeng commented on PR #1570:
URL: https://github.com/apache/incubator-uniffle/pull/1570#issuecomment-1985358173
Thanks @zuston Merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org