You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Chris Douglas (JIRA)" <ji...@apache.org> on 2009/01/21 00:43:59 UTC
[jira] Created: (HADOOP-5086) Trash URI semantics can be relaxed
Trash URI semantics can be relaxed
----------------------------------
Key: HADOOP-5086
URL: https://issues.apache.org/jira/browse/HADOOP-5086
Project: Hadoop Core
Issue Type: Improvement
Components: fs
Affects Versions: 0.18.0
Reporter: Chris Douglas
Priority: Minor
When using fully qualified URIs with FsShell, the authority element of the URI must match the default filesystem exactly, or else one may get an error message when the trash is enabled:
{noformat}
$ hadoop fs -rmr hdfs://namenode1/user/foo/bar
rmr: Wrong FS: hdfs://namenode1/user/foo/bar, expected: hdfs://namenode1.foobar.com
Usage: java FsShell [-rmr <path>]
$ hadoop fs -rmr hdfs://namenode1.foobar.com/user/foo/bar
$
{noformat}
It should be possible to use the FileSystem for the Path provided rather than the default FileSystem. 0.17 was less particular about this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5086) Trash URI semantics can be relaxed
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666390#action_12666390 ]
Chris Douglas commented on HADOOP-5086:
---------------------------------------
Passed all unit tests on my machine.
Should this go into 0.20? This changed between 0.17 and 0.18, but not between 0.18 and trunk.
> Trash URI semantics can be relaxed
> ----------------------------------
>
> Key: HADOOP-5086
> URL: https://issues.apache.org/jira/browse/HADOOP-5086
> Project: Hadoop Core
> Issue Type: Improvement
> Components: fs
> Affects Versions: 0.18.0
> Reporter: Chris Douglas
> Assignee: Chris Douglas
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: 5086-0.patch, 5086-1.patch
>
>
> When using fully qualified URIs with FsShell, the authority element of the URI must match the default filesystem exactly, or else one may get an error message when the trash is enabled:
> {noformat}
> $ hadoop fs -rmr hdfs://namenode1/user/foo/bar
> rmr: Wrong FS: hdfs://namenode1/user/foo/bar, expected: hdfs://namenode1.foobar.com
> Usage: java FsShell [-rmr <path>]
> $ hadoop fs -rmr hdfs://namenode1.foobar.com/user/foo/bar
> $
> {noformat}
> It should be possible to use the FileSystem for the Path provided rather than the default FileSystem. 0.17 was less particular about this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5086) Trash URI semantics can be relaxed
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666352#action_12666352 ]
Chris Douglas commented on HADOOP-5086:
---------------------------------------
{noformat}
[exec] +1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 15 new or modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
{noformat}
> Trash URI semantics can be relaxed
> ----------------------------------
>
> Key: HADOOP-5086
> URL: https://issues.apache.org/jira/browse/HADOOP-5086
> Project: Hadoop Core
> Issue Type: Improvement
> Components: fs
> Affects Versions: 0.18.0
> Reporter: Chris Douglas
> Assignee: Chris Douglas
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: 5086-0.patch, 5086-1.patch
>
>
> When using fully qualified URIs with FsShell, the authority element of the URI must match the default filesystem exactly, or else one may get an error message when the trash is enabled:
> {noformat}
> $ hadoop fs -rmr hdfs://namenode1/user/foo/bar
> rmr: Wrong FS: hdfs://namenode1/user/foo/bar, expected: hdfs://namenode1.foobar.com
> Usage: java FsShell [-rmr <path>]
> $ hadoop fs -rmr hdfs://namenode1.foobar.com/user/foo/bar
> $
> {noformat}
> It should be possible to use the FileSystem for the Path provided rather than the default FileSystem. 0.17 was less particular about this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5086) Trash URI semantics can be relaxed
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12665897#action_12665897 ]
Doug Cutting commented on HADOOP-5086:
--------------------------------------
> shouldn't the unit test be in o.a.h.fs?
Yes, the generic bits certainly. And it would be useful if the test were reusable by HDFS, so that it could, e.g., subclass the core test to run things on a mini cluster.
> Trash URI semantics can be relaxed
> ----------------------------------
>
> Key: HADOOP-5086
> URL: https://issues.apache.org/jira/browse/HADOOP-5086
> Project: Hadoop Core
> Issue Type: Improvement
> Components: fs
> Affects Versions: 0.18.0
> Reporter: Chris Douglas
> Priority: Minor
> Attachments: 5086-0.patch
>
>
> When using fully qualified URIs with FsShell, the authority element of the URI must match the default filesystem exactly, or else one may get an error message when the trash is enabled:
> {noformat}
> $ hadoop fs -rmr hdfs://namenode1/user/foo/bar
> rmr: Wrong FS: hdfs://namenode1/user/foo/bar, expected: hdfs://namenode1.foobar.com
> Usage: java FsShell [-rmr <path>]
> $ hadoop fs -rmr hdfs://namenode1.foobar.com/user/foo/bar
> $
> {noformat}
> It should be possible to use the FileSystem for the Path provided rather than the default FileSystem. 0.17 was less particular about this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5086) Trash URI semantics can be relaxed
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-5086:
----------------------------------
Fix Version/s: 0.21.0
Assignee: Chris Douglas
Status: Patch Available (was: Open)
> Trash URI semantics can be relaxed
> ----------------------------------
>
> Key: HADOOP-5086
> URL: https://issues.apache.org/jira/browse/HADOOP-5086
> Project: Hadoop Core
> Issue Type: Improvement
> Components: fs
> Affects Versions: 0.18.0
> Reporter: Chris Douglas
> Assignee: Chris Douglas
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: 5086-0.patch, 5086-1.patch
>
>
> When using fully qualified URIs with FsShell, the authority element of the URI must match the default filesystem exactly, or else one may get an error message when the trash is enabled:
> {noformat}
> $ hadoop fs -rmr hdfs://namenode1/user/foo/bar
> rmr: Wrong FS: hdfs://namenode1/user/foo/bar, expected: hdfs://namenode1.foobar.com
> Usage: java FsShell [-rmr <path>]
> $ hadoop fs -rmr hdfs://namenode1.foobar.com/user/foo/bar
> $
> {noformat}
> It should be possible to use the FileSystem for the Path provided rather than the default FileSystem. 0.17 was less particular about this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5086) Trash URI semantics can be relaxed
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-5086:
----------------------------------
Resolution: Fixed
Fix Version/s: (was: 0.21.0)
0.19.1
Hadoop Flags: [Reviewed] (was: [Incompatible change])
Status: Resolved (was: Patch Available)
bq. We could, in theory, merge a fix to the 0.19 [0.18?] and 0.19 branches too, if we wanted.
Soright. I'll hold off on 0.18, since the vote for that has already been called.
I committed this.
> Trash URI semantics can be relaxed
> ----------------------------------
>
> Key: HADOOP-5086
> URL: https://issues.apache.org/jira/browse/HADOOP-5086
> Project: Hadoop Core
> Issue Type: Improvement
> Components: fs
> Affects Versions: 0.18.0
> Reporter: Chris Douglas
> Assignee: Chris Douglas
> Priority: Minor
> Fix For: 0.19.1
>
> Attachments: 5086-0.patch, 5086-1.patch
>
>
> When using fully qualified URIs with FsShell, the authority element of the URI must match the default filesystem exactly, or else one may get an error message when the trash is enabled:
> {noformat}
> $ hadoop fs -rmr hdfs://namenode1/user/foo/bar
> rmr: Wrong FS: hdfs://namenode1/user/foo/bar, expected: hdfs://namenode1.foobar.com
> Usage: java FsShell [-rmr <path>]
> $ hadoop fs -rmr hdfs://namenode1.foobar.com/user/foo/bar
> $
> {noformat}
> It should be possible to use the FileSystem for the Path provided rather than the default FileSystem. 0.17 was less particular about this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5086) Trash URI semantics can be relaxed
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-5086:
----------------------------------
Attachment: 5086-0.patch
Attaching patch shuffling cstr params around, added a unit test (shouldn't the unit test be in o.a.h.fs? If it were moved, this could use Trash::getCurrentTrashDir instead of hard-coding its params).
> Trash URI semantics can be relaxed
> ----------------------------------
>
> Key: HADOOP-5086
> URL: https://issues.apache.org/jira/browse/HADOOP-5086
> Project: Hadoop Core
> Issue Type: Improvement
> Components: fs
> Affects Versions: 0.18.0
> Reporter: Chris Douglas
> Priority: Minor
> Attachments: 5086-0.patch
>
>
> When using fully qualified URIs with FsShell, the authority element of the URI must match the default filesystem exactly, or else one may get an error message when the trash is enabled:
> {noformat}
> $ hadoop fs -rmr hdfs://namenode1/user/foo/bar
> rmr: Wrong FS: hdfs://namenode1/user/foo/bar, expected: hdfs://namenode1.foobar.com
> Usage: java FsShell [-rmr <path>]
> $ hadoop fs -rmr hdfs://namenode1.foobar.com/user/foo/bar
> $
> {noformat}
> It should be possible to use the FileSystem for the Path provided rather than the default FileSystem. 0.17 was less particular about this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5086) Trash URI semantics can be relaxed
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-5086:
----------------------------------
Attachment: 5086-1.patch
bq. it would be useful if the test were reusable by HDFS, so that it could, e.g., subclass the core test to run things on a mini cluster.
Good idea. Moved trash tests to fs, HDFS test of trash to a subclass.
> Trash URI semantics can be relaxed
> ----------------------------------
>
> Key: HADOOP-5086
> URL: https://issues.apache.org/jira/browse/HADOOP-5086
> Project: Hadoop Core
> Issue Type: Improvement
> Components: fs
> Affects Versions: 0.18.0
> Reporter: Chris Douglas
> Priority: Minor
> Attachments: 5086-0.patch, 5086-1.patch
>
>
> When using fully qualified URIs with FsShell, the authority element of the URI must match the default filesystem exactly, or else one may get an error message when the trash is enabled:
> {noformat}
> $ hadoop fs -rmr hdfs://namenode1/user/foo/bar
> rmr: Wrong FS: hdfs://namenode1/user/foo/bar, expected: hdfs://namenode1.foobar.com
> Usage: java FsShell [-rmr <path>]
> $ hadoop fs -rmr hdfs://namenode1.foobar.com/user/foo/bar
> $
> {noformat}
> It should be possible to use the FileSystem for the Path provided rather than the default FileSystem. 0.17 was less particular about this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5086) Trash URI semantics can be relaxed
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666667#action_12666667 ]
Doug Cutting commented on HADOOP-5086:
--------------------------------------
> Should this go into 0.20? This changed between 0.17 and 0.18, but not between 0.18 and trunk.
+1 It's still a regression, even if we were slow to notice it. We could, in theory, merge a fix to the 0.19 and 0.19 branches too, if we wanted.
> Trash URI semantics can be relaxed
> ----------------------------------
>
> Key: HADOOP-5086
> URL: https://issues.apache.org/jira/browse/HADOOP-5086
> Project: Hadoop Core
> Issue Type: Improvement
> Components: fs
> Affects Versions: 0.18.0
> Reporter: Chris Douglas
> Assignee: Chris Douglas
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: 5086-0.patch, 5086-1.patch
>
>
> When using fully qualified URIs with FsShell, the authority element of the URI must match the default filesystem exactly, or else one may get an error message when the trash is enabled:
> {noformat}
> $ hadoop fs -rmr hdfs://namenode1/user/foo/bar
> rmr: Wrong FS: hdfs://namenode1/user/foo/bar, expected: hdfs://namenode1.foobar.com
> Usage: java FsShell [-rmr <path>]
> $ hadoop fs -rmr hdfs://namenode1.foobar.com/user/foo/bar
> $
> {noformat}
> It should be possible to use the FileSystem for the Path provided rather than the default FileSystem. 0.17 was less particular about this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5086) Trash URI semantics can be relaxed
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666331#action_12666331 ]
Doug Cutting commented on HADOOP-5086:
--------------------------------------
+1 this looks good to me.
> Trash URI semantics can be relaxed
> ----------------------------------
>
> Key: HADOOP-5086
> URL: https://issues.apache.org/jira/browse/HADOOP-5086
> Project: Hadoop Core
> Issue Type: Improvement
> Components: fs
> Affects Versions: 0.18.0
> Reporter: Chris Douglas
> Assignee: Chris Douglas
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: 5086-0.patch, 5086-1.patch
>
>
> When using fully qualified URIs with FsShell, the authority element of the URI must match the default filesystem exactly, or else one may get an error message when the trash is enabled:
> {noformat}
> $ hadoop fs -rmr hdfs://namenode1/user/foo/bar
> rmr: Wrong FS: hdfs://namenode1/user/foo/bar, expected: hdfs://namenode1.foobar.com
> Usage: java FsShell [-rmr <path>]
> $ hadoop fs -rmr hdfs://namenode1.foobar.com/user/foo/bar
> $
> {noformat}
> It should be possible to use the FileSystem for the Path provided rather than the default FileSystem. 0.17 was less particular about this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.