You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Daryn Sharp (JIRA)" <ji...@apache.org> on 2013/09/30 22:54:29 UTC
[jira] [Commented] (HADOOP-9281) Rework all usages of o.a.h.metrics
to o.a.h.metrics2 new metrics API
[ https://issues.apache.org/jira/browse/HADOOP-9281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13782229#comment-13782229 ]
Daryn Sharp commented on HADOOP-9281:
-------------------------------------
The patch slices across common, mapreduce, and yarn. It would be nice to split this into multiple patches and remove some of the "nice" but strictly unneeded changes to files that otherwise wouldn't have been touched.
I haven't throughly reviewed, but {{ServletSink.numInstances}} appears to be used in a non-thread safe way.
> Rework all usages of o.a.h.metrics to o.a.h.metrics2 new metrics API
> --------------------------------------------------------------------
>
> Key: HADOOP-9281
> URL: https://issues.apache.org/jira/browse/HADOOP-9281
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 3.0.0, 2.0.3-alpha, 0.23.7
> Reporter: Ivan A. Veselovsky
> Assignee: Ivan A. Veselovsky
> Attachments: HADOOP-9281-branch-0.23--N5.patch, HADOOP-9281-trunk--N5.patch, HADOOP-9281-trunk--N6.patch
>
>
> The following done:
> 1) o.a.h.metrics.MetricsServlet reworked to o.a.h.metrics2.lib.MetricsServlet2
> 2) class org.apache.hadoop.mapreduce.task.reduce.ShuffleClientMetrics rewritten to use metrics2 API.
> 3) class org.apache.hadoop.mapred.LocalJobRunnerMetrics rewritten to use new metrics2 API.
--
This message was sent by Atlassian JIRA
(v6.1#6144)