You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/05/10 22:23:43 UTC

[GitHub] [tvm] Lunderberg opened a new pull request #8013: [Vulkan][Codegen] Spir-V codegen, correct labels/blocks in WhileNode.

Lunderberg opened a new pull request #8013:
URL: https://github.com/apache/tvm/pull/8013


   Previously, the WhileNode assumes that evaluating the loop condition
   will not introduce any additional labels.  If this assumption is
   violated, such as for a WhileNode whose condition is an if/else
   statement, then the OpLoopMerge instruction appears in the wrong
   block.
   
   The unittest added exercises this code path, but doesn't yet trigger a
   failure.  Once spvValidate is enabled for all vulkan codegen, then
   this unit test will catch the failure mode.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi merged pull request #8013: [Vulkan][Codegen] Spir-V codegen, correct labels/blocks in WhileNode.

Posted by GitBox <gi...@apache.org>.

masahi merged pull request #8013:
URL: https://github.com/apache/tvm/pull/8013


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] Lunderberg commented on pull request #8013: [Vulkan][Codegen] Spir-V codegen, correct labels/blocks in WhileNode.

Posted by GitBox <gi...@apache.org>.

Lunderberg commented on pull request #8013:
URL: https://github.com/apache/tvm/pull/8013#issuecomment-837431486


   Potential reviewers: @masahi 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi commented on pull request #8013: [Vulkan][Codegen] Spir-V codegen, correct labels/blocks in WhileNode.

Posted by GitBox <gi...@apache.org>.

masahi commented on pull request #8013:
URL: https://github.com/apache/tvm/pull/8013#issuecomment-837818030


   thanks @Lunderberg 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org