[GitHub] merlimat commented on a change in pull request #1727: Encode zk-path for function-pkg

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #1727: Encode zk-path for function-pkg
URL: https://github.com/apache/incubator-pulsar/pull/1727#discussion_r186140148
 
 

 ##########
 File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/Utils.java
 ##########
 @@ -99,18 +100,19 @@ public static void uploadToBookeeper(Namespace dlogNamespace,
                                          String destPkgPath)
             throws IOException {
 
+        String encodedDestPkgPath = Codec.encode(destPkgPath);
 
 Review comment:
   If we encode the whole path, won't we end up having a flat list of names? 
   
   I think we should do as in topics where only the final part of topic is escaped

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services