You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org> on 2004/11/05 04:11:32 UTC
[jira] Created: (GERONIMO-438) Deployer.deploy arguments inconsistent
Deployer.deploy arguments inconsistent
--------------------------------------
Key: GERONIMO-438
URL: http://nagoya.apache.org/jira/browse/GERONIMO-438
Project: Apache Geronimo
Type: Bug
Components: deployment
Versions: 1.0-M2
Reporter: Aaron Mulder
One deploy method starts with the arguments:
File module, File plan
Another overloaded deploy method starts with the arguments:
File plan, File module
These should not be reversed, but we need to carefully hunt down usages since the types alone won't cause the usages to be flagged if one is switched.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
Re: [jira] Commented: (GERONIMO-438) Deployer.deploy arguments inconsistent
Posted by Vamsavardhana Reddy <c1...@gmail.com>.
Aaron,
Can you look at the comments I posted to the JIRA and check if we can
conclude the "hunt"?
Thanks,
Vamsi
On 1/2/07, Vamsavardhana Reddy (JIRA) <ji...@apache.org> wrote:
>
>
> [
> http://issues.apache.org/jira/browse/GERONIMO-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12461709]
>
> Vamsavardhana Reddy commented on GERONIMO-438:
> ----------------------------------------------
>
> To make sure that PackageBuilder.invokeDeployer() is the only place
> outside Deployer where the 3rd method is used, I have introduced
> (temporarily) an extra string argument in the method signature and built the
> server. There were no build errors and the server ran fine. I hope this
> info will also be helpful.
>
> > Deployer.deploy arguments inconsistent
> > --------------------------------------
> >
> > Key: GERONIMO-438
> > URL: http://issues.apache.org/jira/browse/GERONIMO-438
> > Project: Geronimo
> > Issue Type: Bug
> > Components: deployment
> > Affects Versions: 1.0-M2
> > Reporter: Aaron Mulder
> > Fix For: Wish List
> >
> > Attachments: g-438-11x-option2.patch, g-438-option1.patch,
> g-438-option2.patch
> >
> >
> > One deploy method starts with the arguments:
> > File module, File plan
> > Another overloaded deploy method starts with the arguments:
> > File plan, File module
> > These should not be reversed, but we need to carefully hunt down usages
> since the types alone won't cause the usages to be flagged if one is
> switched.
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators:
> http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>
[jira] Assigned: (GERONIMO-438) Deployer.deploy arguments
inconsistent
Posted by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-438?page=all ]
Aaron Mulder reassigned GERONIMO-438:
-------------------------------------
Assign To: Dain Sundstrom
Yeah, it's been around for a while :)
> Deployer.deploy arguments inconsistent
> --------------------------------------
>
> Key: GERONIMO-438
> URL: http://issues.apache.org/jira/browse/GERONIMO-438
> Project: Geronimo
> Type: Bug
> Components: deployment
> Versions: 1.0-M2
> Reporter: Aaron Mulder
> Assignee: Dain Sundstrom
> Fix For: Wish List
>
> One deploy method starts with the arguments:
> File module, File plan
> Another overloaded deploy method starts with the arguments:
> File plan, File module
> These should not be reversed, but we need to carefully hunt down usages since the types alone won't cause the usages to be flagged if one is switched.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-438) Deployer.deploy arguments
inconsistent
Posted by "Vamsavardhana Reddy (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-438?page=all ]
Vamsavardhana Reddy updated GERONIMO-438:
-----------------------------------------
Attachment: g-438-option1.patch
g-438-option1.patch: Patch as per option 1 described in the previous comment.
> Deployer.deploy arguments inconsistent
> --------------------------------------
>
> Key: GERONIMO-438
> URL: http://issues.apache.org/jira/browse/GERONIMO-438
> Project: Geronimo
> Issue Type: Bug
> Components: deployment
> Affects Versions: 1.0-M2
> Reporter: Aaron Mulder
> Fix For: Wish List
>
> Attachments: g-438-option1.patch
>
>
> One deploy method starts with the arguments:
> File module, File plan
> Another overloaded deploy method starts with the arguments:
> File plan, File module
> These should not be reversed, but we need to carefully hunt down usages since the types alone won't cause the usages to be flagged if one is switched.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-438) Deployer.deploy arguments
inconsistent
Posted by "Matt Hogstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matt Hogstrom updated GERONIMO-438:
-----------------------------------
Fix Version/s: (was: 2.0-M2)
2.0-beta1
> Deployer.deploy arguments inconsistent
> --------------------------------------
>
> Key: GERONIMO-438
> URL: https://issues.apache.org/jira/browse/GERONIMO-438
> Project: Geronimo
> Issue Type: Bug
> Components: deployment
> Affects Versions: 1.0-M2
> Reporter: Aaron Mulder
> Fix For: 2.0-beta1
>
> Attachments: g-438-11x-option2.patch, g-438-option1.patch, g-438-option2.patch
>
>
> One deploy method starts with the arguments:
> File module, File plan
> Another overloaded deploy method starts with the arguments:
> File plan, File module
> These should not be reversed, but we need to carefully hunt down usages since the types alone won't cause the usages to be flagged if one is switched.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-438) Deployer.deploy arguments
inconsistent
Posted by "Vamsavardhana Reddy (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vamsavardhana Reddy updated GERONIMO-438:
-----------------------------------------
Attachment: g-438-11x-option2.patch
> Deployer.deploy arguments inconsistent
> --------------------------------------
>
> Key: GERONIMO-438
> URL: http://issues.apache.org/jira/browse/GERONIMO-438
> Project: Geronimo
> Issue Type: Bug
> Components: deployment
> Affects Versions: 1.0-M2
> Reporter: Aaron Mulder
> Fix For: Wish List
>
> Attachments: g-438-11x-option2.patch, g-438-option1.patch, g-438-option2.patch
>
>
> One deploy method starts with the arguments:
> File module, File plan
> Another overloaded deploy method starts with the arguments:
> File plan, File module
> These should not be reversed, but we need to carefully hunt down usages since the types alone won't cause the usages to be flagged if one is switched.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-438) Deployer.deploy arguments
inconsistent
Posted by "Vamsavardhana Reddy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vamsavardhana Reddy updated GERONIMO-438:
-----------------------------------------
Fix Version/s: (was: Wish List)
2.0-M2
Aaron, can you take a look at the comments posted to this JIRA recently and g-438-option2.patch . If you think there may not be any other references to the 3rd method (deploy method with many arguments) then we can apply the patch and close the JIRA.
Others are also welcome to comment.
> Deployer.deploy arguments inconsistent
> --------------------------------------
>
> Key: GERONIMO-438
> URL: https://issues.apache.org/jira/browse/GERONIMO-438
> Project: Geronimo
> Issue Type: Bug
> Components: deployment
> Affects Versions: 1.0-M2
> Reporter: Aaron Mulder
> Fix For: 2.0-M2
>
> Attachments: g-438-11x-option2.patch, g-438-option1.patch, g-438-option2.patch
>
>
> One deploy method starts with the arguments:
> File module, File plan
> Another overloaded deploy method starts with the arguments:
> File plan, File module
> These should not be reversed, but we need to carefully hunt down usages since the types alone won't cause the usages to be flagged if one is switched.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (GERONIMO-438) Deployer.deploy arguments
inconsistent
Posted by "Vamsavardhana Reddy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vamsavardhana Reddy closed GERONIMO-438.
----------------------------------------
Resolution: Fixed
Fixed in rev 496988 in trunk.
o Looks like PackageMojo.invokeDeployer() is the only place where Deployer.deploy() method with "long signature" is called.
o Concluding the hunt for the method usage and updating Deployer and PackageMojo classes to make the arguments consistent.
> Deployer.deploy arguments inconsistent
> --------------------------------------
>
> Key: GERONIMO-438
> URL: https://issues.apache.org/jira/browse/GERONIMO-438
> Project: Geronimo
> Issue Type: Bug
> Components: deployment
> Affects Versions: 1.0-M2
> Reporter: Aaron Mulder
> Assigned To: Vamsavardhana Reddy
> Fix For: 2.0-M2
>
> Attachments: g-438-11x-option2.patch, g-438-option1.patch, g-438-option2.patch
>
>
> One deploy method starts with the arguments:
> File module, File plan
> Another overloaded deploy method starts with the arguments:
> File plan, File module
> These should not be reversed, but we need to carefully hunt down usages since the types alone won't cause the usages to be flagged if one is switched.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-438) Deployer.deploy arguments
inconsistent
Posted by "Vamsavardhana Reddy (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-438?page=all ]
Vamsavardhana Reddy updated GERONIMO-438:
-----------------------------------------
Attachment: g-438-option2.patch
g-438-option2.patch: Patch as per option 2 described in the previous comment.
> Deployer.deploy arguments inconsistent
> --------------------------------------
>
> Key: GERONIMO-438
> URL: http://issues.apache.org/jira/browse/GERONIMO-438
> Project: Geronimo
> Issue Type: Bug
> Components: deployment
> Affects Versions: 1.0-M2
> Reporter: Aaron Mulder
> Fix For: Wish List
>
> Attachments: g-438-option1.patch, g-438-option2.patch
>
>
> One deploy method starts with the arguments:
> File module, File plan
> Another overloaded deploy method starts with the arguments:
> File plan, File module
> These should not be reversed, but we need to carefully hunt down usages since the types alone won't cause the usages to be flagged if one is switched.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-438) Deployer.deploy arguments
inconsistent
Posted by "Sachin Patel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12461976 ]
Sachin Patel commented on GERONIMO-438:
---------------------------------------
The Eclipse Plugin does not call the gbean directly, only through the JSR-88 APIs, so switching them I THINK should be ok.
> Deployer.deploy arguments inconsistent
> --------------------------------------
>
> Key: GERONIMO-438
> URL: https://issues.apache.org/jira/browse/GERONIMO-438
> Project: Geronimo
> Issue Type: Bug
> Components: deployment
> Affects Versions: 1.0-M2
> Reporter: Aaron Mulder
> Fix For: Wish List
>
> Attachments: g-438-11x-option2.patch, g-438-option1.patch, g-438-option2.patch
>
>
> One deploy method starts with the arguments:
> File module, File plan
> Another overloaded deploy method starts with the arguments:
> File plan, File module
> These should not be reversed, but we need to carefully hunt down usages since the types alone won't cause the usages to be flagged if one is switched.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-438) Deployer.deploy arguments
inconsistent
Posted by "Vamsavardhana Reddy (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12461709 ]
Vamsavardhana Reddy commented on GERONIMO-438:
----------------------------------------------
To make sure that PackageBuilder.invokeDeployer() is the only place outside Deployer where the 3rd method is used, I have introduced (temporarily) an extra string argument in the method signature and built the server. There were no build errors and the server ran fine. I hope this info will also be helpful.
> Deployer.deploy arguments inconsistent
> --------------------------------------
>
> Key: GERONIMO-438
> URL: http://issues.apache.org/jira/browse/GERONIMO-438
> Project: Geronimo
> Issue Type: Bug
> Components: deployment
> Affects Versions: 1.0-M2
> Reporter: Aaron Mulder
> Fix For: Wish List
>
> Attachments: g-438-11x-option2.patch, g-438-option1.patch, g-438-option2.patch
>
>
> One deploy method starts with the arguments:
> File module, File plan
> Another overloaded deploy method starts with the arguments:
> File plan, File module
> These should not be reversed, but we need to carefully hunt down usages since the types alone won't cause the usages to be flagged if one is switched.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-438) Deployer.deploy arguments
inconsistent
Posted by "Dain Sundstrom (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-438?page=all ]
Dain Sundstrom updated GERONIMO-438:
------------------------------------
Assign To: (was: Dain Sundstrom)
> Deployer.deploy arguments inconsistent
> --------------------------------------
>
> Key: GERONIMO-438
> URL: http://issues.apache.org/jira/browse/GERONIMO-438
> Project: Geronimo
> Type: Bug
> Components: deployment
> Versions: 1.0-M2
> Reporter: Aaron Mulder
> Fix For: Wish List
>
> One deploy method starts with the arguments:
> File module, File plan
> Another overloaded deploy method starts with the arguments:
> File plan, File module
> These should not be reversed, but we need to carefully hunt down usages since the types alone won't cause the usages to be flagged if one is switched.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-438) Deployer.deploy arguments inconsistent
Posted by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-438?page=all ]
Aaron Mulder updated GERONIMO-438:
----------------------------------
Fix Version: Wish List
Description:
One deploy method starts with the arguments:
File module, File plan
Another overloaded deploy method starts with the arguments:
File plan, File module
These should not be reversed, but we need to carefully hunt down usages since the types alone won't cause the usages to be flagged if one is switched.
was:
One deploy method starts with the arguments:
File module, File plan
Another overloaded deploy method starts with the arguments:
File plan, File module
These should not be reversed, but we need to carefully hunt down usages since the types alone won't cause the usages to be flagged if one is switched.
Environment:
> Deployer.deploy arguments inconsistent
> --------------------------------------
>
> Key: GERONIMO-438
> URL: http://issues.apache.org/jira/browse/GERONIMO-438
> Project: Geronimo
> Type: Bug
> Components: deployment
> Versions: 1.0-M2
> Reporter: Aaron Mulder
> Fix For: Wish List
>
> One deploy method starts with the arguments:
> File module, File plan
> Another overloaded deploy method starts with the arguments:
> File plan, File module
> These should not be reversed, but we need to carefully hunt down usages since the types alone won't cause the usages to be flagged if one is switched.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-438) Deployer.deploy arguments
inconsistent
Posted by "Vamsavardhana Reddy (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-438?page=comments#action_12461214 ]
Vamsavardhana Reddy commented on GERONIMO-438:
----------------------------------------------
In trunk(rev 490751), org.apache.geronimo.deployment.Deploy has three deploy methods.
1. public List deploy(boolean inPlace, File moduleFile, File planFile) throws DeploymentException;
2. public List deploy(boolean inPlace, File moduleFile, File planFile, String targetConfigStore) throws DeploymentException;
3. public List deploy(boolean inPlace,
File planFile,
File moduleFile,
File targetFile,
boolean install,
String mainClass,
String mainGBean, String mainMethod, String manifestConfigurations, String classPath,
String endorsedDirs,
String extensionDirs,
String targetConfigurationStore) throws DeploymentException;
3rd method is called by the 2nd method.
OBSERVATION 1:
By searching the workspace for Deployer.deploy() I found that org.apache.geronimo.deployment.plugin.local.AbstractDeployCommand.doDeploy() and org.apache.geronimo.mavenplugins.car.PackageMojo.invokeDeployer() are the only places where Deployer.deploy() is being invoked through kernel.invoke(). AbstractDeployCommand.doDeploy() is using the 2nd method and PackageMojo.invokeDeployer() is using the 3rd method.
OBSERVATION 2:
Making the the 3rd method as private, removing the method from GBeanInfo and modifying PackageMojo.invokeDeployer() to invoke 2nd method instead of 3rd did not result in any build failure. This means PackageMojo.invokeDeployer() may be the only place where 3rd method is being used externally.
CONCLUSION:
Option 1: Get rid of 3rd method from Deployer GBean and modify PackageMojo.invokeDeployer() to use 2nd method.
Option 2: Modify 3rd method to reorder the moduleFile and planFile arguments and update 2nd method and PackageMojo.invokeDeployer() to account for the reordering.
Am I missing anything? Could there be any other place where the 3rd method is being used?
> Deployer.deploy arguments inconsistent
> --------------------------------------
>
> Key: GERONIMO-438
> URL: http://issues.apache.org/jira/browse/GERONIMO-438
> Project: Geronimo
> Issue Type: Bug
> Components: deployment
> Affects Versions: 1.0-M2
> Reporter: Aaron Mulder
> Fix For: Wish List
>
>
> One deploy method starts with the arguments:
> File module, File plan
> Another overloaded deploy method starts with the arguments:
> File plan, File module
> These should not be reversed, but we need to carefully hunt down usages since the types alone won't cause the usages to be flagged if one is switched.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-438) Deployer.deploy arguments
inconsistent
Posted by "Vamsavardhana Reddy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vamsavardhana Reddy updated GERONIMO-438:
-----------------------------------------
Fix Version/s: (was: 2.0-beta1)
2.0-M2
Assignee: Vamsavardhana Reddy
> Deployer.deploy arguments inconsistent
> --------------------------------------
>
> Key: GERONIMO-438
> URL: https://issues.apache.org/jira/browse/GERONIMO-438
> Project: Geronimo
> Issue Type: Bug
> Components: deployment
> Affects Versions: 1.0-M2
> Reporter: Aaron Mulder
> Assigned To: Vamsavardhana Reddy
> Fix For: 2.0-M2
>
> Attachments: g-438-11x-option2.patch, g-438-option1.patch, g-438-option2.patch
>
>
> One deploy method starts with the arguments:
> File module, File plan
> Another overloaded deploy method starts with the arguments:
> File plan, File module
> These should not be reversed, but we need to carefully hunt down usages since the types alone won't cause the usages to be flagged if one is switched.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-438) Deployer.deploy arguments
inconsistent
Posted by "Vamsavardhana Reddy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12461959 ]
Vamsavardhana Reddy commented on GERONIMO-438:
----------------------------------------------
Sachin, can you check if reordering the moduleFile and planFile arguments in the 3rd method has any impact on the DEVTOOLS? If you can identify any calls to this 3rd deploy method we can change those accordingly and conclude this JIRA.
> Deployer.deploy arguments inconsistent
> --------------------------------------
>
> Key: GERONIMO-438
> URL: https://issues.apache.org/jira/browse/GERONIMO-438
> Project: Geronimo
> Issue Type: Bug
> Components: deployment
> Affects Versions: 1.0-M2
> Reporter: Aaron Mulder
> Fix For: Wish List
>
> Attachments: g-438-11x-option2.patch, g-438-option1.patch, g-438-option2.patch
>
>
> One deploy method starts with the arguments:
> File module, File plan
> Another overloaded deploy method starts with the arguments:
> File plan, File module
> These should not be reversed, but we need to carefully hunt down usages since the types alone won't cause the usages to be flagged if one is switched.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-438) Deployer.deploy arguments
inconsistent
Posted by "Vamsavardhana Reddy (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12461708 ]
Vamsavardhana Reddy commented on GERONIMO-438:
----------------------------------------------
g-438-11x-option2.patch:
Patch for branches\1.1 as per option 2 described previously. Incase of 1.1, invokeDeployer() method is in PackageBuilder. I have verified that branches\1.1 builds and server runs fine with this patch.
> Deployer.deploy arguments inconsistent
> --------------------------------------
>
> Key: GERONIMO-438
> URL: http://issues.apache.org/jira/browse/GERONIMO-438
> Project: Geronimo
> Issue Type: Bug
> Components: deployment
> Affects Versions: 1.0-M2
> Reporter: Aaron Mulder
> Fix For: Wish List
>
> Attachments: g-438-11x-option2.patch, g-438-option1.patch, g-438-option2.patch
>
>
> One deploy method starts with the arguments:
> File module, File plan
> Another overloaded deploy method starts with the arguments:
> File plan, File module
> These should not be reversed, but we need to carefully hunt down usages since the types alone won't cause the usages to be flagged if one is switched.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira