You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/08/31 13:04:36 UTC
[GitHub] [cloudstack-primate] shwstppr opened a new pull request #642: images: fix templates/ISOs all filter
shwstppr opened a new pull request #642:
URL: https://github.com/apache/cloudstack-primate/pull/642
Show **All** filter menu option for admins
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] shwstppr commented on pull request #642: images: fix templates/ISOs all filter
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #642:
URL: https://github.com/apache/cloudstack-primate/pull/642#issuecomment-684772599
@rhtyd @davidjumani just checked there was a minor User role. Do we need to revert this or can I raise a new PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #642: images: fix templates/ISOs all filter
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #642:
URL: https://github.com/apache/cloudstack-primate/pull/642#issuecomment-684324713
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/642 (JID-3406)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #642: images: fix templates/ISOs all filter
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #642:
URL: https://github.com/apache/cloudstack-primate/pull/642#discussion_r480149102
##########
File path: src/views/AutogenView.vue
##########
@@ -45,11 +45,11 @@
<a-select
v-if="!dataView && $route.meta.filters && $route.meta.filters.length > 0"
:placeholder="$t('label.filterby')"
- :value="$route.query.filter || (['Admin', 'DomainAdmin'].includes($store.getters.userInfo.roletype) && $route.name === 'vm' ? 'all' : 'self')"
+ :value="$route.query.filter || (['Admin', 'DomainAdmin'].includes($store.getters.userInfo.roletype) && ['vm', 'iso', 'template'].includes($route.name) ? 'all' : 'self')"
Review comment:
@shwstppr It shows all but the api calls `templatefilter=self`. Could you fix that ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #642: images: fix templates/ISOs all filter
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #642:
URL: https://github.com/apache/cloudstack-primate/pull/642#issuecomment-683815362
LGTM, I'll wait for @davidjumani 's testing and merge this tomorrow
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #642: images: fix templates/ISOs all filter
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #642:
URL: https://github.com/apache/cloudstack-primate/pull/642#issuecomment-683766279
@shwstppr a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #642: images: fix templates/ISOs all filter
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #642:
URL: https://github.com/apache/cloudstack-primate/pull/642#issuecomment-684289324
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #642: images: fix templates/ISOs all filter
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #642:
URL: https://github.com/apache/cloudstack-primate/pull/642#issuecomment-683770744
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/642 (JID-3401)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #642: images: fix templates/ISOs all filter
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #642:
URL: https://github.com/apache/cloudstack-primate/pull/642#issuecomment-684292317
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #642: images: fix templates/ISOs all filter
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #642:
URL: https://github.com/apache/cloudstack-primate/pull/642
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] shwstppr commented on pull request #642: images: fix templates/ISOs all filter
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #642:
URL: https://github.com/apache/cloudstack-primate/pull/642#issuecomment-683765650
@blueorangutan package
@rhtyd @davidjumani please review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org