You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "xichen01 (via GitHub)" <gi...@apache.org> on 2023/04/14 18:19:02 UTC

[GitHub] [ozone] xichen01 opened a new pull request, #4570: HDDS-8421. Reduce DN IO times when writeChunk (FilePerBlockStrategy)

xichen01 opened a new pull request, #4570:
URL: https://github.com/apache/ozone/pull/4570

   ## What changes were proposed in this pull request?
   
   In the `FilePerBlockStrategy#writeChunk` will generate twice IO process.
   
   - The first is to check whether the write operation is an overwrite, will check whether the chunk file is exist (`ChunkUtils#verifyChunkFileExists`).
   - The second is write Chunk, will open file and write file.
   
   Those two IO operation can merge to once. just need to check whether is overwrite after open file and before write Chunk
   
   ## What is the link to the Apache JIRA
   https://issues.apache.org/jira/browse/HDDS-8421
   
   ## How was this patch tested?
   
   unit test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] kerneltime commented on pull request #4570: HDDS-8421. Reduce DN IO times when writeChunk (FilePerBlockStrategy)

Posted by "kerneltime (via GitHub)" <gi...@apache.org>.
kerneltime commented on PR #4570:
URL: https://github.com/apache/ozone/pull/4570#issuecomment-1511685309

   @tanvipenumudy can you please take a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] adoroszlai commented on pull request #4570: HDDS-8421. Reduce DN IO times when writeChunk (FilePerBlockStrategy)

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #4570:
URL: https://github.com/apache/ozone/pull/4570#issuecomment-1518535902

   Thanks @xichen01 for the patch, @tanvipenumudy for the review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] adoroszlai commented on pull request #4570: HDDS-8421. Reduce DN IO times when writeChunk (FilePerBlockStrategy)

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #4570:
URL: https://github.com/apache/ozone/pull/4570#issuecomment-1517424140

   @aswinshakil @duongkame @jojochuang @kerneltime @szetszwo @tanvipenumudy if there are no further comments, I'll commit this today.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] adoroszlai merged pull request #4570: HDDS-8421. Reduce DN IO times when writeChunk (FilePerBlockStrategy)

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #4570:
URL: https://github.com/apache/ozone/pull/4570


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org