[jira] [Commented] (FLINK-8459) Implement cancelWithSavepoint in RestClusterClient

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-8459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16383610#comment-16383610 ] 

ASF GitHub Bot commented on FLINK-8459:
---------------------------------------

GitHub user GJL opened a pull request:

    https://github.com/apache/flink/pull/5622

    [FLINK-8459][flip6] Implement RestClusterClient.cancelWithSavepoint

    ## What is the purpose of the change
    
    *Introduce cancelJob flag to existing triggerSavepoint methods in Dispatcher and
    JobMaster. Stop checkpoint scheduler before taking savepoint to make sure that
    the savepoint created by this command is the last one.*
    
    cc: @tillrohrmann 
    
    ## Brief change log
    
      - *Implement RestClusterClient.cancelWithSavepoint*
    
    ## Verifying this change
    
    This change added tests and can be verified as follows:
    
      - *Added `JobMasterTriggerSavepointIT`.*
      - *Manually tested.*
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes / **no**)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
      - The serializers: (yes / **no** / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (**yes** / no / don't know)
      - The S3 file system connector: (yes / **no** / don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes / **no**)
      - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/GJL/flink FLINK-8459-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5622.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5622
    
----
commit 7e913b0d1eab8453279ffacc11f4633b9263190d
Author: gyao <ga...@...>
Date:   2018-03-02T14:11:36Z

    [FLINK-8459][flip6] Implement RestClusterClient.cancelWithSavepoint
    
    Introduce cancelJob flag to existing triggerSavepoint methods in Dispatcher and
    JobMaster. Stop checkpoint scheduler before taking savepoint to make sure that
    the savepoint created by this command is the last one.

----


> Implement cancelWithSavepoint in RestClusterClient
> --------------------------------------------------
>
>                 Key: FLINK-8459
>                 URL: https://issues.apache.org/jira/browse/FLINK-8459
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Client
>    Affects Versions: 1.5.0
>            Reporter: Gary Yao
>            Assignee: Gary Yao
>            Priority: Blocker
>              Labels: flip-6
>             Fix For: 1.5.0
>
>
> Implement the method
>         {{RestClusterClient#cancelWithSavepoint(JobID jobId, @Nullable String savepointDirectory)}}.
> by either taking a savepoint and cancel the job separately, or by migrating the logic in {{JobCancellationWithSavepointHandlers}}. The former will have different semantics because the checkpoint scheduler is not stopped. Thus it is not guaranteed that there won't be additional checkpoints between the savepoint and the job cancelation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)