[Bug 120539] New: Gradient of type 'Square' is not always square

[bu...@apache.org]

https://issues.apache.org/ooo/show_bug.cgi?id=120539

          Priority: P3
            Bug ID: 120539
          Assignee: ooo-issues@incubator.apache.org
           Summary: Gradient of type 'Square' is not always square
          Severity: normal
        Issue Type: DEFECT
    Classification: Application
                OS: All
          Reporter: rb.henschel@t-online.de
          Hardware: All
            Status: CONFIRMED
           Version: AOO350-dev
         Component: viewing
           Product: drawing

Created attachment 78908
  --> https://issues.apache.org/ooo/attachment.cgi?id=78908&action=edit
The gradient palette

Load the attached gradient file. (I'm not sure, if the error can be seen, if
the gradient is not in the palette. You can try to skip this step.)

Then open the attached presentation.
The rectangles have all the same square gradient set but differ in number of
steps.
First error:
In edit mode, none of them is square.

Switch to presentation mode.
The gradients with step number until 64 are squares, step number from 65 on are
not square.

If you export a single rectangle with low number of steps to a png-picture, you
get the correct square gradient too. If you export the whole page, you get the
wrong stretched gradients for the low step gradients too.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120539] Gradient of type 'Square' is not always square

[bu...@apache.org]

https://issues.apache.org/ooo/show_bug.cgi?id=120539

Armin Le Grand <Ar...@me.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|ooo-issues@incubator.apache |Armin.Le.Grand@me.com
                   |.org                        |

--- Comment #4 from Armin Le Grand <Ar...@me.com> ---
ALG: As a hint to myself: May be an error in initRectGradientInfo compared to
initEllipticalGradientInfo with bCircular = true. Taking a look...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120539] Gradient of type 'Square' is not always square

[bu...@apache.org]

https://issues.apache.org/ooo/show_bug.cgi?id=120539

Regina Henschel <rb...@t-online.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |UNCONFIRMED
     Ever confirmed|1                           |0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120539] Gradient of type 'Square' is not always square

[bu...@apache.org]

https://issues.apache.org/ooo/show_bug.cgi?id=120539

Armin Le Grand <Ar...@me.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |Armin.Le.Grand@me.com

--- Comment #2 from Armin Le Grand <Ar...@me.com> ---
ALG: The basic definition came from the VCL implementation; it calculates the
outer bounds for the gradient (rectangle) and then paints from outside to
inside, all this is calculated and done in pixels. Then a step width in X and Y
is calculated to get the needed number of color steps (e.g. sx, sy).
Rectangular just means to take min(sx, sy) for both directions (which leads to
the forms seen in the edit view). Square means to use sx, sy as is.
The edit view nowadays uses a back-transformed transformation to do these
gradients (very hard to do due to the old VCL directly pixel-oriented paint
approach, but needed since these gradients can also be used for 3D, and there
you need the transformations to map the fillings).
The presentation view uses the exported metafile (still, not primitives). I'm
not sure what is done there, but to get it do the same a future presentation
mode using primitives will help.
I do not have currently a very old StarOffice around, but maybe Square indeed
once was square and it is an error. Who has one and could take a look? Radial
and Ellipsoid are pretty much the same, except that an ellipse is painted
instead of a rectangle, and Radial does use always circles, not ellipses.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120539] Gradient of type 'Square' is not always square

[bu...@apache.org]

https://issues.apache.org/ooo/show_bug.cgi?id=120539

--- Comment #3 from Regina Henschel <rb...@t-online.de> ---
OOo 3.2 has real squares, OOo3.2 is not very old. Step width is equal even if
the outer shape is rectangle or oval, so that some regions have no gradient.

Ellipsoid and Rectangle uses equal step width too, therefore we get the long
line in the middle, because equal steps width do not lead to similarity. So the
essential difference between type "Square" and "Rectangle" would be, that the
blending is done with similarity in type "Square" and with equal step width in
type "Rectangle".

I'm not against a change for square. It now looks like the MS Office style
"Rectangular" and allows better import at least in the centric cases.

I think about, how to define such a gradient unambiguous. The help text has
nothing about it and the spec is not really understandable.

So I suggest that the issue here is not to change it back to true square, but
to make it work in all cases.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120539] Gradient of type 'Square' is not always square

[bu...@apache.org]

https://issues.apache.org/ooo/show_bug.cgi?id=120539

--- Comment #1 from Regina Henschel <rb...@t-online.de> ---
Created attachment 78909
  --> https://issues.apache.org/ooo/attachment.cgi?id=78909&action=edit
The test presentation

-- 
You are receiving this mail because:
You are the assignee for the bug.