You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2022/03/04 17:32:48 UTC
[kudu-CR] [security] Fix FIPS mode() check in OpenSSL >= 1.1
Hello Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/18293
to review the following change.
Change subject: [security] Fix FIPS_mode() check in OpenSSL >= 1.1
......................................................................
[security] Fix FIPS_mode() check in OpenSSL >= 1.1
FIPS mode is only supported in OpenSSL 1.0.2 for now, and OpenSSL 1.1
doesn't even have a FIPS_mode() function, causing the build to fail when
compiling with OpenSSL 1.1 headers. To fix this, this function is now
not called when compiling against OpenSSL >= 1.1, and simply sets
fips_mode to false.
Change-Id: Ia75928f57f78de650600ebccb038e17eaba5d14b
---
M src/kudu/util/openssl_util.cc
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/18293/1
--
To view, visit http://gerrit.cloudera.org:8080/18293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia75928f57f78de650600ebccb038e17eaba5d14b
Gerrit-Change-Number: 18293
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [security] Fix FIPS mode() check in OpenSSL >= 1.1
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has abandoned this change. ( http://gerrit.cloudera.org:8080/18293 )
Change subject: [security] Fix FIPS_mode() check in OpenSSL >= 1.1
......................................................................
Abandoned
another commit addressed this
--
To view, visit http://gerrit.cloudera.org:8080/18293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ia75928f57f78de650600ebccb038e17eaba5d14b
Gerrit-Change-Number: 18293
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [security] Fix FIPS mode() check in OpenSSL >= 1.1
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has removed a vote on this change.
Change subject: [security] Fix FIPS_mode() check in OpenSSL >= 1.1
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/18293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ia75928f57f78de650600ebccb038e17eaba5d14b
Gerrit-Change-Number: 18293
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [security] Fix FIPS mode() check in OpenSSL >= 1.1
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18293 )
Change subject: [security] Fix FIPS_mode() check in OpenSSL >= 1.1
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia75928f57f78de650600ebccb038e17eaba5d14b
Gerrit-Change-Number: 18293
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 05 Mar 2022 07:56:48 +0000
Gerrit-HasComments: No
[kudu-CR] [security] Fix FIPS mode() check in OpenSSL >= 1.1
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has removed a vote on this change.
Change subject: [security] Fix FIPS_mode() check in OpenSSL >= 1.1
......................................................................
Removed -Verified by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/18293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ia75928f57f78de650600ebccb038e17eaba5d14b
Gerrit-Change-Number: 18293
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)