[GitHub] [skywalking-nodejs] BFergerson opened a new pull request, #96: fix: correct entry span url in endponts using Express middleware/router objects

[GitBox <gi...@apache.org>]

BFergerson opened a new pull request, #96:
URL: https://github.com/apache/skywalking-nodejs/pull/96

   The following code:
   ```typescript
   const app = express();
   const testRouter = express.Router();
   
   app.use('/test', testRouter);
   testRouter.get('/express', (req, res) => {
       res.sendStatus(200);
   });
   
   app.listen(3000);
   ```
   
   Results in entry spans with the URL of `/express` and not the correct URL of `/test/express`.
   
   This PR solves that using [req.originalUrl](https://expressjs.com/en/4x/api.html#req.originalUrl) when available.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-nodejs] kezhenxu94 merged pull request #96: fix: entry span url in endponts using Express middleware/router objects

[GitBox <gi...@apache.org>]

kezhenxu94 merged PR #96:
URL: https://github.com/apache/skywalking-nodejs/pull/96


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org