You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2019/08/16 22:53:41 UTC
Review Request 71301: Added a framework id field to the allocator
Framework struct.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71301/
-----------------------------------------------------------
Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
Repository: mesos
Description
-------
This provides easy lookup.
Also refactored related functions to take in `Framework&`
instead of `FrameworkId&`.
Diffs
-----
src/master/allocator/mesos/hierarchical.hpp 8be8dcee04e8fc5b97f730b2f058d14c81678788
src/master/allocator/mesos/hierarchical.cpp 580d35a3b71c1f7e851fa0504c6b9f037c05c378
Diff: https://reviews.apache.org/r/71301/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 71301: Added a framework id field to the allocator
Framework struct.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71301/#review217367
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On Aug. 20, 2019, 11:10 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71301/
> -----------------------------------------------------------
>
> (Updated Aug. 20, 2019, 11:10 p.m.)
>
>
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This provides easy lookup.
>
> Also refactored related functions to take in `Framework&`
> instead of `FrameworkId&`.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp 035fd3d7892d4280e299a29f99e8cf6a4c2afb30
> src/master/allocator/mesos/hierarchical.cpp b8b9241eae20691ed52c9b5759b17f88a0d8931f
>
>
> Diff: https://reviews.apache.org/r/71301/diff/5/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 71301: Added a framework id field to the allocator
Framework struct.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71301/
-----------------------------------------------------------
(Updated Aug. 20, 2019, 4:10 p.m.)
Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
Repository: mesos
Description
-------
This provides easy lookup.
Also refactored related functions to take in `Framework&`
instead of `FrameworkId&`.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.hpp 035fd3d7892d4280e299a29f99e8cf6a4c2afb30
src/master/allocator/mesos/hierarchical.cpp b8b9241eae20691ed52c9b5759b17f88a0d8931f
Diff: https://reviews.apache.org/r/71301/diff/5/
Changes: https://reviews.apache.org/r/71301/diff/4-5/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 71301: Added a framework id field to the allocator
Framework struct.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71301/#review217335
-----------------------------------------------------------
src/master/allocator/mesos/hierarchical.cpp
Line 556 (original), 557 (patched)
<https://reviews.apache.org/r/71301/#comment304632>
Hmm... honestly, I didn't realize that this signature (and also `updateFramework()`'s) had the same issue for a long time (likely since the moment when the "id" field was added into `FrameworkInfo`).
Makes me wonder if we can change these signatures.
If we cannot - maybe it makes more sense to
`CHECK_EQ(frameworkInfo.id(), frameworkId);`
instead of
`CHECK(frameworkInfo.has_id()); CHECK(frameworkInfo.id().value() != "");` ?
- Andrei Sekretenko
On Aug. 16, 2019, 10:53 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71301/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2019, 10:53 p.m.)
>
>
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This provides easy lookup.
>
> Also refactored related functions to take in `Framework&`
> instead of `FrameworkId&`.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp 035fd3d7892d4280e299a29f99e8cf6a4c2afb30
> src/master/allocator/mesos/hierarchical.cpp b8b9241eae20691ed52c9b5759b17f88a0d8931f
>
>
> Diff: https://reviews.apache.org/r/71301/diff/4/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 71301: Added a framework id field to the allocator
Framework struct.
Posted by Meng Zhu <mz...@mesosphere.io>.
> On Aug. 19, 2019, 7 a.m., Andrei Sekretenko wrote:
> > src/master/allocator/mesos/hierarchical.hpp
> > Lines 83 (patched)
> > <https://reviews.apache.org/r/71301/diff/3/?file=2161236#file2161236line83>
> >
> > What is wrong with `FrameworkInfo.id()`? Do we really need a separate parameter for an id?
Removed the parameter and added a check ensure `FrameworkInfo` from master has id set.
- Meng
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71301/#review217290
-----------------------------------------------------------
On Aug. 16, 2019, 3:53 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71301/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2019, 3:53 p.m.)
>
>
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This provides easy lookup.
>
> Also refactored related functions to take in `Framework&`
> instead of `FrameworkId&`.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp 035fd3d7892d4280e299a29f99e8cf6a4c2afb30
> src/master/allocator/mesos/hierarchical.cpp b8b9241eae20691ed52c9b5759b17f88a0d8931f
>
>
> Diff: https://reviews.apache.org/r/71301/diff/4/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 71301: Added a framework id field to the allocator
Framework struct.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71301/#review217290
-----------------------------------------------------------
src/master/allocator/mesos/hierarchical.hpp
Lines 83 (patched)
<https://reviews.apache.org/r/71301/#comment304582>
What is wrong with `FrameworkInfo.id()`? Do we really need a separate parameter for an id?
- Andrei Sekretenko
On Aug. 16, 2019, 10:53 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71301/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2019, 10:53 p.m.)
>
>
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This provides easy lookup.
>
> Also refactored related functions to take in `Framework&`
> instead of `FrameworkId&`.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp 8be8dcee04e8fc5b97f730b2f058d14c81678788
> src/master/allocator/mesos/hierarchical.cpp 580d35a3b71c1f7e851fa0504c6b9f037c05c378
>
>
> Diff: https://reviews.apache.org/r/71301/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>