You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by ur...@apache.org on 2026/09/06 15:26:21 UTC
(spark) branch master updated: [MINOR][SQL] Remove stale "Hash is not implemented" comment for nanosecond timestamp physical types
This is an automated email from the ASF dual-hosted git repository.
uros-b pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new ea926c075cef [MINOR][SQL] Remove stale "Hash is not implemented" comment for nanosecond timestamp physical types
ea926c075cef is described below
commit ea926c075cefc6239734ccacdb52c076b9180654
Author: Stevo Mitric <st...@gmail.com>
AuthorDate: Sun Sep 6 15:25:55 2026 +0000
[MINOR][SQL] Remove stale "Hash is not implemented" comment for nanosecond timestamp physical types
### What changes were proposed in this pull request?
Delete the obsolete scaladoc line from PhysicalTimestampNTZNanosType and PhysicalTimestampLTZNanosType. Hashing for the nanosecond carrier (TimestampNanosVal.hashCode) is implemented and is used by hash aggregate/join, DISTINCT, and set membership, so the "Hash is not implemented yet" note is false and misleading.
### Why are the changes needed?
Update the scaladocs.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Linter.
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes #58546 from stevomitric/stevomitric/nanos-remove-stale-hash-comment.
Authored-by: Stevo Mitric <st...@gmail.com>
Signed-off-by: Uros Bojanic <22...@users.noreply.github.com>
---
.../scala/org/apache/spark/sql/catalyst/types/PhysicalDataType.scala | 4 ----
1 file changed, 4 deletions(-)
diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/types/PhysicalDataType.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/types/PhysicalDataType.scala
index d77da0b159af..10ab70453cee 100644
--- a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/types/PhysicalDataType.scala
+++ b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/types/PhysicalDataType.scala
@@ -174,8 +174,6 @@ case object PhysicalCalendarIntervalType extends PhysicalCalendarIntervalType
*
* Storage layout is identical to [[PhysicalTimestampLTZNanosType]]; both types exist so the
* NTZ/LTZ distinction propagates through the physical-type system to consumers that need it.
- *
- * Hash is not implemented yet and will be added in a follow-up issue.
*/
class PhysicalTimestampNTZNanosType() extends PhysicalDataType {
override private[sql] type InternalType = TimestampNanosVal
@@ -192,8 +190,6 @@ case object PhysicalTimestampNTZNanosType extends PhysicalTimestampNTZNanosType
*
* Storage layout is identical to [[PhysicalTimestampNTZNanosType]]; both types exist so the
* NTZ/LTZ distinction propagates through the physical-type system to consumers that need it.
- *
- * Hash is not implemented yet and will be added in a follow-up issue.
*/
class PhysicalTimestampLTZNanosType() extends PhysicalDataType {
override private[sql] type InternalType = TimestampNanosVal
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org