You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/12/29 07:51:03 UTC
[GitHub] [iotdb] SpriCoder opened a new pull request, #8662: [To rel/1.0][IOTDB-5253] Fix chunkMetadata mem metric
SpriCoder opened a new pull request, #8662:
URL: https://github.com/apache/iotdb/pull/8662
https://issues.apache.org/jira/browse/IOTDB-5253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] OneSizeFitsQuorum merged pull request #8662: [To rel/1.0][IOTDB-5253] Fix chunkMetadata mem metric
Posted by GitBox <gi...@apache.org>.
OneSizeFitsQuorum merged PR #8662:
URL: https://github.com/apache/iotdb/pull/8662
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] OneSizeFitsQuorum commented on a diff in pull request #8662: [To rel/1.0][IOTDB-5253] Fix chunkMetadata mem metric
Posted by GitBox <gi...@apache.org>.
OneSizeFitsQuorum commented on code in PR #8662:
URL: https://github.com/apache/iotdb/pull/8662#discussion_r1059828077
##########
server/src/main/java/org/apache/iotdb/db/engine/storagegroup/TsFileProcessorInfoMetrics.java:
##########
@@ -64,11 +65,12 @@ public boolean equals(Object o) {
if (this == o) return true;
if (o == null || getClass() != o.getClass()) return false;
TsFileProcessorInfoMetrics that = (TsFileProcessorInfoMetrics) o;
- return memCost == that.memCost && Objects.equals(storageGroupName, that.storageGroupName);
+ return Objects.equals(storageGroupName, that.storageGroupName)
Review Comment:
Do we need to override the equal and hashcode of TsFileProcessorInfo?
##########
server/src/main/java/org/apache/iotdb/db/engine/storagegroup/TsFileProcessorInfoMetrics.java:
##########
@@ -64,11 +65,12 @@ public boolean equals(Object o) {
if (this == o) return true;
if (o == null || getClass() != o.getClass()) return false;
TsFileProcessorInfoMetrics that = (TsFileProcessorInfoMetrics) o;
- return memCost == that.memCost && Objects.equals(storageGroupName, that.storageGroupName);
+ return Objects.equals(storageGroupName, that.storageGroupName)
+ && Objects.equals(tsFileProcessorInfo, that.tsFileProcessorInfo);
}
@Override
public int hashCode() {
- return Objects.hash(storageGroupName, memCost);
+ return Objects.hash(storageGroupName, tsFileProcessorInfo);
Review Comment:
same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SpriCoder commented on a diff in pull request #8662: [To rel/1.0][IOTDB-5253] Fix chunkMetadata mem metric
Posted by GitBox <gi...@apache.org>.
SpriCoder commented on code in PR #8662:
URL: https://github.com/apache/iotdb/pull/8662#discussion_r1059843691
##########
server/src/main/java/org/apache/iotdb/db/engine/storagegroup/TsFileProcessorInfoMetrics.java:
##########
@@ -64,11 +65,12 @@ public boolean equals(Object o) {
if (this == o) return true;
if (o == null || getClass() != o.getClass()) return false;
TsFileProcessorInfoMetrics that = (TsFileProcessorInfoMetrics) o;
- return memCost == that.memCost && Objects.equals(storageGroupName, that.storageGroupName);
+ return Objects.equals(storageGroupName, that.storageGroupName)
+ && Objects.equals(tsFileProcessorInfo, that.tsFileProcessorInfo);
}
@Override
public int hashCode() {
- return Objects.hash(storageGroupName, memCost);
+ return Objects.hash(storageGroupName, tsFileProcessorInfo);
Review Comment:
fixed~
##########
server/src/main/java/org/apache/iotdb/db/engine/storagegroup/TsFileProcessorInfoMetrics.java:
##########
@@ -64,11 +65,12 @@ public boolean equals(Object o) {
if (this == o) return true;
if (o == null || getClass() != o.getClass()) return false;
TsFileProcessorInfoMetrics that = (TsFileProcessorInfoMetrics) o;
- return memCost == that.memCost && Objects.equals(storageGroupName, that.storageGroupName);
+ return Objects.equals(storageGroupName, that.storageGroupName)
Review Comment:
fixed~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org