You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/04/19 12:20:30 UTC

[GitHub] [druid] abhishekagarwal87 commented on a diff in pull request #12445: Fixes GCS based ingestion

abhishekagarwal87 commented on code in PR #12445:
URL: https://github.com/apache/druid/pull/12445#discussion_r852991169


##########
core/src/main/java/org/apache/druid/data/input/impl/CloudObjectLocation.java:
##########
@@ -71,7 +71,7 @@ public CloudObjectLocation(@JsonProperty("bucket") String bucket, @JsonProperty(
 
   public CloudObjectLocation(URI uri)
   {
-    this(uri.getHost(), uri.getPath());
+    this(uri.getAuthority(), uri.getPath());

Review Comment:
   should we fall back to authority only if getHost() returns null? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org