[GitHub] [calcite] xndai commented on a change in pull request #1567: [CALCITE-3479] Stack overflow error thrown when running join query

[GitBox <gi...@apache.org>]

xndai commented on a change in pull request #1567: [CALCITE-3479] Stack overflow error thrown when running join query
URL: https://github.com/apache/calcite/pull/1567#discussion_r343937109
 
 

 ##########
 File path: core/src/test/java/org/apache/calcite/test/ScannableTableTest.java
 ##########
 @@ -445,6 +469,20 @@ protected ConnectionPostProcessor newSchema(final String schemaName,
     };
   }
 
+  protected ConnectionPostProcessor newSchema(final String schemaName,
+                                                     final String tableName1, final Table table1,
+                                                     final String tableName2, final Table table2) {
+    return connection -> {
+      CalciteConnection con = connection.unwrap(CalciteConnection.class);
+      SchemaPlus rootSchema = con.getRootSchema();
+      SchemaPlus schema = rootSchema.add(schemaName, new AbstractSchema());
+      schema.add(tableName1, table1);
 
 Review comment:
   That's good idea.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services