[openmeetings] branch master updated: [OPENMEETINGS-2239] some sonar issues

[so...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

solomax pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openmeetings.git


The following commit(s) were added to refs/heads/master by this push:
     new ef105b6  [OPENMEETINGS-2239] some sonar issues
ef105b6 is described below

commit ef105b6704146b81bf702451d7f8652f97a82ed1
Author: Maxim Solodovnik <so...@gmail.com>
AuthorDate: Wed Oct 14 20:09:28 2020 +0700

    [OPENMEETINGS-2239] some sonar issues
---
 .../main/java/org/apache/openmeetings/db/dao/room/SipDao.java    | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/openmeetings-db/src/main/java/org/apache/openmeetings/db/dao/room/SipDao.java b/openmeetings-db/src/main/java/org/apache/openmeetings/db/dao/room/SipDao.java
index c41fdc6..5f8b2f5 100644
--- a/openmeetings-db/src/main/java/org/apache/openmeetings/db/dao/room/SipDao.java
+++ b/openmeetings-db/src/main/java/org/apache/openmeetings/db/dao/room/SipDao.java
@@ -89,7 +89,7 @@ public class SipDao implements SipListenerExt {
 	public static final String SIP_FIRST_NAME = "SIP Transport";
 	public static final String SIP_USER_NAME = "--SIP--";
 	private static final String SIP_TRANSPORT = "ws";
-	private static final <T> Consumer<T> NOOP() {
+	private static final <T> Consumer<T> noop() {
 		return t -> {};
 	}
 
@@ -100,7 +100,6 @@ public class SipDao implements SipListenerExt {
 	private String branch;
 
 	private SipProvider sipProvider;
-	private SipFactory sipFactory;
 	private SipStackExt sipStack;
 	private MessageFactory messageFactory;
 	private HeaderFactory headerFactory;
@@ -119,7 +118,7 @@ public class SipDao implements SipListenerExt {
 					, config.getManagerPort()
 					, config.getManagerUser()
 					, config.getManagerPass());
-			sipFactory = SipFactory.getInstance();
+			final SipFactory sipFactory = SipFactory.getInstance();
 			sipFactory.setPathName("gov.nist");
 
 			final Properties properties = new Properties();
@@ -356,7 +355,7 @@ public class SipDao implements SipListenerExt {
 	}
 
 	private Address createAddr(String user) {
-		return createAddr(user, config.getSipHostname(), NOOP());
+		return createAddr(user, config.getSipHostname(), noop());
 	}
 
 	private Address createAddr(String user, String host, Consumer<SipUri> cons) {
@@ -437,7 +436,7 @@ public class SipDao implements SipListenerExt {
 		sendRequest(
 				REGISTER
 				, config.getOmSipUser()
-				, NOOP()
+				, noop()
 				, req -> {
 					try {
 						addAllow(req);