You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@weex.apache.org by sospartan <gi...@git.apache.org> on 2017/03/06 08:54:15 UTC
[GitHub] incubator-weex pull request #37: * [android] use a dom for destroy , avoid N...
GitHub user sospartan opened a pull request:
https://github.com/apache/incubator-weex/pull/37
* [android] use a dom for destroy , avoid NPE after component destroyed.
Use a placeholder object for component's dom after destory.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sospartan/incubator-weex 0.11-dev-fix-getdomojb-nullable
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/37.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #37
----
commit 7af22d393f0b96ea55d2a3b0f3b9d14803dc6087
Author: sospartan <so...@gmail.com>
Date: 2017-03-06T08:47:34Z
* [android] use a dom for destroy , avoid NPE after component destroyed.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #37: * [android] use a dom for destroy , avoid N...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/37
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #37: * [android] use a dom for destroy , avoid NPE afte...
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/37
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true" data-kind="Warning">
3 Warnings
</th>
</tr>
</thead>
<tbody>
<tr>
<td>:warning:</td>
<td data-sticky="false"><strong><a href="https://github.com/sospartan/incubator-weex/blob/7af22d393f0b96ea55d2a3b0f3b9d14803dc6087/ios/sdk/WeexSDKTests/WXStorageTests.m#L123">ios/sdk/WeexSDKTests/WXStorageTests.m#L123</a></strong>: unused variable \u2018tsNow\u2019 [-Wunused-variable] <br /><code>
NSTimeInterval tsNow = [[NSDate date] timeIntervalSince1970];
</code></td>
</tr>
<tr>
<td>:warning:</td>
<td data-sticky="false"><strong><a href="https://github.com/sospartan/incubator-weex/blob/7af22d393f0b96ea55d2a3b0f3b9d14803dc6087/ios/sdk/WeexSDKTests/WXStorageTests.m#L227">ios/sdk/WeexSDKTests/WXStorageTests.m#L227</a></strong>: unused variable \u2018tsNow\u2019 [-Wunused-variable] <br /><code>
NSTimeInterval tsNow = [[NSDate date] timeIntervalSince1970];
</code></td>
</tr>
<tr>
<td>:warning:</td>
<td data-sticky="false"><strong><a href="https://github.com/sospartan/incubator-weex/blob/7af22d393f0b96ea55d2a3b0f3b9d14803dc6087/ios/sdk/WeexSDKTests/WXStorageTests.m#L228">ios/sdk/WeexSDKTests/WXStorageTests.m#L228</a></strong>: unused variable \u2018ts\u2019 [-Wunused-variable] <br /><code>
NSTimeInterval ts = [infoDic[@"key4"][@"ts"] doubleValue];
</code></td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true" data-kind="Message">
1 Message
</th>
</tr>
</thead>
<tbody>
<tr>
<td>:book:</td>
<td data-sticky="false">Executed 53 tests, with 0 failures (0 unexpected) in 75.554 (75.900) seconds</td>
</tr>
</tbody>
</table>
<p align="right" data-meta="generated_by_danger">
Generated by :no_entry_sign: <a href="http://danger.systems/">danger</a>
</p>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---