You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/11/21 16:43:52 UTC

[GitHub] [shardingsphere] terrymanu commented on a change in pull request #8275: Update the sub class ShardingCTLExplainBackendHandler of TextProtocolBackendHandler

terrymanu commented on a change in pull request #8275:
URL: https://github.com/apache/shardingsphere/pull/8275#discussion_r528216313



##########
File path: shardingsphere-proxy/shardingsphere-proxy-backend/src/test/java/org/apache/shardingsphere/proxy/backend/text/sctl/explain/ShardingCTLExplainBackendHandlerTest.java
##########
@@ -74,6 +75,6 @@ public void setUp() throws IllegalAccessException, NoSuchFieldException {
     public void assertGetRowData() {
         handler.execute();
         assertTrue(handler.next());
-        assertThat(handler.getRowData().get(1), is("select 1"));
+        assertThat(((List) handler.getRowData()).get(1), is("select 1"));

Review comment:
       Could you use iterator to instead of cast to List for assertion?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org