You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/10/17 00:48:25 UTC
[GitHub] [pinot] richardstartin opened a new pull request #7582: allow rle compression of bitmaps for smaller file sizes
richardstartin opened a new pull request #7582:
URL: https://github.com/apache/pinot/pull/7582
## Description
This saves uses the default settings in the RoaringBitmap library to produce smaller file sizes.
before:
```
Benchmark (_assignment) (_cardinality) (_numDocs) Mode Cnt Score Error Units
BenchmarkOffheapBitmapInvertedIndexCreator.seal ROUND_ROBIN 10 1000000 ss 5 0.015 ± 0.004 s/op
BenchmarkOffheapBitmapInvertedIndexCreator.seal:b ROUND_ROBIN 10 1000000 ss 5 6320620.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:kb ROUND_ROBIN 10 1000000 ss 5 6170.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:mb ROUND_ROBIN 10 1000000 ss 5 5.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal ROUND_ROBIN 10 10000000 ss 5 0.148 ± 0.018 s/op
BenchmarkOffheapBitmapInvertedIndexCreator.seal:b ROUND_ROBIN 10 10000000 ss 5 62706300.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:kb ROUND_ROBIN 10 10000000 ss 5 61235.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:mb ROUND_ROBIN 10 10000000 ss 5 55.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal ROUND_ROBIN 10 100000000 ss 5 1.562 ± 0.030 s/op
BenchmarkOffheapBitmapInvertedIndexCreator.seal:b ROUND_ROBIN 10 100000000 ss 5 625660620.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:kb ROUND_ROBIN 10 100000000 ss 5 610995.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:mb ROUND_ROBIN 10 100000000 ss 5 595.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal ROUND_ROBIN 1000 1000000 ss 5 0.020 ± 0.008 s/op
BenchmarkOffheapBitmapInvertedIndexCreator.seal:b ROUND_ROBIN 1000 1000000 ss 5 10700020.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:kb ROUND_ROBIN 1000 1000000 ss 5 10445.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:mb ROUND_ROBIN 1000 1000000 ss 5 10.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal ROUND_ROBIN 1000 10000000 ss 5 0.147 ± 0.010 s/op
BenchmarkOffheapBitmapInvertedIndexCreator.seal:b ROUND_ROBIN 1000 10000000 ss 5 106180020.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:kb ROUND_ROBIN 1000 10000000 ss 5 103690.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:mb ROUND_ROBIN 1000 10000000 ss 5 100.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal ROUND_ROBIN 1000 100000000 ss 5 1.708 ± 0.074 s/op
BenchmarkOffheapBitmapInvertedIndexCreator.seal:b ROUND_ROBIN 1000 100000000 ss 5 1061100020.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:kb ROUND_ROBIN 1000 100000000 ss 5 1036230.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:mb ROUND_ROBIN 1000 100000000 ss 5 1010.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal ROUND_ROBIN 10000 1000000 ss 5 0.030 ± 0.032 s/op
BenchmarkOffheapBitmapInvertedIndexCreator.seal:b ROUND_ROBIN 10000 1000000 ss 5 17000020.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:kb ROUND_ROBIN 10000 1000000 ss 5 16600.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:mb ROUND_ROBIN 10000 1000000 ss 5 15.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal ROUND_ROBIN 10000 10000000 ss 5 0.210 ± 0.025 s/op
BenchmarkOffheapBitmapInvertedIndexCreator.seal:b ROUND_ROBIN 10000 10000000 ss 5 161800020.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:kb ROUND_ROBIN 10000 10000000 ss 5 158005.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:mb ROUND_ROBIN 10000 10000000 ss 5 150.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal ROUND_ROBIN 10000 100000000 ss 5 2.226 ± 0.327 s/op
BenchmarkOffheapBitmapInvertedIndexCreator.seal:b ROUND_ROBIN 10000 100000000 ss 5 1611000020.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:kb ROUND_ROBIN 10000 100000000 ss 5 1573240.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:mb ROUND_ROBIN 10000 100000000 ss 5 1535.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal SORTED_UNIFORM 10 1000000 ss 5 0.019 ± 0.012 s/op
BenchmarkOffheapBitmapInvertedIndexCreator.seal:b SORTED_UNIFORM 10 1000000 ss 5 1018580.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:kb SORTED_UNIFORM 10 1000000 ss 5 990.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:mb SORTED_UNIFORM 10 1000000 ss 5 ≈ 0 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal SORTED_UNIFORM 10 10000000 ss 5 0.123 ± 0.023 s/op
BenchmarkOffheapBitmapInvertedIndexCreator.seal:b SORTED_UNIFORM 10 10000000 ss 5 6624700.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:kb SORTED_UNIFORM 10 10000000 ss 5 6465.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:mb SORTED_UNIFORM 10 10000000 ss 5 5.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal SORTED_UNIFORM 10 100000000 ss 5 1.299 ± 0.148 s/op
BenchmarkOffheapBitmapInvertedIndexCreator.seal:b SORTED_UNIFORM 10 100000000 ss 5 62934340.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:kb SORTED_UNIFORM 10 100000000 ss 5 61455.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:mb SORTED_UNIFORM 10 100000000 ss 5 60.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal SORTED_UNIFORM 1000 1000000 ss 5 0.018 ± 0.009 s/op
BenchmarkOffheapBitmapInvertedIndexCreator.seal:b SORTED_UNIFORM 1000 1000000 ss 5 10100620.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:kb SORTED_UNIFORM 1000 1000000 ss 5 9860.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:mb SORTED_UNIFORM 1000 1000000 ss 5 5.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal SORTED_UNIFORM 1000 10000000 ss 5 0.137 ± 0.020 s/op
BenchmarkOffheapBitmapInvertedIndexCreator.seal:b SORTED_UNIFORM 1000 10000000 ss 5 44750580.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:kb SORTED_UNIFORM 1000 10000000 ss 5 43700.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:mb SORTED_UNIFORM 1000 10000000 ss 5 40.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal SORTED_UNIFORM 1000 100000000 ss 5 1.321 ± 0.023 s/op
BenchmarkOffheapBitmapInvertedIndexCreator.seal:b SORTED_UNIFORM 1000 100000000 ss 5 101056060.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:kb SORTED_UNIFORM 1000 100000000 ss 5 98685.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:mb SORTED_UNIFORM 1000 100000000 ss 5 95.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal SORTED_UNIFORM 10000 1000000 ss 5 0.023 ± 0.014 s/op
BenchmarkOffheapBitmapInvertedIndexCreator.seal:b SORTED_UNIFORM 10000 1000000 ss 5 11000620.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:kb SORTED_UNIFORM 10000 1000000 ss 5 10740.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:mb SORTED_UNIFORM 10000 1000000 ss 5 10.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal SORTED_UNIFORM 10000 10000000 ss 5 0.147 ± 0.017 s/op
BenchmarkOffheapBitmapInvertedIndexCreator.seal:b SORTED_UNIFORM 10000 10000000 ss 5 101006060.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:kb SORTED_UNIFORM 10000 10000000 ss 5 98635.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:mb SORTED_UNIFORM 10000 10000000 ss 5 95.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal SORTED_UNIFORM 10000 100000000 ss 5 1.438 ± 0.020 s/op
BenchmarkOffheapBitmapInvertedIndexCreator.seal:b SORTED_UNIFORM 10000 100000000 ss 5 447554380.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:kb SORTED_UNIFORM 10000 100000000 ss 5 437060.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:mb SORTED_UNIFORM 10000 100000000 ss 5 425.000 #
```
after:
```
Benchmark (_assignment) (_cardinality) (_numDocs) Mode Cnt Score Error Units
BenchmarkOffheapBitmapInvertedIndexCreator.seal ROUND_ROBIN 10 1000000 ss 5 0.015 ± 0.003 s/op
BenchmarkOffheapBitmapInvertedIndexCreator.seal:b ROUND_ROBIN 10 1000000 ss 5 6320620.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:kb ROUND_ROBIN 10 1000000 ss 5 6170.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:mb ROUND_ROBIN 10 1000000 ss 5 5.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal ROUND_ROBIN 10 10000000 ss 5 0.150 ± 0.024 s/op
BenchmarkOffheapBitmapInvertedIndexCreator.seal:b ROUND_ROBIN 10 10000000 ss 5 62706300.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:kb ROUND_ROBIN 10 10000000 ss 5 61235.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:mb ROUND_ROBIN 10 10000000 ss 5 55.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal ROUND_ROBIN 10 100000000 ss 5 1.535 ± 0.061 s/op
BenchmarkOffheapBitmapInvertedIndexCreator.seal:b ROUND_ROBIN 10 100000000 ss 5 625660620.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:kb ROUND_ROBIN 10 100000000 ss 5 610995.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:mb ROUND_ROBIN 10 100000000 ss 5 595.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal ROUND_ROBIN 1000 1000000 ss 5 0.020 ± 0.011 s/op
BenchmarkOffheapBitmapInvertedIndexCreator.seal:b ROUND_ROBIN 1000 1000000 ss 5 10700020.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:kb ROUND_ROBIN 1000 1000000 ss 5 10445.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:mb ROUND_ROBIN 1000 1000000 ss 5 10.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal ROUND_ROBIN 1000 10000000 ss 5 0.199 ± 0.097 s/op
BenchmarkOffheapBitmapInvertedIndexCreator.seal:b ROUND_ROBIN 1000 10000000 ss 5 106180020.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:kb ROUND_ROBIN 1000 10000000 ss 5 103690.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:mb ROUND_ROBIN 1000 10000000 ss 5 100.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal ROUND_ROBIN 1000 100000000 ss 5 1.960 ± 0.292 s/op
BenchmarkOffheapBitmapInvertedIndexCreator.seal:b ROUND_ROBIN 1000 100000000 ss 5 1061100020.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:kb ROUND_ROBIN 1000 100000000 ss 5 1036230.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:mb ROUND_ROBIN 1000 100000000 ss 5 1010.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal ROUND_ROBIN 10000 1000000 ss 5 0.029 ± 0.008 s/op
BenchmarkOffheapBitmapInvertedIndexCreator.seal:b ROUND_ROBIN 10000 1000000 ss 5 17000020.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:kb ROUND_ROBIN 10000 1000000 ss 5 16600.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:mb ROUND_ROBIN 10000 1000000 ss 5 15.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal ROUND_ROBIN 10000 10000000 ss 5 0.249 ± 0.042 s/op
BenchmarkOffheapBitmapInvertedIndexCreator.seal:b ROUND_ROBIN 10000 10000000 ss 5 161800020.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:kb ROUND_ROBIN 10000 10000000 ss 5 158005.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:mb ROUND_ROBIN 10000 10000000 ss 5 150.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal ROUND_ROBIN 10000 100000000 ss 5 2.294 ± 0.094 s/op
BenchmarkOffheapBitmapInvertedIndexCreator.seal:b ROUND_ROBIN 10000 100000000 ss 5 1611000020.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:kb ROUND_ROBIN 10000 100000000 ss 5 1573240.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:mb ROUND_ROBIN 10000 100000000 ss 5 1535.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal SORTED_UNIFORM 10 1000000 ss 5 0.013 ± 0.003 s/op
BenchmarkOffheapBitmapInvertedIndexCreator.seal:b SORTED_UNIFORM 10 1000000 ss 5 1720.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:kb SORTED_UNIFORM 10 1000000 ss 5 ≈ 0 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:mb SORTED_UNIFORM 10 1000000 ss 5 ≈ 0 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal SORTED_UNIFORM 10 10000000 ss 5 0.121 ± 0.041 s/op
BenchmarkOffheapBitmapInvertedIndexCreator.seal:b SORTED_UNIFORM 10 10000000 ss 5 11870.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:kb SORTED_UNIFORM 10 10000000 ss 5 10.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:mb SORTED_UNIFORM 10 10000000 ss 5 ≈ 0 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal SORTED_UNIFORM 10 100000000 ss 5 1.320 ± 0.055 s/op
BenchmarkOffheapBitmapInvertedIndexCreator.seal:b SORTED_UNIFORM 10 100000000 ss 5 108870.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:kb SORTED_UNIFORM 10 100000000 ss 5 105.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:mb SORTED_UNIFORM 10 100000000 ss 5 ≈ 0 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal SORTED_UNIFORM 1000 1000000 ss 5 0.019 ± 0.014 s/op
BenchmarkOffheapBitmapInvertedIndexCreator.seal:b SORTED_UNIFORM 1000 1000000 ss 5 95770.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:kb SORTED_UNIFORM 1000 1000000 ss 5 90.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:mb SORTED_UNIFORM 1000 1000000 ss 5 ≈ 0 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal SORTED_UNIFORM 1000 10000000 ss 5 0.140 ± 0.026 s/op
BenchmarkOffheapBitmapInvertedIndexCreator.seal:b SORTED_UNIFORM 1000 10000000 ss 5 102620.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:kb SORTED_UNIFORM 1000 10000000 ss 5 100.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:mb SORTED_UNIFORM 1000 10000000 ss 5 ≈ 0 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal SORTED_UNIFORM 1000 100000000 ss 5 1.428 ± 0.222 s/op
BenchmarkOffheapBitmapInvertedIndexCreator.seal:b SORTED_UNIFORM 1000 100000000 ss 5 171270.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:kb SORTED_UNIFORM 1000 100000000 ss 5 165.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:mb SORTED_UNIFORM 1000 100000000 ss 5 ≈ 0 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal SORTED_UNIFORM 10000 1000000 ss 5 0.017 ± 0.003 s/op
BenchmarkOffheapBitmapInvertedIndexCreator.seal:b SORTED_UNIFORM 10000 1000000 ss 5 950770.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:kb SORTED_UNIFORM 10000 1000000 ss 5 925.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:mb SORTED_UNIFORM 10000 1000000 ss 5 ≈ 0 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal SORTED_UNIFORM 10000 10000000 ss 5 0.145 ± 0.023 s/op
BenchmarkOffheapBitmapInvertedIndexCreator.seal:b SORTED_UNIFORM 10000 10000000 ss 5 957570.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:kb SORTED_UNIFORM 10000 10000000 ss 5 935.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:mb SORTED_UNIFORM 10000 10000000 ss 5 ≈ 0 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal SORTED_UNIFORM 10000 100000000 ss 5 1.432 ± 0.066 s/op
BenchmarkOffheapBitmapInvertedIndexCreator.seal:b SORTED_UNIFORM 10000 100000000 ss 5 1026170.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:kb SORTED_UNIFORM 10000 100000000 ss 5 1000.000 #
BenchmarkOffheapBitmapInvertedIndexCreator.seal:mb SORTED_UNIFORM 10000 100000000 ss 5 ≈ 0 #
```
Pinot wouldn't create an inverted index on a sorted column, but doesn't track correlations between columns, and RLE is effective when a column is partially sorted, so in general, this will lead to much smaller inverted index files.
## Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
* [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete the section below on Release Notes)
Does this PR fix a zero-downtime upgrade introduced earlier?
* [ ] Yes (Please label this as **<code>backward-incompat</code>**, and complete the section below on Release Notes)
Does this PR otherwise need attention when creating release notes? Things to consider:
- New configuration options
- Deprecation of configurations
- Signature changes to public methods/interfaces
- New plugins added or old plugins removed
* [ ] Yes (Please label this PR as **<code>release-notes</code>** and complete the section on Release Notes)
## Release Notes
<!-- If you have tagged this as either backward-incompat or release-notes,
you MUST add text here that you would like to see appear in release notes of the
next release. -->
<!-- If you have a series of commits adding or enabling a feature, then
add this section only in final commit that marks the feature completed.
Refer to earlier release notes to see examples of text.
-->
## Documentation
<!-- If you have introduced a new feature or configuration, please add it to the documentation as well.
See https://docs.pinot.apache.org/developers/developers-and-contributors/update-document
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang merged pull request #7582: allow rle compression of bitmaps for smaller file sizes
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang merged pull request #7582:
URL: https://github.com/apache/pinot/pull/7582
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] kishoreg commented on pull request #7582: allow rle compression of bitmaps for smaller file sizes
Posted by GitBox <gi...@apache.org>.
kishoreg commented on pull request #7582:
URL: https://github.com/apache/pinot/pull/7582#issuecomment-944442453
that's a huge improvement when it's partially sorted!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #7582: allow rle compression of bitmaps for smaller file sizes
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #7582:
URL: https://github.com/apache/pinot/pull/7582#issuecomment-944401007
# [Codecov](https://codecov.io/gh/apache/pinot/pull/7582?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7582](https://codecov.io/gh/apache/pinot/pull/7582?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf846a3) into [master](https://codecov.io/gh/apache/pinot/commit/042119788f8af3cf22032895909245593bab0e1e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0421197) will **decrease** coverage by `56.84%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/pinot/pull/7582?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7582 +/- ##
=============================================
- Coverage 71.54% 14.69% -56.85%
+ Complexity 3886 80 -3806
=============================================
Files 1552 1506 -46
Lines 78974 77123 -1851
Branches 11709 11509 -200
=============================================
- Hits 56502 11337 -45165
- Misses 18670 64968 +46298
+ Partials 3802 818 -2984
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `?` | |
| integration2 | `?` | |
| unittests1 | `?` | |
| unittests2 | `14.69% <0.00%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/7582?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...or/impl/inv/OffHeapBitmapInvertedIndexCreator.java](https://codecov.io/gh/apache/pinot/pull/7582/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc2VnbWVudC1sb2NhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3Qvc2VnbWVudC9sb2NhbC9zZWdtZW50L2NyZWF0b3IvaW1wbC9pbnYvT2ZmSGVhcEJpdG1hcEludmVydGVkSW5kZXhDcmVhdG9yLmphdmE=) | `0.00% <0.00%> (-89.25%)` | :arrow_down: |
| [...tor/impl/inv/OnHeapBitmapInvertedIndexCreator.java](https://codecov.io/gh/apache/pinot/pull/7582/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc2VnbWVudC1sb2NhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3Qvc2VnbWVudC9sb2NhbC9zZWdtZW50L2NyZWF0b3IvaW1wbC9pbnYvT25IZWFwQml0bWFwSW52ZXJ0ZWRJbmRleENyZWF0b3IuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...nt/creator/impl/inv/json/BaseJsonIndexCreator.java](https://codecov.io/gh/apache/pinot/pull/7582/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc2VnbWVudC1sb2NhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3Qvc2VnbWVudC9sb2NhbC9zZWdtZW50L2NyZWF0b3IvaW1wbC9pbnYvanNvbi9CYXNlSnNvbkluZGV4Q3JlYXRvci5qYXZh) | `0.00% <0.00%> (-93.85%)` | :arrow_down: |
| [...c/main/java/org/apache/pinot/common/tier/Tier.java](https://codecov.io/gh/apache/pinot/pull/7582/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdGllci9UaWVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ain/java/org/apache/pinot/core/data/table/Key.java](https://codecov.io/gh/apache/pinot/pull/7582/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3RhYmxlL0tleS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../java/org/apache/pinot/spi/utils/BooleanUtils.java](https://codecov.io/gh/apache/pinot/pull/7582/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdXRpbHMvQm9vbGVhblV0aWxzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../java/org/apache/pinot/core/data/table/Record.java](https://codecov.io/gh/apache/pinot/pull/7582/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3RhYmxlL1JlY29yZC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../java/org/apache/pinot/core/util/GroupByUtils.java](https://codecov.io/gh/apache/pinot/pull/7582/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS91dGlsL0dyb3VwQnlVdGlscy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ava/org/apache/pinot/spi/data/MetricFieldSpec.java](https://codecov.io/gh/apache/pinot/pull/7582/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvZGF0YS9NZXRyaWNGaWVsZFNwZWMuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...va/org/apache/pinot/spi/utils/BigDecimalUtils.java](https://codecov.io/gh/apache/pinot/pull/7582/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdXRpbHMvQmlnRGVjaW1hbFV0aWxzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1226 more](https://codecov.io/gh/apache/pinot/pull/7582/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/pinot/pull/7582?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/pinot/pull/7582?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0421197...bf846a3](https://codecov.io/gh/apache/pinot/pull/7582?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] richardstartin commented on pull request #7582: allow rle compression of bitmaps for smaller file sizes
Posted by GitBox <gi...@apache.org>.
richardstartin commented on pull request #7582:
URL: https://github.com/apache/pinot/pull/7582#issuecomment-946086877
The cost is very small, but I don't think it's worth applying to transient bitmaps during queries. I left `BaseH3IndexCreator` alone because I don't want to benchmark it or take on responsibility for regressions in it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter edited a comment on pull request #7582: allow rle compression of bitmaps for smaller file sizes
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #7582:
URL: https://github.com/apache/pinot/pull/7582#issuecomment-944401007
# [Codecov](https://codecov.io/gh/apache/pinot/pull/7582?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7582](https://codecov.io/gh/apache/pinot/pull/7582?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b908b99) into [master](https://codecov.io/gh/apache/pinot/commit/042119788f8af3cf22032895909245593bab0e1e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0421197) will **decrease** coverage by `3.00%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head b908b99 differs from pull request most recent head bf846a3. Consider uploading reports for the commit bf846a3 to get more accurate results
[](https://codecov.io/gh/apache/pinot/pull/7582?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7582 +/- ##
============================================
- Coverage 71.54% 68.54% -3.01%
+ Complexity 3886 3802 -84
============================================
Files 1552 1157 -395
Lines 78974 56674 -22300
Branches 11709 8711 -2998
============================================
- Hits 56502 38847 -17655
+ Misses 18670 15072 -3598
+ Partials 3802 2755 -1047
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `?` | |
| integration2 | `?` | |
| unittests1 | `68.54% <100.00%> (-0.02%)` | :arrow_down: |
| unittests2 | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/7582?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...or/impl/inv/OffHeapBitmapInvertedIndexCreator.java](https://codecov.io/gh/apache/pinot/pull/7582/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc2VnbWVudC1sb2NhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3Qvc2VnbWVudC9sb2NhbC9zZWdtZW50L2NyZWF0b3IvaW1wbC9pbnYvT2ZmSGVhcEJpdG1hcEludmVydGVkSW5kZXhDcmVhdG9yLmphdmE=) | `89.24% <100.00%> (ø)` | |
| [...tor/impl/inv/OnHeapBitmapInvertedIndexCreator.java](https://codecov.io/gh/apache/pinot/pull/7582/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc2VnbWVudC1sb2NhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3Qvc2VnbWVudC9sb2NhbC9zZWdtZW50L2NyZWF0b3IvaW1wbC9pbnYvT25IZWFwQml0bWFwSW52ZXJ0ZWRJbmRleENyZWF0b3IuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...nt/creator/impl/inv/json/BaseJsonIndexCreator.java](https://codecov.io/gh/apache/pinot/pull/7582/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc2VnbWVudC1sb2NhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3Qvc2VnbWVudC9sb2NhbC9zZWdtZW50L2NyZWF0b3IvaW1wbC9pbnYvanNvbi9CYXNlSnNvbkluZGV4Q3JlYXRvci5qYXZh) | `93.84% <100.00%> (ø)` | |
| [...a/org/apache/pinot/common/metrics/MinionMeter.java](https://codecov.io/gh/apache/pinot/pull/7582/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9NaW5pb25NZXRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...g/apache/pinot/common/metrics/ControllerMeter.java](https://codecov.io/gh/apache/pinot/pull/7582/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9Db250cm9sbGVyTWV0ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../apache/pinot/common/metrics/BrokerQueryPhase.java](https://codecov.io/gh/apache/pinot/pull/7582/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9Ccm9rZXJRdWVyeVBoYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../apache/pinot/common/metrics/MinionQueryPhase.java](https://codecov.io/gh/apache/pinot/pull/7582/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9NaW5pb25RdWVyeVBoYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/pinot/common/messages/SegmentReloadMessage.java](https://codecov.io/gh/apache/pinot/pull/7582/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWVzc2FnZXMvU2VnbWVudFJlbG9hZE1lc3NhZ2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...pinot/core/data/manager/realtime/TimerService.java](https://codecov.io/gh/apache/pinot/pull/7582/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvVGltZXJTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...not/common/exception/HttpErrorStatusException.java](https://codecov.io/gh/apache/pinot/pull/7582/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZXhjZXB0aW9uL0h0dHBFcnJvclN0YXR1c0V4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [601 more](https://codecov.io/gh/apache/pinot/pull/7582/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/pinot/pull/7582?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/pinot/pull/7582?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0421197...bf846a3](https://codecov.io/gh/apache/pinot/pull/7582?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org