[jira] [Comment Edited] (YUNIKORN-1261) Helm upgrade does not detect changes in ConfigMap

["Craig Condit (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YUNIKORN-1261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17635953#comment-17635953 ] 

Craig Condit edited comment on YUNIKORN-1261 at 11/18/22 4:48 PM:
------------------------------------------------------------------

This is no longer relevant after the changes in YUNIKORN-1221. 

For background, YUNIKORN-1221 introduces a second configmap ({{{}yunikorn-defaults{}}}) which is no longer managed as a hook, but as a fully lifecycled entity. The existing configmap ({{{}yunikorn-configs{}}}), is no longer managed by Helm at all. This means that existing clusters will still have it, and the settings within will be preserved, but new installations will not, freeing up that configmap to be managed manually as an override list for {{{}yunikorn-defaults{}}}.

We ran into similar issues with the RBAC policies that are defined. Those also use pre-install hooks only, and one of them needed an update for 1.2.0. Fortunately, we don't need those to be mergeable, so adding pre-upgrade was fine in that case.

We should be very careful in the future about adding hooks to helm. We have abused them in the past and it makes upgrading really problematic, since once an object exists, it cannot be adopted by Helm without manual intervention.


was (Author: ccondit):
This is no longer relevant after the changes in YUNIKORN-1221.

> Helm upgrade does not detect changes in ConfigMap
> -------------------------------------------------
>
>                 Key: YUNIKORN-1261
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-1261
>             Project: Apache YuniKorn
>          Issue Type: Bug
>          Components: release
>    Affects Versions: 1.0.0
>            Reporter: Chaoran Yu
>            Assignee: Craig Condit
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.2.0
>
>
> For an existing Helm release of YuniKorn, when there's a change in the ConfigMap (e.g. new queue configurations) and the release is upgraded using the "helm upgrade" command, the ConfigMap doesn't get updated



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org