[GitHub] [incubator-superset] john-bodley commented on a change in pull request #8629: [SQL Lab] Wrap more logic with feature flag

[GitBox <gi...@apache.org>]

john-bodley commented on a change in pull request #8629: [SQL Lab] Wrap more logic with feature flag
URL: https://github.com/apache/incubator-superset/pull/8629#discussion_r349391489
 
 

 ##########
 File path: superset/views/core.py
 ##########
 @@ -3064,17 +3064,26 @@ def sqllab(self):
             .order_by(TabState.active.desc())
             .first()
         )
-        databases = {
-            database.id: {
-                k: v for k, v in database.to_json().items() if k in DATABASE_KEYS
+
+        databases = {}
+        queries = {}
+
+        # These are unnecessary if sqllab backend persistence is disabled
+        if is_feature_enabled("SQLLAB_BACKEND_PERSISTENCE"):
 
 Review comment:
   Merely an indentation. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org