You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/02/23 17:47:06 UTC
[GitHub] [commons-lang] arturobernalg opened a new pull request #717: Feature/not null or empty aux
arturobernalg opened a new pull request #717:
URL: https://github.com/apache/commons-lang/pull/717
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on a change in pull request #717: Feature/not null or empty aux
Posted by GitBox <gi...@apache.org>.
garydgregory commented on a change in pull request #717:
URL: https://github.com/apache/commons-lang/pull/717#discussion_r581430243
##########
File path: src/main/java/org/apache/commons/lang3/ObjectUtils.java
##########
@@ -1237,6 +1243,37 @@ public static String toString(final Object obj, final String nullStr) {
return obj == null ? nullStr : obj.toString();
}
+ /**
+ * <p>Validate that the specified argument object is neither {@code null}
+ * nor a length of zero (no elements); otherwise throwing an exception.
+ *
+ * <p>The message of the exception is "The object is null or empty".</p>
+ *
+ * @param object the object to check
+ *
+ * @throws IllegalArgumentException if {@code array} is {@code null}
+ * @throws IllegalArgumentException if {@code array} is empty.
+ */
Review comment:
Javadoc Add at since 3.12.0 for new public and protected APIs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory closed pull request #717: Feature/not null or empty aux
Posted by GitBox <gi...@apache.org>.
garydgregory closed pull request #717:
URL: https://github.com/apache/commons-lang/pull/717
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] arturobernalg commented on pull request #717: Feature/not null or empty aux
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on pull request #717:
URL: https://github.com/apache/commons-lang/pull/717#issuecomment-784571316
HI @garydgregory
Fix javadoc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] coveralls edited a comment on pull request #717: Feature/not null or empty aux
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #717:
URL: https://github.com/apache/commons-lang/pull/717#issuecomment-784398687
[](https://coveralls.io/builds/37399699)
Coverage decreased (-0.004%) to 94.915% when pulling **81107d4597583d4a93dd43fe6dded7aba35c1290 on arturobernalg:feature/not_null_or_empty_aux** into **b57f292cdf14fef72e68d60c580cb80d794be7e0 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] coveralls edited a comment on pull request #717: Feature/not null or empty aux
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #717:
URL: https://github.com/apache/commons-lang/pull/717#issuecomment-784398687
[](https://coveralls.io/builds/37391215)
Coverage decreased (-0.004%) to 94.957% when pulling **3bcf2b72f106d7bdf9ebf923bf698469c1e36279 on arturobernalg:feature/not_null_or_empty_aux** into **b03b21b4491567f0dbb1043d3e4156a51ffd5da0 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] coveralls edited a comment on pull request #717: Feature/not null or empty aux
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #717:
URL: https://github.com/apache/commons-lang/pull/717#issuecomment-784398687
[](https://coveralls.io/builds/37400553)
Coverage decreased (-0.004%) to 94.915% when pulling **793aaca0d5f541086719f8bd2b5269a50a4163e5 on arturobernalg:feature/not_null_or_empty_aux** into **b57f292cdf14fef72e68d60c580cb80d794be7e0 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] coveralls edited a comment on pull request #717: Feature/not null or empty aux
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #717:
URL: https://github.com/apache/commons-lang/pull/717#issuecomment-784398687
[](https://coveralls.io/builds/37400580)
Coverage decreased (-0.004%) to 94.915% when pulling **793aaca0d5f541086719f8bd2b5269a50a4163e5 on arturobernalg:feature/not_null_or_empty_aux** into **b57f292cdf14fef72e68d60c580cb80d794be7e0 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #717: Feature/not null or empty aux
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #717:
URL: https://github.com/apache/commons-lang/pull/717#issuecomment-785917849
Closing in favor of a different implementation in git master which mirror the style and names of java.lang.Objects.requireNon*() methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] coveralls edited a comment on pull request #717: Feature/not null or empty aux
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #717:
URL: https://github.com/apache/commons-lang/pull/717#issuecomment-784398687
[](https://coveralls.io/builds/37399729)
Coverage decreased (-0.004%) to 94.915% when pulling **81107d4597583d4a93dd43fe6dded7aba35c1290 on arturobernalg:feature/not_null_or_empty_aux** into **b57f292cdf14fef72e68d60c580cb80d794be7e0 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] coveralls commented on pull request #717: Feature/not null or empty aux
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #717:
URL: https://github.com/apache/commons-lang/pull/717#issuecomment-784398687
[](https://coveralls.io/builds/37381355)
Coverage decreased (-0.004%) to 94.957% when pulling **00c952898e37129a8a3f646149eab93ad5e15330 on arturobernalg:feature/not_null_or_empty_aux** into **b03b21b4491567f0dbb1043d3e4156a51ffd5da0 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on a change in pull request #717: Feature/not null or empty aux
Posted by GitBox <gi...@apache.org>.
garydgregory commented on a change in pull request #717:
URL: https://github.com/apache/commons-lang/pull/717#discussion_r581429641
##########
File path: src/main/java/org/apache/commons/lang3/ObjectUtils.java
##########
@@ -1237,6 +1243,37 @@ public static String toString(final Object obj, final String nullStr) {
return obj == null ? nullStr : obj.toString();
}
+ /**
+ * <p>Validate that the specified argument object is neither {@code null}
Review comment:
Please close HTML tags. The FIRST sentence in a Javadoc does not need to be in a paragraph, it is implied.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org