You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "Jefffrey (via GitHub)" <gi...@apache.org> on 2025/11/07 13:53:31 UTC
Re: [PR] refactor: update cmp and nested data in binary operator [datafusion]
Jefffrey commented on code in PR #18256:
URL: https://github.com/apache/datafusion/pull/18256#discussion_r2503667419
##########
datafusion/physical-expr-common/src/datum.rs:
##########
@@ -79,12 +109,18 @@ pub fn apply_cmp_for_nested(
| Operator::GtEq
| Operator::IsDistinctFrom
| Operator::IsNotDistinctFrom
- ) {
+ ) && left_data_type.equals_datatype(&right_data_type)
+ {
apply(lhs, rhs, |l, r| {
Ok(Arc::new(compare_op_for_nested(op, l, r)?))
})
} else {
- internal_err!("invalid operator for nested")
+ internal_err!(
+ "invalid operator for nested data, op {} left {}, right {}",
Review Comment:
At this point it could also be due to mismatched left/right types I believe, not just invalid operator?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org