You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/06/25 08:55:22 UTC

[GitHub] [pulsar] murong00 opened a new pull request #11094: [Issue 10579] Fix inputs to return a list of topic

murong00 opened a new pull request #11094:
URL: https://github.com/apache/pulsar/pull/11094


   ### Motivation
   
   Fixes #10579
   
   ### Modifications
   
   Add the list of topic in field `SinkConfig.inputs`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] murong00 commented on a change in pull request #11094: [Issue 10579] Fix inputs to return a list of topic

Posted by GitBox <gi...@apache.org>.
murong00 commented on a change in pull request #11094:
URL: https://github.com/apache/pulsar/pull/11094#discussion_r658693885



##########
File path: pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/SinkConfigUtils.java
##########
@@ -250,6 +250,7 @@ public static SinkConfig convertFromDetails(FunctionDetails functionDetails) {
         sinkConfig.setParallelism(functionDetails.getParallelism());
         sinkConfig.setProcessingGuarantees(FunctionCommon.convertProcessingGuarantee(functionDetails.getProcessingGuarantees()));
         Map<String, ConsumerConfig> consumerConfigMap = new HashMap<>();
+        List<String> inputs = new LinkedList<>();

Review comment:
       Sure, I will refine this later, thanks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli commented on a change in pull request #11094: [Issue 10579] Fix inputs to return a list of topic

Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #11094:
URL: https://github.com/apache/pulsar/pull/11094#discussion_r658684057



##########
File path: pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/SinkConfigUtils.java
##########
@@ -250,6 +250,7 @@ public static SinkConfig convertFromDetails(FunctionDetails functionDetails) {
         sinkConfig.setParallelism(functionDetails.getParallelism());
         sinkConfig.setProcessingGuarantees(FunctionCommon.convertProcessingGuarantee(functionDetails.getProcessingGuarantees()));
         Map<String, ConsumerConfig> consumerConfigMap = new HashMap<>();
+        List<String> inputs = new LinkedList<>();

Review comment:
       can we use ArrayList ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #11094: [Issue 10579] Fix inputs to return a list of topic

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #11094:
URL: https://github.com/apache/pulsar/pull/11094


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #11094: [Issue 10579] Fix inputs to return a list of topic

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #11094:
URL: https://github.com/apache/pulsar/pull/11094


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] murong00 commented on a change in pull request #11094: [Issue 10579] Fix inputs to return a list of topic

Posted by GitBox <gi...@apache.org>.
murong00 commented on a change in pull request #11094:
URL: https://github.com/apache/pulsar/pull/11094#discussion_r659410037



##########
File path: pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/SinkConfigUtils.java
##########
@@ -250,6 +250,7 @@ public static SinkConfig convertFromDetails(FunctionDetails functionDetails) {
         sinkConfig.setParallelism(functionDetails.getParallelism());
         sinkConfig.setProcessingGuarantees(FunctionCommon.convertProcessingGuarantee(functionDetails.getProcessingGuarantees()));
         Map<String, ConsumerConfig> consumerConfigMap = new HashMap<>();
+        List<String> inputs = new LinkedList<>();

Review comment:
       Done.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org