You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by romain-dartigues <gi...@git.apache.org> on 2016/05/18 21:39:26 UTC
[GitHub] cloudstack pull request: add DHCP lease folders for Ubuntu
GitHub user romain-dartigues opened a pull request:
https://github.com/apache/cloudstack/pull/1552
add DHCP lease folders for Ubuntu
Add "/var/lib/dhcp/*" to the search path for Ubuntu; tested under Ubuntu Precise and Trusty, not yet with newer releases.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/romain-dartigues/cloudstack feature_dhcp_ubuntu
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1552.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1552
----
commit 3bb70daeccbb96d77e04e15983ccee161ccbba4e
Author: Romain Dartigues <ro...@gmail.com>
Date: 2016-05-18T21:34:19Z
add DHCP lease folders for Ubuntu
Add "/var/lib/dhcp/*" to the search path for Ubuntu; tested under
Ubuntu Precise and Trusty, not yet with newer releases.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: add DHCP lease folders for Ubuntu
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1552
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: add DHCP lease folders for Ubuntu
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1552#issuecomment-221155776
Ok, so I have two LGTM both with validation that the code behaves as expected. I think that is enough for this to get in. Thanks...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: add DHCP lease folders for Ubuntu
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1552#issuecomment-220813347
Does this need CI?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: add DHCP lease folders for Ubuntu
Posted by syed <gi...@git.apache.org>.
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1552#issuecomment-220349481
Can cofirm the dhcp folder on Ubuntu Trusty LTS (14.04) LGTM.
```
$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu 14.04.1 LTS
Release: 14.04
Codename: trusty
$ls /var/lib/dhcp/
dhclient.leases
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: add DHCP lease folders for Ubuntu
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1552#issuecomment-220974370
@swill I don't think so, CI doesn't test this feature. It is a script for INSIDE Guest Instances.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: add DHCP lease folders for Ubuntu
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1552#issuecomment-220261024
Good catch! I can confirm that under Ubuntu 16.04 (Xenial) that is where the DHCP leases are stored.
<pre>root@example:~# lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu 16.04 LTS
Release: 16.04
Codename: xenial
root@example:~# ls /var/lib/dhcp/
dhclient.ens3.leases dhclient6.ens3.leases
root@example:~#</pre>
LGTM for me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---