You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/09/29 08:52:39 UTC

[GitHub] [netbeans] sdedic opened a new pull request #3197: FIx test failures in Groovy.editor

sdedic opened a new pull request #3197:
URL: https://github.com/apache/netbeans/pull/3197


   Merge of PR-3175 has introduced bugs - test failures. It turned out that in that PR merge process, I didn't check properly Travis :-/
   So this PR:
   * only suppresses errors after parsing phase. There is an 'error recovery' that handles errors thrown from the parsing. This bug failed some tests.
   * updates `BookmarkController.groovy.indexed` golden file: originally, the compiler failed on non-existent imported symbol and did not proceed to phase 6-7 where accessor methods are generated
   * used `IndexingTask` marker API to indicate indexing is in progress; groovy.editor will not run static analysis that may produce additional errors: this is the original behaviour.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] ebarboni edited a comment on pull request #3197: FIx test failures in Groovy.editor

Posted by GitBox <gi...@apache.org>.
ebarboni edited a comment on pull request #3197:
URL: https://github.com/apache/netbeans/pull/3197#issuecomment-929979102


   😍 thanks in advance, was looking for it but no idea what to do. 
   
   just made an edit to hyperlink PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] jlahoda commented on pull request #3197: FIx test failures in Groovy.editor

Posted by GitBox <gi...@apache.org>.
jlahoda commented on pull request #3197:
URL: https://github.com/apache/netbeans/pull/3197#issuecomment-930791030


   +1, thanks for doing this!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] sdedic commented on pull request #3197: FIx test failures in Groovy.editor

Posted by GitBox <gi...@apache.org>.
sdedic commented on pull request #3197:
URL: https://github.com/apache/netbeans/pull/3197#issuecomment-930276222


   OK ... I have such a mess on local from all the groovy experiments  that I'll do a clean checkout ;)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] ebarboni commented on pull request #3197: FIx test failures in Groovy.editor

Posted by GitBox <gi...@apache.org>.
ebarboni commented on pull request #3197:
URL: https://github.com/apache/netbeans/pull/3197#issuecomment-929979102


   😍 thanks in advance, was looking for it but no idea what to do. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] ebarboni edited a comment on pull request #3197: FIx test failures in Groovy.editor

Posted by GitBox <gi...@apache.org>.
ebarboni edited a comment on pull request #3197:
URL: https://github.com/apache/netbeans/pull/3197#issuecomment-929979102


   😍 thanks in advance, was looking for it but no idea what to do. 
   
   just made an edit to hyperlink PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] ebarboni commented on pull request #3197: FIx test failures in Groovy.editor

Posted by GitBox <gi...@apache.org>.
ebarboni commented on pull request #3197:
URL: https://github.com/apache/netbeans/pull/3197#issuecomment-929979102






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] ebarboni commented on pull request #3197: Fix test failures in Groovy.editor

Posted by GitBox <gi...@apache.org>.
ebarboni commented on pull request #3197:
URL: https://github.com/apache/netbeans/pull/3197#issuecomment-931196180


   Green light, will merge later today if nobody beat me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] ebarboni merged pull request #3197: Fix test failures in Groovy.editor

Posted by GitBox <gi...@apache.org>.
ebarboni merged pull request #3197:
URL: https://github.com/apache/netbeans/pull/3197


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] sdedic commented on pull request #3197: FIx test failures in Groovy.editor

Posted by GitBox <gi...@apache.org>.
sdedic commented on pull request #3197:
URL: https://github.com/apache/netbeans/pull/3197#issuecomment-930276222


   OK ... I have such a mess on local from all the groovy experiments  that I'll do a clean checkout ;)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] ebarboni commented on pull request #3197: FIx test failures in Groovy.editor

Posted by GitBox <gi...@apache.org>.
ebarboni commented on pull request #3197:
URL: https://github.com/apache/netbeans/pull/3197#issuecomment-930274930


   seems a last test is failing. 
   
   Testcase: testIndex1(org.netbeans.modules.groovy.editor.api.GroovyIndexerTest):	FAILED
       [junit] Content does not match between 'testfiles/BookmarkController.groovy' and testfiles/BookmarkController.groovy.indexed'


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists