You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/27 17:29:36 UTC
[GitHub] [arrow-datafusion] tustvold opened a new pull request, #3987: Pin datafusion-proto build dependencies
tustvold opened a new pull request, #3987:
URL: https://github.com/apache/arrow-datafusion/pull/3987
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Should avoid confusing issues where people get different generated output
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold merged pull request #3987: Pin datafusion-proto build dependencies
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #3987:
URL: https://github.com/apache/arrow-datafusion/pull/3987
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #3987: Pin datafusion-proto build dependencies
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #3987:
URL: https://github.com/apache/arrow-datafusion/pull/3987#discussion_r1007180577
##########
datafusion/proto/Cargo.toml:
##########
@@ -55,5 +55,6 @@ doc-comment = "0.3"
tokio = "1.18"
[build-dependencies]
-pbjson-build = { version = "0.5" }
-prost-build = { version = "0.11.1" }
+# Pin these dependencies so that the generated output is deterministic
+pbjson-build = { version = "=0.5.1" }
Review Comment:
Minor version bumps can and will still change the code - see #3958
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #3987: Pin datafusion-proto build dependencies
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #3987:
URL: https://github.com/apache/arrow-datafusion/pull/3987#discussion_r1007327438
##########
datafusion/proto/Cargo.toml:
##########
@@ -55,5 +55,6 @@ doc-comment = "0.3"
tokio = "1.18"
[build-dependencies]
-pbjson-build = { version = "0.5" }
-prost-build = { version = "0.11.1" }
+# Pin these dependencies so that the generated output is deterministic
+pbjson-build = { version = "=0.5.1" }
Review Comment:
Right -- I guess I was saying with this approach we won't see 0.5.2 if it is released.
If we left
```
pbjson-build = { version = "0.5.1" }
```
We would start seeing local changes in our checkouts again potentially which might prompt someone to check them in?
I don't feel strongly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #3987: Pin datafusion-proto build dependencies
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #3987:
URL: https://github.com/apache/arrow-datafusion/pull/3987#discussion_r1007180577
##########
datafusion/proto/Cargo.toml:
##########
@@ -55,5 +55,6 @@ doc-comment = "0.3"
tokio = "1.18"
[build-dependencies]
-pbjson-build = { version = "0.5" }
-prost-build = { version = "0.11.1" }
+# Pin these dependencies so that the generated output is deterministic
+pbjson-build = { version = "=0.5.1" }
Review Comment:
Minor version bumps can and will still change the code - see #3958
Dependabot will nag us, and the update velocity is relatively low, so I think this is probably fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #3987: Pin datafusion-proto build dependencies
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #3987:
URL: https://github.com/apache/arrow-datafusion/pull/3987#discussion_r1007334088
##########
datafusion/proto/Cargo.toml:
##########
@@ -55,5 +55,6 @@ doc-comment = "0.3"
tokio = "1.18"
[build-dependencies]
-pbjson-build = { version = "0.5" }
-prost-build = { version = "0.11.1" }
+# Pin these dependencies so that the generated output is deterministic
+pbjson-build = { version = "=0.5.1" }
Review Comment:
> We would start seeing local changes in our checkouts again
As this wouldn't be correlated with someone making a change to the proto definitions I think this could be surprising. What would more likely happen is their local lockfile will hold back the upgrade, then they will get strange CI failures. If they then check in the proto files, people will then get local changes until their lockfile is updated... Basically a bit of a mess :sweat_smile:
I don't like this either, checking in this code feels wrong, but I'm at a loss as to how to make this work better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #3987: Pin datafusion-proto build dependencies
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #3987:
URL: https://github.com/apache/arrow-datafusion/pull/3987#discussion_r1007179919
##########
datafusion/proto/Cargo.toml:
##########
@@ -55,5 +55,6 @@ doc-comment = "0.3"
tokio = "1.18"
[build-dependencies]
-pbjson-build = { version = "0.5" }
-prost-build = { version = "0.11.1" }
+# Pin these dependencies so that the generated output is deterministic
+pbjson-build = { version = "=0.5.1" }
Review Comment:
Shall we just make the version 0.5.1 (rather than pin it) so we automatically get updates?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #3987: Pin datafusion-proto build dependencies
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3987:
URL: https://github.com/apache/arrow-datafusion/pull/3987#issuecomment-1294023102
Benchmark runs are scheduled for baseline = 002165b55beb3aeb15ad4d9955295af7ff045945 and contender = 067809389d892deac7788ac626f811fdb9ee7730. 067809389d892deac7788ac626f811fdb9ee7730 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/ff3b9965d6984475a55ba6140b60eaec...c5c6bdb79ad744ee9296a70780b931fb/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/a392d308241d43c29fccff55def3bdb4...5c805fe17c43485d8dc9591eee84fc74/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/e09f556813e54b139ee13f1c204850ee...603902fc4679421cabfb2c32fc221790/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/aadadf22f6584f30a2a0ea4dc498e7cd...e56fa1d69985455882544ae0346bc777/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #3987: Pin datafusion-proto build dependencies
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #3987:
URL: https://github.com/apache/arrow-datafusion/pull/3987#discussion_r1007334088
##########
datafusion/proto/Cargo.toml:
##########
@@ -55,5 +55,6 @@ doc-comment = "0.3"
tokio = "1.18"
[build-dependencies]
-pbjson-build = { version = "0.5" }
-prost-build = { version = "0.11.1" }
+# Pin these dependencies so that the generated output is deterministic
+pbjson-build = { version = "=0.5.1" }
Review Comment:
> We would start seeing local changes in our checkouts again
As this wouldn't be correlated with someone making a change to the proto definitions I think this could be surprising. What would more likely happen is there local lockfile will hold back the upgrade, then they will get strange CI failures. If they then check in the proto files, people will then get local changes until their lockfile is updated... Basically a bit of a mess :sweat_smile:
I don't like this either, checking in this code feels wrong, but I'm at a loss as to how to make this work better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org