You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/01/15 13:56:20 UTC
[GitHub] [incubator-mxnet] kshitij12345 opened a new pull request #17325:
Fix Flaky Test Higher Order Grad
kshitij12345 opened a new pull request #17325: Fix Flaky Test Higher Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325
While recently fixing #17321 , I stumbled upon cases where `test_arctanh`, `test_arcsin` failing due to getting value which were out of the functions domain.
The way we generated the test array from normal distribution meant that even if very low probability, the chance of an out of domain value showing up was still there.
To this end, have defined a simple wrapper around `np.random.uniform` (similar to `random_arrays`), which lets us specify the lower and upper bound of the generated array.
A pro of using uniform distribution is that we generate samples equal from the whole range of the distribution unlike normal which is centred around mean thus allowing in better testing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] kshitij12345 commented on issue #17325: Fix Flaky
Test Higher Order Grad
Posted by GitBox <gi...@apache.org>.
kshitij12345 commented on issue #17325: Fix Flaky Test Higher Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325#issuecomment-574789821
It is failing the test with multiple trials. Still needs to be fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] kshitij12345 edited a comment on issue #17325:
Fix Flaky Test Higher Order Grad
Posted by GitBox <gi...@apache.org>.
kshitij12345 edited a comment on issue #17325: Fix Flaky Test Higher Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325#issuecomment-577264782
Verification of remaining Unary Operators with
```
MXNET_TEST_COUNT=10000 nosetests ./tests/python/unittest/test_higher_order_grad.py:test_opname
```
* [x] relu
* [ ] log
* [ ] log2
* [ ] log10
* [ ] square
* [ ] expm1
* [ ] log1p
* [ ] reciprocal
* [ ] abs
* [ ] clip
* [ ] dropout
* [ ] sigmoid
* [ ] sqrt
* [ ] cbrt
* [ ] rsqrt
* [ ] rcbrt
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] larroy commented on issue #17325: Fix Flaky Test
Higher Order Grad
Posted by GitBox <gi...@apache.org>.
larroy commented on issue #17325: Fix Flaky Test Higher Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325#issuecomment-579462138
> @sxjscience @apeforest @larroy
>
> While trying to track the causes for failures, I found that there is an issue with the way we are computing the second order gradients.
>
> Sample :
> https://github.com/apache/incubator-mxnet/blob/49df604ac3bb156e446671403c86a3535af9615d/src/operator/tensor/elemwise_unary_op_trig.cc#L201-L207
>
> While computing `x_grad`, elements of `dydx` can be `0`, which leads to `Nan` at that position in our computation, instead of it being `0`.
>
> Most of the failures that I have checked in CI seem to be of this case.
> Example : #17362 where we expect 0 but end up with `Nan`
>
> ```
> Items are not equal:
>
> Error nan exceeds tolerance rtol=1.000000e-05, atol=1.000000e-20 (mismatch 0.154321%).
>
> Location of maximum error: (1, 6, 2, 1), a=0.00000000, b=nan
>
> ACTUAL: array([[[[-0.03453423, 0.1168007 , -0.00583075],
>
> [ 0.02170432, 0.37017354, 0.09864384],
>
> [-0.02544087, -0.06709251, -0.34824234]],...
>
> DESIRED: array([[[[-0.03453423, 0.1168007 , -0.00583075],
>
> [ 0.02170432, 0.37017348, 0.09864385],
>
> [-0.02544087, -0.0670925 , -0.34824237]],...
>
> -------------------- >> begin captured stdout << ---------------------
>
>
>
> *** Maximum errors for vector of size 648: rtol=1e-05, atol=1e-20
>
>
>
> 1: Error nan Location of error: (1, 6, 2, 1), a=0.00000000, b=nan
>
>
>
> --------------------- >> end captured stdout << ----------------------
>
> -------------------- >> begin captured logging << --------------------
>
> common: INFO: Setting test np/mx/python random seeds, use MXNET_TEST_SEED=402611671 to reproduce.
>
> --------------------- >> end captured logging << ---------------------
> ```
>
> **Mitigation** :
>
> The reason we divide by `dydx` is to get first gradient from previous computation instead of computing it again.
>
> One solution might be to replace
>
> ```
> auto x_grad = op.div(dydx_mul_grad_x, dydx);
> ```
>
> with actually computing the first degree gradient
>
> ```
> auth x_grad = nnvm::NodeEntry{mxnet::op::MakeNode("_backward_arcsin",
> dependent_node->attrs.name + "_mul_scalar",
> {x}, &nullptr, &dependent_node)};
> ```
>
> Will try this and update how this goes.
>
> Let me know if you have any other idea.
looks good, I guess it's easier than have another operator like div_zero which I'm not sure we have.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] kshitij12345 edited a comment on issue #17325:
Fix Flaky Test Higher Order Grad
Posted by GitBox <gi...@apache.org>.
kshitij12345 edited a comment on issue #17325: Fix Flaky Test Higher Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325#issuecomment-577264782
Verification of remaining Unary Operators with
```
MXNET_TEST_COUNT=10000 nosetests ./tests/python/unittest/test_higher_order_grad.py:test_opname
```
* [x] relu
* [x] log
* [x] log2
* [x] log10
* [x] square
* [x] expm1
* [x] log1p
* [x] reciprocal
* [x] abs
* [x] clip
* [x] dropout
* [x] sigmoid
* [ ] sqrt
* [ ] cbrt
* [ ] rsqrt
* [ ] rcbrt
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] kshitij12345 edited a comment on issue #17325:
Fix Flaky Test Higher Order Grad
Posted by GitBox <gi...@apache.org>.
kshitij12345 edited a comment on issue #17325: Fix Flaky Test Higher Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325#issuecomment-577222439
Verification of Trig Operators with
```
MXNET_TEST_COUNT=10000 nosetests ./tests/python/unittest/test_higher_order_grad.py:test_opname
```
* [x] sin
* [ ] cos
* [ ] tan
* [ ] sinh
* [ ] cosh
* [ ] tanh
* [ ] arcsin
* [ ] arccos
* [ ] arctan
* [ ] arcsinh
* [ ] arccosh
* [ ] arctanh
* [ ] radians
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] kshitij12345 edited a comment on issue #17325:
Fix Flaky Test Higher Order Grad
Posted by GitBox <gi...@apache.org>.
kshitij12345 edited a comment on issue #17325: Fix Flaky Test Higher Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325#issuecomment-577264782
Verification of remaining Unary Operators with
```
MXNET_TEST_COUNT=10000 nosetests ./tests/python/unittest/test_higher_order_grad.py:test_opname
```
* [x] relu
* [x] log
* [x] log2
* [x] log10
* [x] square
* [x] expm1
* [ ] log1p
* [ ] reciprocal
* [ ] abs
* [ ] clip
* [ ] dropout
* [ ] sigmoid
* [ ] sqrt
* [ ] cbrt
* [ ] rsqrt
* [ ] rcbrt
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] kshitij12345 commented on issue #17325: Fix Flaky
Test Higher Order Grad
Posted by GitBox <gi...@apache.org>.
kshitij12345 commented on issue #17325: Fix Flaky Test Higher Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325#issuecomment-581858314
@apeforest @sxjscience @larroy Can you please take a final look. Tests have finally passed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] larroy commented on a change in pull request
#17325: Fix Flaky Test Higher Order Grad
Posted by GitBox <gi...@apache.org>.
larroy commented on a change in pull request #17325: Fix Flaky Test Higher Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325#discussion_r367152446
##########
File path: python/mxnet/test_utils.py
##########
@@ -102,6 +102,16 @@ def random_arrays(*shapes):
return arrays
+def random_uniform_arrays(*shapes, low=0.0, high=1.0):
+ """Generate some random numpy arrays."""
+ arrays = [np.array(np.random.uniform(low, high), dtype=default_dtype())
+ if len(s) == 0 else np.random.uniform(low, high, size=s).astype(default_dtype())
+ for s in shapes]
Review comment:
I don't like to return different types based on inputs, the function should just return a list of arrays. other than that PR looks fine and approach is good. thanks for the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] kshitij12345 edited a comment on issue #17325:
Fix Flaky Test Higher Order Grad
Posted by GitBox <gi...@apache.org>.
kshitij12345 edited a comment on issue #17325: Fix Flaky Test Higher Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325#issuecomment-577222439
Verification of Trig Operators with
```
MXNET_TEST_COUNT=10000 nosetests ./tests/python/unittest/test_higher_order_grad.py:test_opname
```
* [x] sin
* [ ] cos
* [ ] tan
* [ ] sinh
* [ ] cosh
* [ ] tanh
* [ ] arcsin
* [ ] arccos
* [ ] arctan
* [ ] arcsinh
* [ ] arccosh
* [ ] arctanh
* [ ] radians
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] kshitij12345 edited a comment on issue #17325:
Fix Flaky Test Higher Order Grad
Posted by GitBox <gi...@apache.org>.
kshitij12345 edited a comment on issue #17325: Fix Flaky Test Higher Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325#issuecomment-577264782
Verification of remaining Unary Operators with
```
MXNET_TEST_COUNT=10000 nosetests ./tests/python/unittest/test_higher_order_grad.py:test_opname
```
* [x] relu
* [x] log
* [x] log2
* [x] log10
* [ ] square
* [ ] expm1
* [ ] log1p
* [ ] reciprocal
* [ ] abs
* [ ] clip
* [ ] dropout
* [ ] sigmoid
* [ ] sqrt
* [ ] cbrt
* [ ] rsqrt
* [ ] rcbrt
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] kshitij12345 edited a comment on issue #17325:
Fix Flaky Test Higher Order Grad
Posted by GitBox <gi...@apache.org>.
kshitij12345 edited a comment on issue #17325: Fix Flaky Test Higher Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325#issuecomment-577222439
Verification of Trig Operators with
```
MXNET_TEST_COUNT=10000 nosetests ./tests/python/unittest/test_higher_order_grad.py:test_opname
```
* [x] sin
* [x] cos
* [x] tan
* [x] sinh
* [x] cosh
* [x] tanh
* [x] arcsin
* [x] arccos
* [x] arctan
* [x] arcsinh
* [x] arccosh
* [x] arctanh
* [x] radians
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] kshitij12345 edited a comment on issue #17325:
Fix Flaky Test Higher Order Grad
Posted by GitBox <gi...@apache.org>.
kshitij12345 edited a comment on issue #17325: Fix Flaky Test Higher Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325#issuecomment-577264782
Verification of remaining Unary Operators with
```
MXNET_TEST_COUNT=10000 nosetests ./tests/python/unittest/test_higher_order_grad.py:test_opname
```
* [x] relu
* [x] log
* [x] log2
* [x] log10
* [x] square
* [x] expm1
* [x] log1p
* [x] reciprocal
* [x] abs
* [x] clip
* [x] dropout
* [x] sigmoid
* [x] sqrt
* [x] cbrt
* [x] rsqrt
* [x] rcbrt
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] sxjscience commented on a change in pull request
#17325: Fix Flaky Test Higher Order Grad
Posted by GitBox <gi...@apache.org>.
sxjscience commented on a change in pull request #17325: Fix Flaky Test Higher Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325#discussion_r367132201
##########
File path: python/mxnet/test_utils.py
##########
@@ -102,6 +102,16 @@ def random_arrays(*shapes):
return arrays
+def random_uniform_arrays(*shapes, low=0.0, high=1.0):
+ """Generate some random numpy arrays."""
+ arrays = [np.array(np.random.uniform(low, high), dtype=default_dtype())
+ if len(s) == 0 else np.random.uniform(low, high, size=s).astype(default_dtype())
+ for s in shapes]
Review comment:
The if-condition is not necessary. We can directly write
```python
arrays = [np.random.uniform(low, high, size=s) for s in shapes]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] kshitij12345 edited a comment on issue #17325:
Fix Flaky Test Higher Order Grad
Posted by GitBox <gi...@apache.org>.
kshitij12345 edited a comment on issue #17325: Fix Flaky Test Higher Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325#issuecomment-577264782
Verification of remaining Unary Operators with
```
MXNET_TEST_COUNT=10000 nosetests ./tests/python/unittest/test_higher_order_grad.py:test_opname
```
* [x] relu
* [x] log
* [x] log2
* [ ] log10
* [ ] square
* [ ] expm1
* [ ] log1p
* [ ] reciprocal
* [ ] abs
* [ ] clip
* [ ] dropout
* [ ] sigmoid
* [ ] sqrt
* [ ] cbrt
* [ ] rsqrt
* [ ] rcbrt
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] kshitij12345 edited a comment on issue #17325:
Fix Flaky Test Higher Order Grad
Posted by GitBox <gi...@apache.org>.
kshitij12345 edited a comment on issue #17325: Fix Flaky Test Higher Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325#issuecomment-577222439
Verification of Trig Operators with
```
MXNET_TEST_COUNT=10000 nosetests ./tests/python/unittest/test_higher_order_grad.py:test_opname
```
* [x] sin
* [x] cos
* [x] tan
* [x] sinh
* [x] cosh
* [ ] tanh
* [ ] arcsin
* [ ] arccos
* [ ] arctan
* [ ] arcsinh
* [ ] arccosh
* [ ] arctanh
* [ ] radians
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on issue #17325: Fix Flaky
Test Higher Order Grad
Posted by GitBox <gi...@apache.org>.
apeforest commented on issue #17325: Fix Flaky Test Higher Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325#issuecomment-579085338
Yes, we encountered (again) CI random timeout issue recently. Please bear with us and re-trigger CI again. Sorry for the inconvenience.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] kshitij12345 commented on issue #17325: Fix Flaky
Test Higher Order Grad
Posted by GitBox <gi...@apache.org>.
kshitij12345 commented on issue #17325: Fix Flaky Test Higher Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325#issuecomment-577744412
@larroy @apeforest Is CI unstable at the moment? Tests are failing but the CI shows pending status.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] kshitij12345 edited a comment on issue #17325:
Fix Flaky Test Higher Order Grad
Posted by GitBox <gi...@apache.org>.
kshitij12345 edited a comment on issue #17325: Fix Flaky Test Higher Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325#issuecomment-577264782
Verification of remaining Unary Operators with
```
MXNET_TEST_COUNT=10000 nosetests ./tests/python/unittest/test_higher_order_grad.py:test_opname
```
* [x] relu
* [x] log
* [x] log2
* [x] log10
* [x] square
* [x] expm1
* [x] log1p
* [x] reciprocal
* [ ] abs
* [ ] clip
* [ ] dropout
* [ ] sigmoid
* [ ] sqrt
* [ ] cbrt
* [ ] rsqrt
* [ ] rcbrt
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] kshitij12345 commented on a change in pull
request #17325: Fix Flaky Test Higher Order Grad
Posted by GitBox <gi...@apache.org>.
kshitij12345 commented on a change in pull request #17325: Fix Flaky Test Higher Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325#discussion_r368274020
##########
File path: tests/python/unittest/test_higher_order_grad.py
##########
@@ -27,7 +27,8 @@
from common import with_seed
import mxnet
from mxnet import nd, autograd, gluon
-from mxnet.test_utils import assert_almost_equal, random_arrays, rand_shape_nd, same
+from mxnet.test_utils import (
+ assert_almost_equal, random_arrays, random_uniform_arrays, rand_shape_nd, same)
Review comment:
Other tests are still using `random_arrays`, probably they can be replaced with `random_uniform_arrays` but will have to verify once.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request
#17325: Fix Flaky Test Higher Order Grad
Posted by GitBox <gi...@apache.org>.
apeforest commented on a change in pull request #17325: Fix Flaky Test Higher Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325#discussion_r374870909
##########
File path: src/nnvm/node_op_util.h
##########
@@ -80,6 +80,12 @@ class NodeOpGen {
dependent_node->attrs.name + "_negative",
{x}, nullptr, &dependent_node)};
}
+
+ nnvm::NodeEntry ones_like(const nnvm::NodeEntry &x) {
Review comment:
Don't we already have an ones_like operator already for use? https://github.com/apache/incubator-mxnet/blob/971ea4f0adb5bd52cdcdee3e15f390ac05a3d379/src/operator/tensor/init_op.cc#L185
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] kshitij12345 edited a comment on issue #17325:
Fix Flaky Test Higher Order Grad
Posted by GitBox <gi...@apache.org>.
kshitij12345 edited a comment on issue #17325: Fix Flaky Test Higher Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325#issuecomment-577264782
Verification of remaining Unary Operators with
```
MXNET_TEST_COUNT=10000 nosetests ./tests/python/unittest/test_higher_order_grad.py:test_opname
```
* [x] relu
* [x] log
* [x] log2
* [x] log10
* [x] square
* [x] expm1
* [x] log1p
* [x] reciprocal
* [x] abs
* [ ] clip
* [ ] dropout
* [ ] sigmoid
* [ ] sqrt
* [ ] cbrt
* [ ] rsqrt
* [ ] rcbrt
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] kshitij12345 edited a comment on issue #17325:
Fix Flaky Test Higher Order Grad
Posted by GitBox <gi...@apache.org>.
kshitij12345 edited a comment on issue #17325: Fix Flaky Test Higher Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325#issuecomment-577264782
Verification of remaining Unary Operators with
```
MXNET_TEST_COUNT=10000 nosetests ./tests/python/unittest/test_higher_order_grad.py:test_opname
```
* [x] relu
* [x] log
* [x] log2
* [x] log10
* [x] square
* [x] expm1
* [x] log1p
* [x] reciprocal
* [x] abs
* [x] clip
* [x] dropout
* [x] sigmoid
* [x] sqrt
* [ ] cbrt
* [ ] rsqrt
* [ ] rcbrt
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] kshitij12345 edited a comment on issue #17325:
Fix Flaky Test Higher Order Grad
Posted by GitBox <gi...@apache.org>.
kshitij12345 edited a comment on issue #17325: Fix Flaky Test Higher Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325#issuecomment-577264782
Verification of remaining Unary Operators with
```
MXNET_TEST_COUNT=10000 nosetests ./tests/python/unittest/test_higher_order_grad.py:test_opname
```
* [x] relu
* [x] log
* [x] log2
* [x] log10
* [x] square
* [x] expm1
* [x] log1p
* [x] reciprocal
* [x] abs
* [x] clip
* [ ] dropout
* [ ] sigmoid
* [ ] sqrt
* [ ] cbrt
* [ ] rsqrt
* [ ] rcbrt
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] kshitij12345 edited a comment on issue #17325:
Fix Flaky Test Higher Order Grad
Posted by GitBox <gi...@apache.org>.
kshitij12345 edited a comment on issue #17325: Fix Flaky Test Higher Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325#issuecomment-577222439
Verification of Trig Operators with
```
MXNET_TEST_COUNT=10000 nosetests ./tests/python/unittest/test_higher_order_grad.py:test_opname
```
* [x] sin
* [x] cos
* [x] tan
* [ ] sinh
* [ ] cosh
* [ ] tanh
* [ ] arcsin
* [ ] arccos
* [ ] arctan
* [ ] arcsinh
* [ ] arccosh
* [ ] arctanh
* [ ] radians
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] kshitij12345 commented on issue #17325: Fix Flaky
Test Higher Order Grad
Posted by GitBox <gi...@apache.org>.
kshitij12345 commented on issue #17325: Fix Flaky Test Higher Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325#issuecomment-575979165
@sxjscience @apeforest @larroy
While trying to track the causes for failures, I found that there is an issue with the way we are computing the second order gradients.
Sample :
https://github.com/apache/incubator-mxnet/blob/49df604ac3bb156e446671403c86a3535af9615d/src/operator/tensor/elemwise_unary_op_trig.cc#L201-L207
While computing `x_grad`, elements of `dydx` can be `0`, which leads to `Nan` at that position in our computation, instead of it being `0`.
Most of the failures that I have checked in CI seem to be of this case.
Example : #17362 where we expect 0 but end up with `Nan`
```
Items are not equal:
Error nan exceeds tolerance rtol=1.000000e-05, atol=1.000000e-20 (mismatch 0.154321%).
Location of maximum error: (1, 6, 2, 1), a=0.00000000, b=nan
ACTUAL: array([[[[-0.03453423, 0.1168007 , -0.00583075],
[ 0.02170432, 0.37017354, 0.09864384],
[-0.02544087, -0.06709251, -0.34824234]],...
DESIRED: array([[[[-0.03453423, 0.1168007 , -0.00583075],
[ 0.02170432, 0.37017348, 0.09864385],
[-0.02544087, -0.0670925 , -0.34824237]],...
-------------------- >> begin captured stdout << ---------------------
*** Maximum errors for vector of size 648: rtol=1e-05, atol=1e-20
1: Error nan Location of error: (1, 6, 2, 1), a=0.00000000, b=nan
--------------------- >> end captured stdout << ----------------------
-------------------- >> begin captured logging << --------------------
common: INFO: Setting test np/mx/python random seeds, use MXNET_TEST_SEED=402611671 to reproduce.
--------------------- >> end captured logging << ---------------------
```
---------------------------------------------------------
**Mitigation** :
The reason we divide by `dydx` is to get first gradient from previous computation instead of computing it again.
One solution might be to replace
```
auto x_grad = op.div(dydx_mul_grad_x, dydx);
```
with actually computing the first degree gradient
```
auth x_grad = nnvm::NodeEntry{mxnet::op::MakeNode("_backward_arcsin",
dependent_node->attrs.name + "_mul_scalar",
{x}, &nullptr, &dependent_node)};
```
Will try this and update how this goes.
Let me know if you have any other idea.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on issue #17325: Fix Flaky
Test Higher Order Grad
Posted by GitBox <gi...@apache.org>.
apeforest commented on issue #17325: Fix Flaky Test Higher Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325#issuecomment-575945234
Thanks a lot for your contribution! Looks good to me except one question
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request
#17325: Fix Flaky Test Higher Order Grad
Posted by GitBox <gi...@apache.org>.
apeforest commented on a change in pull request #17325: Fix Flaky Test Higher Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325#discussion_r374870909
##########
File path: src/nnvm/node_op_util.h
##########
@@ -80,6 +80,12 @@ class NodeOpGen {
dependent_node->attrs.name + "_negative",
{x}, nullptr, &dependent_node)};
}
+
+ nnvm::NodeEntry ones_like(const nnvm::NodeEntry &x) {
Review comment:
Don't we already have an ones_like operator already for use? https://github.com/apache/incubator-mxnet/blob/971ea4f0adb5bd52cdcdee3e15f390ac05a3d379/src/operator/tensor/init_op.cc#L185
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] kshitij12345 edited a comment on issue #17325:
Fix Flaky Test Higher Order Grad
Posted by GitBox <gi...@apache.org>.
kshitij12345 edited a comment on issue #17325: Fix Flaky Test Higher Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325#issuecomment-577264782
Verification of remaining Unary Operators with
```
MXNET_TEST_COUNT=10000 nosetests ./tests/python/unittest/test_higher_order_grad.py:test_opname
```
* [x] relu
* [x] log
* [x] log2
* [x] log10
* [x] square
* [x] expm1
* [x] log1p
* [x] reciprocal
* [x] abs
* [x] clip
* [x] dropout
* [x] sigmoid
* [x] sqrt
* [x] cbrt
* [x] rsqrt
* [x] rcbrt
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] kshitij12345 edited a comment on issue #17325:
Fix Flaky Test Higher Order Grad
Posted by GitBox <gi...@apache.org>.
kshitij12345 edited a comment on issue #17325: Fix Flaky Test Higher Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325#issuecomment-577264782
Verification of remaining Unary Operators with
```
MXNET_TEST_COUNT=10000 nosetests ./tests/python/unittest/test_higher_order_grad.py:test_opname
```
* [x] relu
* [x] log
* [x] log2
* [x] log10
* [x] square
* [x] expm1
* [x] log1p
* [x] reciprocal
* [x] abs
* [x] clip
* [x] dropout
* [ ] sigmoid
* [ ] sqrt
* [ ] cbrt
* [ ] rsqrt
* [ ] rcbrt
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] sxjscience commented on a change in pull request
#17325: Fix Flaky Test Higher Order Grad
Posted by GitBox <gi...@apache.org>.
sxjscience commented on a change in pull request #17325: Fix Flaky Test Higher Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325#discussion_r367134568
##########
File path: python/mxnet/test_utils.py
##########
@@ -102,6 +102,16 @@ def random_arrays(*shapes):
return arrays
+def random_uniform_arrays(*shapes, low=0.0, high=1.0):
+ """Generate some random numpy arrays."""
+ arrays = [np.array(np.random.uniform(low, high), dtype=default_dtype())
+ if len(s) == 0 else np.random.uniform(low, high, size=s).astype(default_dtype())
+ for s in shapes]
Review comment:
Also, we'd better add a dtype flag to the function, which is None by default and set it to default_dtype() if it's None.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] kshitij12345 commented on a change in pull
request #17325: Fix Flaky Test Higher Order Grad
Posted by GitBox <gi...@apache.org>.
kshitij12345 commented on a change in pull request #17325: Fix Flaky Test Higher Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325#discussion_r367474680
##########
File path: python/mxnet/test_utils.py
##########
@@ -102,6 +102,16 @@ def random_arrays(*shapes):
return arrays
+def random_uniform_arrays(*shapes, low=0.0, high=1.0):
+ """Generate some random numpy arrays."""
+ arrays = [np.array(np.random.uniform(low, high), dtype=default_dtype())
+ if len(s) == 0 else np.random.uniform(low, high, size=s).astype(default_dtype())
+ for s in shapes]
Review comment:
@sxjscience Will do that.
@larroy Agreed even I don't like that. However note that `random_arrays` in `test_utils.py` has that. I wanted `random_uniform_arrays` to be a drop-in replacement for `random_arrays` if and where necessary. But I guess it makes sense to not worry about it.
https://github.com/apache/incubator-mxnet/blob/04c3eec3e8ea793614244e18a89c6b3a13f12d6a/python/mxnet/test_utils.py#L95-L102
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] kshitij12345 edited a comment on issue #17325:
Fix Flaky Test Higher Order Grad
Posted by GitBox <gi...@apache.org>.
kshitij12345 edited a comment on issue #17325: Fix Flaky Test Higher Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325#issuecomment-577264782
Verification of remaining Unary Operators with
```
MXNET_TEST_COUNT=10000 nosetests ./tests/python/unittest/test_higher_order_grad.py:test_opname
```
* [x] relu
* [x] log
* [x] log2
* [x] log10
* [x] square
* [x] expm1
* [x] log1p
* [x] reciprocal
* [x] abs
* [x] clip
* [x] dropout
* [x] sigmoid
* [x] sqrt
* [x] cbrt
* [x] rsqrt
* [ ] rcbrt
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] kshitij12345 edited a comment on issue #17325:
Fix Flaky Test Higher Order Grad
Posted by GitBox <gi...@apache.org>.
kshitij12345 edited a comment on issue #17325: Fix Flaky Test Higher Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325#issuecomment-577264782
Verification of remaining Unary Operators with
```
MXNET_TEST_COUNT=10000 nosetests ./tests/python/unittest/test_higher_order_grad.py:test_opname
```
* [x] relu
* [x] log
* [ ] log2
* [ ] log10
* [ ] square
* [ ] expm1
* [ ] log1p
* [ ] reciprocal
* [ ] abs
* [ ] clip
* [ ] dropout
* [ ] sigmoid
* [ ] sqrt
* [ ] cbrt
* [ ] rsqrt
* [ ] rcbrt
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] kshitij12345 commented on issue #17325: Fix Flaky
Test Higher Order Grad
Posted by GitBox <gi...@apache.org>.
kshitij12345 commented on issue #17325: Fix Flaky Test Higher Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325#issuecomment-577222439
Verification of Trig Operators with
```
MXNET_TEST_COUNT=10000 nosetests ./tests/python/unittest/test_higher_order_grad.py:test_opname
```
* [ ] sin
* [ ] cos
* [ ] tan
* [ ] sinh
* [ ] cosh
* [ ] tanh
* [ ] arcsin
* [ ] arccos
* [ ] arctan
* [ ] arcsinh
* [ ] arccosh
* [ ] arctanh
* [ ] radians
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] kshitij12345 edited a comment on issue #17325:
Fix Flaky Test Higher Order Grad
Posted by GitBox <gi...@apache.org>.
kshitij12345 edited a comment on issue #17325: Fix Flaky Test Higher Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325#issuecomment-577264782
Verification of remaining Unary Operators with
```
MXNET_TEST_COUNT=10000 nosetests ./tests/python/unittest/test_higher_order_grad.py:test_opname
```
* [x] relu
* [x] log
* [x] log2
* [x] log10
* [x] square
* [x] expm1
* [x] log1p
* [ ] reciprocal
* [ ] abs
* [ ] clip
* [ ] dropout
* [ ] sigmoid
* [ ] sqrt
* [ ] cbrt
* [ ] rsqrt
* [ ] rcbrt
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] kshitij12345 commented on issue #17325: Fix Flaky
Test Higher Order Grad
Posted by GitBox <gi...@apache.org>.
kshitij12345 commented on issue #17325: Fix Flaky Test Higher Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325#issuecomment-579238547
@apeforest Sure. No worries. Just wanted to confirm that it is not related to this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] kshitij12345 edited a comment on issue #17325:
Fix Flaky Test Higher Order Grad
Posted by GitBox <gi...@apache.org>.
kshitij12345 edited a comment on issue #17325: Fix Flaky Test Higher Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325#issuecomment-577222439
Verification of Trig Operators with
```
MXNET_TEST_COUNT=10000 nosetests ./tests/python/unittest/test_higher_order_grad.py:test_opname
```
* [ ] sin
* [ ] cos
* [ ] tan
* [ ] sinh
* [ ] cosh
* [ ] tanh
* [ ] arcsin
* [ ] arccos
* [ ] arctan
* [ ] arcsinh
* [ ] arccosh
* [ ] arctanh
* [ ] radians
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request
#17325: Fix Flaky Test Higher Order Grad
Posted by GitBox <gi...@apache.org>.
apeforest commented on a change in pull request #17325: Fix Flaky Test Higher Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325#discussion_r368252820
##########
File path: tests/python/unittest/test_higher_order_grad.py
##########
@@ -27,7 +27,8 @@
from common import with_seed
import mxnet
from mxnet import nd, autograd, gluon
-from mxnet.test_utils import assert_almost_equal, random_arrays, rand_shape_nd, same
+from mxnet.test_utils import (
+ assert_almost_equal, random_arrays, random_uniform_arrays, rand_shape_nd, same)
Review comment:
Do you still need import random_arrays in this case? Also can this new method replace random_arrays?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on issue #17325: Fix Flaky
Test Higher Order Grad
Posted by GitBox <gi...@apache.org>.
apeforest commented on issue #17325: Fix Flaky Test Higher Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325#issuecomment-582072477
Thanks for your patience re-triggering CI for so many times. We are working on a new CI system and hope it can alleviate the current burden from developers. Stay tuned please :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] kshitij12345 edited a comment on issue #17325:
Fix Flaky Test Higher Order Grad
Posted by GitBox <gi...@apache.org>.
kshitij12345 edited a comment on issue #17325: Fix Flaky Test Higher Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325#issuecomment-577264782
Verification of remaining Unary Operators with
```
MXNET_TEST_COUNT=10000 nosetests ./tests/python/unittest/test_higher_order_grad.py:test_opname
```
* [x] relu
* [x] log
* [x] log2
* [x] log10
* [x] square
* [x] expm1
* [x] log1p
* [x] reciprocal
* [x] abs
* [x] clip
* [x] dropout
* [x] sigmoid
* [ ] sqrt
* [ ] cbrt
* [ ] rsqrt
* [ ] rcbrt
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] kshitij12345 edited a comment on issue #17325:
Fix Flaky Test Higher Order Grad
Posted by GitBox <gi...@apache.org>.
kshitij12345 edited a comment on issue #17325: Fix Flaky Test Higher Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325#issuecomment-577264782
Verification of remaining Unary Operators with
```
MXNET_TEST_COUNT=10000 nosetests ./tests/python/unittest/test_higher_order_grad.py:test_opname
```
* [x] relu
* [x] log
* [x] log2
* [x] log10
* [x] square
* [ ] expm1
* [ ] log1p
* [ ] reciprocal
* [ ] abs
* [ ] clip
* [ ] dropout
* [ ] sigmoid
* [ ] sqrt
* [ ] cbrt
* [ ] rsqrt
* [ ] rcbrt
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] kshitij12345 edited a comment on issue #17325:
Fix Flaky Test Higher Order Grad
Posted by GitBox <gi...@apache.org>.
kshitij12345 edited a comment on issue #17325: Fix Flaky Test Higher Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325#issuecomment-577264782
Verification of remaining Unary Operators with
```
MXNET_TEST_COUNT=10000 nosetests ./tests/python/unittest/test_higher_order_grad.py:test_opname
```
* [x] relu
* [x] log
* [x] log2
* [x] log10
* [x] square
* [x] expm1
* [x] log1p
* [x] reciprocal
* [x] abs
* [x] clip
* [x] dropout
* [x] sigmoid
* [x] sqrt
* [x] cbrt
* [ ] rsqrt
* [ ] rcbrt
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] apeforest merged pull request #17325: Fix Flaky
Test Higher Order Grad
Posted by GitBox <gi...@apache.org>.
apeforest merged pull request #17325: Fix Flaky Test Higher Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] kshitij12345 commented on issue #17325: Fix Flaky
Test Higher Order Grad
Posted by GitBox <gi...@apache.org>.
kshitij12345 commented on issue #17325: Fix Flaky Test Higher Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325#issuecomment-577264782
Verification of remaining Unary Operators with
```
MXNET_TEST_COUNT=10000 nosetests ./tests/python/unittest/test_higher_order_grad.py:test_opname
```
* [ ] relu
* [ ] log
* [ ] log2
* [ ] log10
* [ ] square
* [ ] expm1
* [ ] log1p
* [ ] reciprocal
* [ ] abs
* [ ] clip
* [ ] dropout
* [ ] sigmoid
* [ ] sqrt
* [ ] cbrt
* [ ] rsqrt
* [ ] rcbrt
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] kshitij12345 edited a comment on issue #17325:
Fix Flaky Test Higher Order Grad
Posted by GitBox <gi...@apache.org>.
kshitij12345 edited a comment on issue #17325: Fix Flaky Test Higher Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325#issuecomment-577222439
Verification of Trig Operators with
```
MXNET_TEST_COUNT=10000 nosetests ./tests/python/unittest/test_higher_order_grad.py:test_opname
```
* [x] sin
* [x] cos
* [x] tan
* [x] sinh
* [x] cosh
* [x] tanh
* [ ] arcsin
* [ ] arccos
* [ ] arctan
* [ ] arcsinh
* [ ] arccosh
* [ ] arctanh
* [ ] radians
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] kshitij12345 commented on issue #17325: Fix Flaky
Test Higher Order Grad
Posted by GitBox <gi...@apache.org>.
kshitij12345 commented on issue #17325: Fix Flaky Test Higher Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325#issuecomment-574670206
@apeforest @larroy @sxjscience Please review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] kshitij12345 edited a comment on issue #17325:
Fix Flaky Test Higher Order Grad
Posted by GitBox <gi...@apache.org>.
kshitij12345 edited a comment on issue #17325: Fix Flaky Test Higher Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325#issuecomment-577264782
Verification of remaining Unary Operators with
```
MXNET_TEST_COUNT=10000 nosetests ./tests/python/unittest/test_higher_order_grad.py:test_opname
```
* [x] relu
* [x] log
* [x] log2
* [x] log10
* [x] square
* [x] expm1
* [ ] log1p
* [ ] reciprocal
* [ ] abs
* [ ] clip
* [ ] dropout
* [ ] sigmoid
* [ ] sqrt
* [ ] cbrt
* [ ] rsqrt
* [ ] rcbrt
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services