You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by sc...@apache.org on 2025/11/17 14:23:13 UTC
(tomcat) branch main updated: Fix error building status JSON
This is an automated email from the ASF dual-hosted git repository.
schultz pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 46ac1c5a47 Fix error building status JSON
46ac1c5a47 is described below
commit 46ac1c5a4788a414ccf1a8db1fb20ad808d46357
Author: Christopher Schultz <ch...@christopherschultz.net>
AuthorDate: Mon Nov 17 09:22:21 2025 -0500
Fix error building status JSON
FailedContext was missing some attributes required to report application status
---
java/org/apache/catalina/startup/FailedContext.java | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/java/org/apache/catalina/startup/FailedContext.java b/java/org/apache/catalina/startup/FailedContext.java
index 199b0ffe30..af66450b98 100644
--- a/java/org/apache/catalina/startup/FailedContext.java
+++ b/java/org/apache/catalina/startup/FailedContext.java
@@ -1432,4 +1432,15 @@ public class FailedContext extends LifecycleMBeanBase implements Context {
public void setSuspendWrappedResponseAfterForward(boolean suspendWrappedResponseAfterForward) {
}
+ public long getStartTime() {
+ return -1;
+ }
+
+ public long getStartupTime() {
+ return -1;
+ }
+
+ public long getTldScanTime() {
+ return -1;
+ }
}
\ No newline at end of file
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: (tomcat) branch main updated: Fix error building status JSON
Posted by Rémy Maucherat <re...@apache.org>.
On Mon, Nov 17, 2025 at 4:13 PM Mark Thomas <ma...@apache.org> wrote:
>
> This issue had already been fixed.
>
> https://github.com/apache/tomcat/commit/3dca097687e935e57d28e9b915f8d8a4b3d3c0a5
>
> It has been discussed on the dev list and had been approved for back-port.
Maybe it's simpler though. I agree with adding the status name of the webapp.
Rémy
> Mark
>
>
> On 17/11/2025 14:23, schultz@apache.org wrote:
> > This is an automated email from the ASF dual-hosted git repository.
> >
> > schultz pushed a commit to branch main
> > in repository https://gitbox.apache.org/repos/asf/tomcat.git
> >
> >
> > The following commit(s) were added to refs/heads/main by this push:
> > new 46ac1c5a47 Fix error building status JSON
> > 46ac1c5a47 is described below
> >
> > commit 46ac1c5a4788a414ccf1a8db1fb20ad808d46357
> > Author: Christopher Schultz <ch...@christopherschultz.net>
> > AuthorDate: Mon Nov 17 09:22:21 2025 -0500
> >
> > Fix error building status JSON
> >
> > FailedContext was missing some attributes required to report application status
> > ---
> > java/org/apache/catalina/startup/FailedContext.java | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/java/org/apache/catalina/startup/FailedContext.java b/java/org/apache/catalina/startup/FailedContext.java
> > index 199b0ffe30..af66450b98 100644
> > --- a/java/org/apache/catalina/startup/FailedContext.java
> > +++ b/java/org/apache/catalina/startup/FailedContext.java
> > @@ -1432,4 +1432,15 @@ public class FailedContext extends LifecycleMBeanBase implements Context {
> > public void setSuspendWrappedResponseAfterForward(boolean suspendWrappedResponseAfterForward) {
> > }
> >
> > + public long getStartTime() {
> > + return -1;
> > + }
> > +
> > + public long getStartupTime() {
> > + return -1;
> > + }
> > +
> > + public long getTldScanTime() {
> > + return -1;
> > + }
> > }
> > \ No newline at end of file
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> > For additional commands, e-mail: dev-help@tomcat.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: (tomcat) branch main updated: Fix error building status JSON
Posted by Mark Thomas <ma...@apache.org>.
On 17/11/2025 19:31, Christopher Schultz wrote:
> All,
>
> On 11/17/25 1:41 PM, Rémy Maucherat wrote:
>> On Mon, Nov 17, 2025 at 6:59 PM Christopher Schultz
>> <ch...@christopherschultz.net> wrote:
>>>
>>> Mark,
>>>
>>> On 11/17/25 10:12 AM, Mark Thomas wrote:
>>>> This issue had already been fixed.
>>>>
>>>> https://github.com/apache/tomcat/
>>>> commit/3dca097687e935e57d28e9b915f8d8a4b3d3c0a5
>>>>
>>>> It has been discussed on the dev list and had been approved for
>>>> back-port.
>>>
>>> Oh, sorry about that. I only see the conversation here:
>>> https://lists.apache.org/thread/vml0v4q5spz1dj5x278dhxkgsw1zmq3f
>>>
>>> Shall I revert?
>>
>> No, it makes things more robust (JMX is more consistent).
>
> Okay. @Mark when you back-port, feel free to merge your fixes into the
> changelog item I added, or replace it at your pleasure.
We can leave your change as the fix and turn mine into just adding the
status as suggested by Rémy.
Mark
>
> -chris
>
>>>> On 17/11/2025 14:23, schultz@apache.org wrote:
>>>>> This is an automated email from the ASF dual-hosted git repository.
>>>>>
>>>>> schultz pushed a commit to branch main
>>>>> in repository https://gitbox.apache.org/repos/asf/tomcat.git
>>>>>
>>>>>
>>>>> The following commit(s) were added to refs/heads/main by this push:
>>>>> new 46ac1c5a47 Fix error building status JSON
>>>>> 46ac1c5a47 is described below
>>>>>
>>>>> commit 46ac1c5a4788a414ccf1a8db1fb20ad808d46357
>>>>> Author: Christopher Schultz <ch...@christopherschultz.net>
>>>>> AuthorDate: Mon Nov 17 09:22:21 2025 -0500
>>>>>
>>>>> Fix error building status JSON
>>>>> FailedContext was missing some attributes required to report
>>>>> application status
>>>>> ---
>>>>> java/org/apache/catalina/startup/FailedContext.java | 11 +++++++
>>>>> ++++
>>>>> 1 file changed, 11 insertions(+)
>>>>>
>>>>> diff --git a/java/org/apache/catalina/startup/FailedContext.java b/
>>>>> java/org/apache/catalina/startup/FailedContext.java
>>>>> index 199b0ffe30..af66450b98 100644
>>>>> --- a/java/org/apache/catalina/startup/FailedContext.java
>>>>> +++ b/java/org/apache/catalina/startup/FailedContext.java
>>>>> @@ -1432,4 +1432,15 @@ public class FailedContext extends
>>>>> LifecycleMBeanBase implements Context {
>>>>> public void setSuspendWrappedResponseAfterForward(boolean
>>>>> suspendWrappedResponseAfterForward) {
>>>>> }
>>>>> + public long getStartTime() {
>>>>> + return -1;
>>>>> + }
>>>>> +
>>>>> + public long getStartupTime() {
>>>>> + return -1;
>>>>> + }
>>>>> +
>>>>> + public long getTldScanTime() {
>>>>> + return -1;
>>>>> + }
>>>>> }
>>>>> \ No newline at end of file
>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>>>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: (tomcat) branch main updated: Fix error building status JSON
Posted by Christopher Schultz <ch...@christopherschultz.net>.
All,
On 11/17/25 1:41 PM, Rémy Maucherat wrote:
> On Mon, Nov 17, 2025 at 6:59 PM Christopher Schultz
> <ch...@christopherschultz.net> wrote:
>>
>> Mark,
>>
>> On 11/17/25 10:12 AM, Mark Thomas wrote:
>>> This issue had already been fixed.
>>>
>>> https://github.com/apache/tomcat/
>>> commit/3dca097687e935e57d28e9b915f8d8a4b3d3c0a5
>>>
>>> It has been discussed on the dev list and had been approved for back-port.
>>
>> Oh, sorry about that. I only see the conversation here:
>> https://lists.apache.org/thread/vml0v4q5spz1dj5x278dhxkgsw1zmq3f
>>
>> Shall I revert?
>
> No, it makes things more robust (JMX is more consistent).
Okay. @Mark when you back-port, feel free to merge your fixes into the
changelog item I added, or replace it at your pleasure.
-chris
>>> On 17/11/2025 14:23, schultz@apache.org wrote:
>>>> This is an automated email from the ASF dual-hosted git repository.
>>>>
>>>> schultz pushed a commit to branch main
>>>> in repository https://gitbox.apache.org/repos/asf/tomcat.git
>>>>
>>>>
>>>> The following commit(s) were added to refs/heads/main by this push:
>>>> new 46ac1c5a47 Fix error building status JSON
>>>> 46ac1c5a47 is described below
>>>>
>>>> commit 46ac1c5a4788a414ccf1a8db1fb20ad808d46357
>>>> Author: Christopher Schultz <ch...@christopherschultz.net>
>>>> AuthorDate: Mon Nov 17 09:22:21 2025 -0500
>>>>
>>>> Fix error building status JSON
>>>> FailedContext was missing some attributes required to report
>>>> application status
>>>> ---
>>>> java/org/apache/catalina/startup/FailedContext.java | 11 +++++++++++
>>>> 1 file changed, 11 insertions(+)
>>>>
>>>> diff --git a/java/org/apache/catalina/startup/FailedContext.java b/
>>>> java/org/apache/catalina/startup/FailedContext.java
>>>> index 199b0ffe30..af66450b98 100644
>>>> --- a/java/org/apache/catalina/startup/FailedContext.java
>>>> +++ b/java/org/apache/catalina/startup/FailedContext.java
>>>> @@ -1432,4 +1432,15 @@ public class FailedContext extends
>>>> LifecycleMBeanBase implements Context {
>>>> public void setSuspendWrappedResponseAfterForward(boolean
>>>> suspendWrappedResponseAfterForward) {
>>>> }
>>>> + public long getStartTime() {
>>>> + return -1;
>>>> + }
>>>> +
>>>> + public long getStartupTime() {
>>>> + return -1;
>>>> + }
>>>> +
>>>> + public long getTldScanTime() {
>>>> + return -1;
>>>> + }
>>>> }
>>>> \ No newline at end of file
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: (tomcat) branch main updated: Fix error building status JSON
Posted by Rémy Maucherat <re...@apache.org>.
On Mon, Nov 17, 2025 at 6:59 PM Christopher Schultz
<ch...@christopherschultz.net> wrote:
>
> Mark,
>
> On 11/17/25 10:12 AM, Mark Thomas wrote:
> > This issue had already been fixed.
> >
> > https://github.com/apache/tomcat/
> > commit/3dca097687e935e57d28e9b915f8d8a4b3d3c0a5
> >
> > It has been discussed on the dev list and had been approved for back-port.
>
> Oh, sorry about that. I only see the conversation here:
> https://lists.apache.org/thread/vml0v4q5spz1dj5x278dhxkgsw1zmq3f
>
> Shall I revert?
No, it makes things more robust (JMX is more consistent).
Rémy
> -chris
>
> > On 17/11/2025 14:23, schultz@apache.org wrote:
> >> This is an automated email from the ASF dual-hosted git repository.
> >>
> >> schultz pushed a commit to branch main
> >> in repository https://gitbox.apache.org/repos/asf/tomcat.git
> >>
> >>
> >> The following commit(s) were added to refs/heads/main by this push:
> >> new 46ac1c5a47 Fix error building status JSON
> >> 46ac1c5a47 is described below
> >>
> >> commit 46ac1c5a4788a414ccf1a8db1fb20ad808d46357
> >> Author: Christopher Schultz <ch...@christopherschultz.net>
> >> AuthorDate: Mon Nov 17 09:22:21 2025 -0500
> >>
> >> Fix error building status JSON
> >> FailedContext was missing some attributes required to report
> >> application status
> >> ---
> >> java/org/apache/catalina/startup/FailedContext.java | 11 +++++++++++
> >> 1 file changed, 11 insertions(+)
> >>
> >> diff --git a/java/org/apache/catalina/startup/FailedContext.java b/
> >> java/org/apache/catalina/startup/FailedContext.java
> >> index 199b0ffe30..af66450b98 100644
> >> --- a/java/org/apache/catalina/startup/FailedContext.java
> >> +++ b/java/org/apache/catalina/startup/FailedContext.java
> >> @@ -1432,4 +1432,15 @@ public class FailedContext extends
> >> LifecycleMBeanBase implements Context {
> >> public void setSuspendWrappedResponseAfterForward(boolean
> >> suspendWrappedResponseAfterForward) {
> >> }
> >> + public long getStartTime() {
> >> + return -1;
> >> + }
> >> +
> >> + public long getStartupTime() {
> >> + return -1;
> >> + }
> >> +
> >> + public long getTldScanTime() {
> >> + return -1;
> >> + }
> >> }
> >> \ No newline at end of file
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> >> For additional commands, e-mail: dev-help@tomcat.apache.org
> >>
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> > For additional commands, e-mail: dev-help@tomcat.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: (tomcat) branch main updated: Fix error building status JSON
Posted by Christopher Schultz <ch...@christopherschultz.net>.
Mark,
On 11/17/25 10:12 AM, Mark Thomas wrote:
> This issue had already been fixed.
>
> https://github.com/apache/tomcat/
> commit/3dca097687e935e57d28e9b915f8d8a4b3d3c0a5
>
> It has been discussed on the dev list and had been approved for back-port.
Oh, sorry about that. I only see the conversation here:
https://lists.apache.org/thread/vml0v4q5spz1dj5x278dhxkgsw1zmq3f
Shall I revert?
-chris
> On 17/11/2025 14:23, schultz@apache.org wrote:
>> This is an automated email from the ASF dual-hosted git repository.
>>
>> schultz pushed a commit to branch main
>> in repository https://gitbox.apache.org/repos/asf/tomcat.git
>>
>>
>> The following commit(s) were added to refs/heads/main by this push:
>> new 46ac1c5a47 Fix error building status JSON
>> 46ac1c5a47 is described below
>>
>> commit 46ac1c5a4788a414ccf1a8db1fb20ad808d46357
>> Author: Christopher Schultz <ch...@christopherschultz.net>
>> AuthorDate: Mon Nov 17 09:22:21 2025 -0500
>>
>> Fix error building status JSON
>> FailedContext was missing some attributes required to report
>> application status
>> ---
>> java/org/apache/catalina/startup/FailedContext.java | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>>
>> diff --git a/java/org/apache/catalina/startup/FailedContext.java b/
>> java/org/apache/catalina/startup/FailedContext.java
>> index 199b0ffe30..af66450b98 100644
>> --- a/java/org/apache/catalina/startup/FailedContext.java
>> +++ b/java/org/apache/catalina/startup/FailedContext.java
>> @@ -1432,4 +1432,15 @@ public class FailedContext extends
>> LifecycleMBeanBase implements Context {
>> public void setSuspendWrappedResponseAfterForward(boolean
>> suspendWrappedResponseAfterForward) {
>> }
>> + public long getStartTime() {
>> + return -1;
>> + }
>> +
>> + public long getStartupTime() {
>> + return -1;
>> + }
>> +
>> + public long getTldScanTime() {
>> + return -1;
>> + }
>> }
>> \ No newline at end of file
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: (tomcat) branch main updated: Fix error building status JSON
Posted by Mark Thomas <ma...@apache.org>.
This issue had already been fixed.
https://github.com/apache/tomcat/commit/3dca097687e935e57d28e9b915f8d8a4b3d3c0a5
It has been discussed on the dev list and had been approved for back-port.
Mark
On 17/11/2025 14:23, schultz@apache.org wrote:
> This is an automated email from the ASF dual-hosted git repository.
>
> schultz pushed a commit to branch main
> in repository https://gitbox.apache.org/repos/asf/tomcat.git
>
>
> The following commit(s) were added to refs/heads/main by this push:
> new 46ac1c5a47 Fix error building status JSON
> 46ac1c5a47 is described below
>
> commit 46ac1c5a4788a414ccf1a8db1fb20ad808d46357
> Author: Christopher Schultz <ch...@christopherschultz.net>
> AuthorDate: Mon Nov 17 09:22:21 2025 -0500
>
> Fix error building status JSON
>
> FailedContext was missing some attributes required to report application status
> ---
> java/org/apache/catalina/startup/FailedContext.java | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/java/org/apache/catalina/startup/FailedContext.java b/java/org/apache/catalina/startup/FailedContext.java
> index 199b0ffe30..af66450b98 100644
> --- a/java/org/apache/catalina/startup/FailedContext.java
> +++ b/java/org/apache/catalina/startup/FailedContext.java
> @@ -1432,4 +1432,15 @@ public class FailedContext extends LifecycleMBeanBase implements Context {
> public void setSuspendWrappedResponseAfterForward(boolean suspendWrappedResponseAfterForward) {
> }
>
> + public long getStartTime() {
> + return -1;
> + }
> +
> + public long getStartupTime() {
> + return -1;
> + }
> +
> + public long getTldScanTime() {
> + return -1;
> + }
> }
> \ No newline at end of file
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org