You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Jaimin Jetly <ja...@hortonworks.com> on 2017/01/24 00:12:02 UTC
Review Request 55865: Stack advisor needs to enforce component
dependency for slaves and masters
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55865/
-----------------------------------------------------------
Review request for Ambari, Jayush Luniya, Sumit Mohanty, and Yusaku Sako.
Bugs: AMBARI-19685
https://issues.apache.org/jira/browse/AMBARI-19685
Repository: ambari
Description
-------
* Install Ambari cluster with latest trunk bits
* Modify /var/lib/ambari-server/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml to add the following:
Add to <dependencies> node of ZEPPELIN_MASTER:
<dependency>
<name>SPARK/LIVY_SERVER</name>
<scope>host</scope>
</dependency>
Add to <service> node:
<requiredServices>
<service>SPARK</service>
</requiredServices>
* Install HDP 2.5.3 cluster with Spark
* Once the cluster is installed, use Add Service Wizard to add Zeppelin
* Assign Slaves and Clients step should appear (without the metainfo.xml change, it will be skipped)
* The user should not be able to proceed beyond this page unless at least one Livy Server is selected <- this validation should be handled by the stack advisor
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java adcb5b5
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProvider.java 5fc5f52
ambari-server/src/main/java/org/apache/ambari/server/state/DependencyConditionInfo.java 5d9358c
ambari-server/src/main/resources/properties.json 698b6c5
ambari-server/src/main/resources/stacks/stack_advisor.py ad3b510
ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py ff25512
Diff: https://reviews.apache.org/r/55865/diff/
Testing
-------
Tested installer and Add Service wizard to work with the patch as expected.
snapshots attached on the jira of the UI impact
Verfiied that related ambari-server (java/python) unit test passes with the patch
Thanks,
Jaimin Jetly
Re: Review Request 55865: Stack advisor needs to enforce component
dependency for slaves and masters
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55865/#review162990
-----------------------------------------------------------
Ship it!
Ship It!
- Jayush Luniya
On Jan. 24, 2017, 7:50 p.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55865/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2017, 7:50 p.m.)
>
>
> Review request for Ambari, Jayush Luniya, Sumit Mohanty, and Yusaku Sako.
>
>
> Bugs: AMBARI-19685
> https://issues.apache.org/jira/browse/AMBARI-19685
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Install Ambari cluster with latest trunk bits
> * Modify /var/lib/ambari-server/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml to add the following:
> Add to <dependencies> node of ZEPPELIN_MASTER:
> <dependency>
> <name>SPARK/LIVY_SERVER</name>
> <scope>host</scope>
> </dependency>
> Add to <service> node:
> <requiredServices>
> <service>SPARK</service>
> </requiredServices>
> * Install HDP 2.5.3 cluster with Spark
> * Once the cluster is installed, use Add Service Wizard to add Zeppelin
> * Assign Slaves and Clients step should appear (without the metainfo.xml change, it will be skipped)
> * The user should not be able to proceed beyond this page unless at least one Livy Server is selected <- this validation should be handled by the stack advisor
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java adcb5b5
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProvider.java 5fc5f52
> ambari-server/src/main/java/org/apache/ambari/server/state/DependencyConditionInfo.java 5d9358c
> ambari-server/src/main/resources/properties.json 698b6c5
> ambari-server/src/main/resources/stacks/stack_advisor.py ad3b510
> ambari-server/src/test/python/common-services/configs/services-master_ambari_colo-3-hosts.json c1b2655
> ambari-server/src/test/python/common-services/configs/services-master_standby_colo-3-hosts.json e4b48da
> ambari-server/src/test/python/common-services/configs/services-normal-hawq-3-hosts.json b896a71
> ambari-server/src/test/python/common-services/configs/services-normal-nohawq-3-hosts.json 675aacb
> ambari-server/src/test/python/common-services/configs/services-standby_ambari_colo-3-hosts.json 489d4df
> ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py ff25512
> ambari-server/src/test/python/stacks/2.5/common/services-normal-his-2-hosts.json 46a6f4d
>
> Diff: https://reviews.apache.org/r/55865/diff/
>
>
> Testing
> -------
>
> Tested installer and Add Service wizard to work with the patch as expected.
> snapshots attached to the reviewboard of the UI impact
> Verfiied that related ambari-server (java/python) unit test passes with the patch
>
>
> File Attachments
> ----------------
>
> Validation error
> https://reviews.apache.org/media/uploaded/files/2017/01/24/6fcfa745-e340-4373-919e-5b806749d50f__Validation_error.png
> Validation error cluster scope
> https://reviews.apache.org/media/uploaded/files/2017/01/24/99862028-b2e2-4994-8c11-7322f204b18c__Validation_error_cluster_scope.png
> Validation error host scope
> https://reviews.apache.org/media/uploaded/files/2017/01/24/c942ca85-6c5a-4ed0-beee-f0ce16b91532__Validation_error_host_scope.png
>
>
> Thanks,
>
> Jaimin Jetly
>
>
Re: Review Request 55865: Stack advisor needs to enforce component
dependency for slaves and masters
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55865/#review162852
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Jan. 24, 2017, 7:50 p.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55865/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2017, 7:50 p.m.)
>
>
> Review request for Ambari, Jayush Luniya, Sumit Mohanty, and Yusaku Sako.
>
>
> Bugs: AMBARI-19685
> https://issues.apache.org/jira/browse/AMBARI-19685
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Install Ambari cluster with latest trunk bits
> * Modify /var/lib/ambari-server/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml to add the following:
> Add to <dependencies> node of ZEPPELIN_MASTER:
> <dependency>
> <name>SPARK/LIVY_SERVER</name>
> <scope>host</scope>
> </dependency>
> Add to <service> node:
> <requiredServices>
> <service>SPARK</service>
> </requiredServices>
> * Install HDP 2.5.3 cluster with Spark
> * Once the cluster is installed, use Add Service Wizard to add Zeppelin
> * Assign Slaves and Clients step should appear (without the metainfo.xml change, it will be skipped)
> * The user should not be able to proceed beyond this page unless at least one Livy Server is selected <- this validation should be handled by the stack advisor
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java adcb5b5
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProvider.java 5fc5f52
> ambari-server/src/main/java/org/apache/ambari/server/state/DependencyConditionInfo.java 5d9358c
> ambari-server/src/main/resources/properties.json 698b6c5
> ambari-server/src/main/resources/stacks/stack_advisor.py ad3b510
> ambari-server/src/test/python/common-services/configs/services-master_ambari_colo-3-hosts.json c1b2655
> ambari-server/src/test/python/common-services/configs/services-master_standby_colo-3-hosts.json e4b48da
> ambari-server/src/test/python/common-services/configs/services-normal-hawq-3-hosts.json b896a71
> ambari-server/src/test/python/common-services/configs/services-normal-nohawq-3-hosts.json 675aacb
> ambari-server/src/test/python/common-services/configs/services-standby_ambari_colo-3-hosts.json 489d4df
> ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py ff25512
> ambari-server/src/test/python/stacks/2.5/common/services-normal-his-2-hosts.json 46a6f4d
>
> Diff: https://reviews.apache.org/r/55865/diff/
>
>
> Testing
> -------
>
> Tested installer and Add Service wizard to work with the patch as expected.
> snapshots attached to the reviewboard of the UI impact
> Verfiied that related ambari-server (java/python) unit test passes with the patch
>
>
> File Attachments
> ----------------
>
> Validation error
> https://reviews.apache.org/media/uploaded/files/2017/01/24/6fcfa745-e340-4373-919e-5b806749d50f__Validation_error.png
> Validation error cluster scope
> https://reviews.apache.org/media/uploaded/files/2017/01/24/99862028-b2e2-4994-8c11-7322f204b18c__Validation_error_cluster_scope.png
> Validation error host scope
> https://reviews.apache.org/media/uploaded/files/2017/01/24/c942ca85-6c5a-4ed0-beee-f0ce16b91532__Validation_error_host_scope.png
>
>
> Thanks,
>
> Jaimin Jetly
>
>
Re: Review Request 55865: Stack advisor needs to enforce component
dependency for slaves and masters
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55865/
-----------------------------------------------------------
(Updated Jan. 24, 2017, 7:50 p.m.)
Review request for Ambari, Jayush Luniya, Sumit Mohanty, and Yusaku Sako.
Bugs: AMBARI-19685
https://issues.apache.org/jira/browse/AMBARI-19685
Repository: ambari
Description
-------
* Install Ambari cluster with latest trunk bits
* Modify /var/lib/ambari-server/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml to add the following:
Add to <dependencies> node of ZEPPELIN_MASTER:
<dependency>
<name>SPARK/LIVY_SERVER</name>
<scope>host</scope>
</dependency>
Add to <service> node:
<requiredServices>
<service>SPARK</service>
</requiredServices>
* Install HDP 2.5.3 cluster with Spark
* Once the cluster is installed, use Add Service Wizard to add Zeppelin
* Assign Slaves and Clients step should appear (without the metainfo.xml change, it will be skipped)
* The user should not be able to proceed beyond this page unless at least one Livy Server is selected <- this validation should be handled by the stack advisor
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java adcb5b5
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProvider.java 5fc5f52
ambari-server/src/main/java/org/apache/ambari/server/state/DependencyConditionInfo.java 5d9358c
ambari-server/src/main/resources/properties.json 698b6c5
ambari-server/src/main/resources/stacks/stack_advisor.py ad3b510
ambari-server/src/test/python/common-services/configs/services-master_ambari_colo-3-hosts.json c1b2655
ambari-server/src/test/python/common-services/configs/services-master_standby_colo-3-hosts.json e4b48da
ambari-server/src/test/python/common-services/configs/services-normal-hawq-3-hosts.json b896a71
ambari-server/src/test/python/common-services/configs/services-normal-nohawq-3-hosts.json 675aacb
ambari-server/src/test/python/common-services/configs/services-standby_ambari_colo-3-hosts.json 489d4df
ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py ff25512
ambari-server/src/test/python/stacks/2.5/common/services-normal-his-2-hosts.json 46a6f4d
Diff: https://reviews.apache.org/r/55865/diff/
Testing
-------
Tested installer and Add Service wizard to work with the patch as expected.
snapshots attached to the reviewboard of the UI impact
Verfiied that related ambari-server (java/python) unit test passes with the patch
File Attachments
----------------
Validation error
https://reviews.apache.org/media/uploaded/files/2017/01/24/6fcfa745-e340-4373-919e-5b806749d50f__Validation_error.png
Validation error cluster scope
https://reviews.apache.org/media/uploaded/files/2017/01/24/99862028-b2e2-4994-8c11-7322f204b18c__Validation_error_cluster_scope.png
Validation error host scope
https://reviews.apache.org/media/uploaded/files/2017/01/24/c942ca85-6c5a-4ed0-beee-f0ce16b91532__Validation_error_host_scope.png
Thanks,
Jaimin Jetly
Re: Review Request 55865: Stack advisor needs to enforce component
dependency for slaves and masters
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55865/
-----------------------------------------------------------
(Updated Jan. 24, 2017, 12:16 a.m.)
Review request for Ambari, Jayush Luniya, Sumit Mohanty, and Yusaku Sako.
Bugs: AMBARI-19685
https://issues.apache.org/jira/browse/AMBARI-19685
Repository: ambari
Description
-------
* Install Ambari cluster with latest trunk bits
* Modify /var/lib/ambari-server/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml to add the following:
Add to <dependencies> node of ZEPPELIN_MASTER:
<dependency>
<name>SPARK/LIVY_SERVER</name>
<scope>host</scope>
</dependency>
Add to <service> node:
<requiredServices>
<service>SPARK</service>
</requiredServices>
* Install HDP 2.5.3 cluster with Spark
* Once the cluster is installed, use Add Service Wizard to add Zeppelin
* Assign Slaves and Clients step should appear (without the metainfo.xml change, it will be skipped)
* The user should not be able to proceed beyond this page unless at least one Livy Server is selected <- this validation should be handled by the stack advisor
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java adcb5b5
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProvider.java 5fc5f52
ambari-server/src/main/java/org/apache/ambari/server/state/DependencyConditionInfo.java 5d9358c
ambari-server/src/main/resources/properties.json 698b6c5
ambari-server/src/main/resources/stacks/stack_advisor.py ad3b510
ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py ff25512
Diff: https://reviews.apache.org/r/55865/diff/
Testing (updated)
-------
Tested installer and Add Service wizard to work with the patch as expected.
snapshots attached to the reviewboard of the UI impact
Verfiied that related ambari-server (java/python) unit test passes with the patch
File Attachments
----------------
Validation error
https://reviews.apache.org/media/uploaded/files/2017/01/24/6fcfa745-e340-4373-919e-5b806749d50f__Validation_error.png
Validation error cluster scope
https://reviews.apache.org/media/uploaded/files/2017/01/24/99862028-b2e2-4994-8c11-7322f204b18c__Validation_error_cluster_scope.png
Validation error host scope
https://reviews.apache.org/media/uploaded/files/2017/01/24/c942ca85-6c5a-4ed0-beee-f0ce16b91532__Validation_error_host_scope.png
Thanks,
Jaimin Jetly
Re: Review Request 55865: Stack advisor needs to enforce component
dependency for slaves and masters
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55865/
-----------------------------------------------------------
(Updated Jan. 24, 2017, 12:15 a.m.)
Review request for Ambari, Jayush Luniya, Sumit Mohanty, and Yusaku Sako.
Bugs: AMBARI-19685
https://issues.apache.org/jira/browse/AMBARI-19685
Repository: ambari
Description
-------
* Install Ambari cluster with latest trunk bits
* Modify /var/lib/ambari-server/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml to add the following:
Add to <dependencies> node of ZEPPELIN_MASTER:
<dependency>
<name>SPARK/LIVY_SERVER</name>
<scope>host</scope>
</dependency>
Add to <service> node:
<requiredServices>
<service>SPARK</service>
</requiredServices>
* Install HDP 2.5.3 cluster with Spark
* Once the cluster is installed, use Add Service Wizard to add Zeppelin
* Assign Slaves and Clients step should appear (without the metainfo.xml change, it will be skipped)
* The user should not be able to proceed beyond this page unless at least one Livy Server is selected <- this validation should be handled by the stack advisor
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java adcb5b5
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProvider.java 5fc5f52
ambari-server/src/main/java/org/apache/ambari/server/state/DependencyConditionInfo.java 5d9358c
ambari-server/src/main/resources/properties.json 698b6c5
ambari-server/src/main/resources/stacks/stack_advisor.py ad3b510
ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py ff25512
Diff: https://reviews.apache.org/r/55865/diff/
Testing
-------
Tested installer and Add Service wizard to work with the patch as expected.
snapshots attached on the jira of the UI impact
Verfiied that related ambari-server (java/python) unit test passes with the patch
File Attachments (updated)
----------------
Validation error
https://reviews.apache.org/media/uploaded/files/2017/01/24/6fcfa745-e340-4373-919e-5b806749d50f__Validation_error.png
Validation error cluster scope
https://reviews.apache.org/media/uploaded/files/2017/01/24/99862028-b2e2-4994-8c11-7322f204b18c__Validation_error_cluster_scope.png
Validation error host scope
https://reviews.apache.org/media/uploaded/files/2017/01/24/c942ca85-6c5a-4ed0-beee-f0ce16b91532__Validation_error_host_scope.png
Thanks,
Jaimin Jetly