[GitHub] [flink] dianfu commented on a change in pull request #10148: [FLINK-14693][hotfix][python] Python tox checks fails on travis

[GitBox <gi...@apache.org>]

dianfu commented on a change in pull request #10148: [FLINK-14693][hotfix][python] Python tox checks fails on travis
URL: https://github.com/apache/flink/pull/10148#discussion_r345031493
 
 

 ##########
 File path: flink-python/dev/lint-python.sh
 ##########
 @@ -213,11 +213,12 @@ function install_tox() {
         fi
     fi
 
-    # virtualenv 16.6.2 released in 2019-07-14 is incompatible with py27 and py34,
-    # force install an older version(16.0.0) to avoid this problem.
-    $CONDA_PATH install -p $CONDA_HOME -c conda-forge virtualenv=16.0.0 tox -y -q 2>&1 >/dev/null
+    # tox 3.14 released in conda-forge will download 0.1x and 0.2x versions of importlib_metadata
 
 Review comment:
   What about change the comments as follows?
   `# tox 3.14 depends on both 0.19 and 0.23 of importlib_metadata at the same time and conda will try to install both these two versions and it will cause problems occasionly. Using pip as the package manager could avoid this problem.`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services