[GitHub] [skywalking-java] lujiajing1126 commented on a change in pull request #25: Chore: Add benchmark and improve docs for exception-ignore plugin

[GitBox <gi...@apache.org>]

lujiajing1126 commented on a change in pull request #25:
URL: https://github.com/apache/skywalking-java/pull/25#discussion_r707983236



##########
File path: docs/en/setup/service-agent/java-agent/How-to-tolerate-exceptions.md
##########
@@ -107,8 +107,15 @@ If an exception has the `@IgnoredException` annotation, the exception wouldn't b
       `org.apache.skywalking.apm.agent.core.context.status.TestAnnotatedException`  | false |
 
 ## Recursive check
-Due to the wrapper nature of Java exceptions, sometimes users need recursive checking. Skywalking also supports it. Typically, we don't recommend setting this more than 10, which could cause a performance issue. Negative value and 0 would be ignored, which means all exceptions would make the span tagged in error status.
+Due to the wrapper nature of Java exceptions, sometimes users need recursive checking. Skywalking also supports it. 
 
 ```
-    statuscheck.max_recursive_depth=${SW_STATUSCHECK_MAX_RECURSIVE_DEPTH:1}
+statuscheck.max_recursive_depth=${SW_STATUSCHECK_MAX_RECURSIVE_DEPTH:1}
 ```
+
+According to the benchmark result, the exception check time is nearly proportional to the recursive depth being set.

Review comment:
       Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org