You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "nausharipov (via GitHub)" <gi...@apache.org> on 2023/03/24 15:35:28 UTC
[GitHub] [beam] nausharipov opened a new pull request, #25298: [ToB][Frontend] Save user code
nausharipov opened a new pull request, #25298:
URL: https://github.com/apache/beam/pull/25298
Resolves #24538
Resolves #25575
Resolves #25529
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] nausharipov commented on pull request #25298: [ToB][Frontend] Save user code
Posted by "nausharipov (via GitHub)" <gi...@apache.org>.
nausharipov commented on PR #25298:
URL: https://github.com/apache/beam/pull/25298#issuecomment-1415460613
R: @damondouglas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] nausharipov closed pull request #25298: [ToB][Frontend] Save user code
Posted by "nausharipov (via GitHub)" <gi...@apache.org>.
nausharipov closed pull request #25298: [ToB][Frontend] Save user code
URL: https://github.com/apache/beam/pull/25298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] nausharipov closed pull request #25298: [ToB][Frontend] Save user code
Posted by "nausharipov (via GitHub)" <gi...@apache.org>.
nausharipov closed pull request #25298: [ToB][Frontend] Save user code
URL: https://github.com/apache/beam/pull/25298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #25298: [ToB][Frontend] Save user code
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25298:
URL: https://github.com/apache/beam/pull/25298#issuecomment-1415464617
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] nausharipov commented on a diff in pull request #25298: [ToB][Frontend] Save user code
Posted by "nausharipov (via GitHub)" <gi...@apache.org>.
nausharipov commented on code in PR #25298:
URL: https://github.com/apache/beam/pull/25298#discussion_r1095565279
##########
learning/tour-of-beam/frontend/lib/pages/tour/state.dart:
##########
@@ -136,11 +142,123 @@ class TourNotifier extends ChangeNotifier with PageStateMixin<void> {
if (content == null) {
return;
}
- final taskSnippetId = content.taskSnippetId;
- await _setPlaygroundSnippet(taskSnippetId);
- _isShowingSolution = false;
+
+ await _updateHasSavedSnippet();
+ _setSnippetTypeSavedIfCan();
+ await _setCurrentSnippetFromType();
+ notifyListeners();
+ }
+
+ // Save user code.
Review Comment:
Save user code part will be extracted into a separate class in the [Save user code for anonymous user](https://github.com/apache/beam/issues/25283) task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] nausharipov commented on pull request #25298: [ToB][Frontend] Save user code
Posted by "nausharipov (via GitHub)" <gi...@apache.org>.
nausharipov commented on PR #25298:
URL: https://github.com/apache/beam/pull/25298#issuecomment-1418194602
.test-infra
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org