You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by "guiyanakuang (via GitHub)" <gi...@apache.org> on 2023/08/25 03:19:03 UTC

[GitHub] [orc] guiyanakuang opened a new pull request, #1599: ORC-1482: Adaptation to read ORC files created by CUDF

guiyanakuang opened a new pull request, #1599:
URL: https://github.com/apache/orc/pull/1599

   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If there is a discussion in the mailing list, please add the link.
   -->
   This pr is aimed at adapting to read ORC files created by CUDF, which may have missing statistics in their DOUBLE/FLOAT columns.
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   Official ORC readers can't read CUDF-created ORC files properly. 
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   Added UT.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [orc] dongjoon-hyun commented on pull request #1599: ORC-1482: Adaptation to read ORC files created by CUDF

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #1599:
URL: https://github.com/apache/orc/pull/1599#issuecomment-1692778420

   This is already in https://github.com/apache/orc/commit/36886ae19afe1c04541e4c919442eb1f836306a7, isn't it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [orc] dongjoon-hyun closed pull request #1599: ORC-1482: Adaptation to read ORC files created by CUDF

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #1599: ORC-1482: Adaptation to read ORC files created by CUDF
URL: https://github.com/apache/orc/pull/1599


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [orc] guiyanakuang commented on pull request #1599: ORC-1482: Adaptation to read ORC files created by CUDF

Posted by "guiyanakuang (via GitHub)" <gi...@apache.org>.
guiyanakuang commented on PR #1599:
URL: https://github.com/apache/orc/pull/1599#issuecomment-1692825367

   > This is already in [36886ae](https://github.com/apache/orc/commit/36886ae19afe1c04541e4c919442eb1f836306a7), isn't it?
   
   @dongjoon-hyun. The original pr I mistakenly thought was only merged into main, thanks for closing the duplicate pr. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [orc] dongjoon-hyun commented on pull request #1599: ORC-1482: Adaptation to read ORC files created by CUDF

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #1599:
URL: https://github.com/apache/orc/pull/1599#issuecomment-1692779295

   Let me close this because this PR looks a little strange.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org