You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/06/07 00:56:56 UTC

Review Request 22333: Added a hash function for PortRange.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22333/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Repository: mesos-git


Description
-------

See summary.


Diffs
-----

  src/linux/routing/filter/ip.hpp 52b7af7 

Diff: https://reviews.apache.org/r/22333/diff/


Testing
-------

Trivial.

But I did tested it with network isolator.


Thanks,

Jie Yu


Re: Review Request 22333: Added a hash function for PortRange.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22333/#review44978
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On June 6, 2014, 10:56 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22333/
> -----------------------------------------------------------
> 
> (Updated June 6, 2014, 10:56 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/linux/routing/filter/ip.hpp 52b7af7 
> 
> Diff: https://reviews.apache.org/r/22333/diff/
> 
> 
> Testing
> -------
> 
> Trivial.
> 
> But I did tested it with network isolator.
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Re: Review Request 22333: Added a hash function for PortRange.

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22333/#review45032
-----------------------------------------------------------


Bad patch!

Reviews applied: [22333]

Failed command: git apply --index 22333.patch

Error:
 error: patch failed: src/linux/routing/filter/ip.hpp:25
error: src/linux/routing/filter/ip.hpp: patch does not apply


- Mesos ReviewBot


On June 6, 2014, 10:56 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22333/
> -----------------------------------------------------------
> 
> (Updated June 6, 2014, 10:56 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/linux/routing/filter/ip.hpp 52b7af7 
> 
> Diff: https://reviews.apache.org/r/22333/diff/
> 
> 
> Testing
> -------
> 
> Trivial.
> 
> But I did tested it with network isolator.
> 
> 
> Thanks,
> 
> Jie Yu
> 
>