[jira] [Commented] (GEODE-2969) Meaningful exception information is stripped during exception handling

["Patrick Rhomberg (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061209#comment-16061209 ] 

Patrick Rhomberg commented on GEODE-2969:
-----------------------------------------

This regex will catch many potential instances of this issue.

{noformat}
ResultBuilder\.create\w+\(\w+\.getMessage\(\)\);
{noformat}

> Meaningful exception information is stripped during exception handling
> ----------------------------------------------------------------------
>
>                 Key: GEODE-2969
>                 URL: https://issues.apache.org/jira/browse/GEODE-2969
>             Project: Geode
>          Issue Type: Bug
>          Components: logging
>            Reporter: Patrick Rhomberg
>
> A number of contexts result in a less-than-meaningful message to log or console of simply `null`.  For instance, running `gfsh status locator` prints only `null`.
> This may be the result of exceptions being converted to exceptions of another type or to error results, but in the process losing important information by only passing `e.getMessage()` to the new type.  For instance, the above `gfsh status locator` is failing with a `java.lang.NumberFormatException: null`, but this exception is converted to `return ResultBuilder.createUserErrorResult(e.getMessage());`  In this case, `e.getMessage()` is `null`, where the more meaningful result is the type of exception.
> A fix to this will likely close GEODE-2569



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)